From: Hans-Christoph Steiner <hans@eds.org>
Date: Wed, 7 Jun 2017 09:33:01 +0000 (+0200)
Subject: rewritemeta: do not include empty Summary: or Description:
X-Git-Tag: 0.8~46^2
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=30ff777897c601bc446b0be983c8ba109caa5ab5;p=fdroidserver.git

rewritemeta: do not include empty Summary: or Description:

Since the Summary: and Description: in the metadata file has the highest
priority of all the localized texts, adding blank versions means that
apps would always have blank Summary and Description even if the app has
those fields in the localized sections of fdroiddata and/or in the app's
source repo itself.

fdroiddata!2262
---

diff --git a/fdroidserver/metadata.py b/fdroidserver/metadata.py
index 9d18c4a3..6ca9aace 100644
--- a/fdroidserver/metadata.py
+++ b/fdroidserver/metadata.py
@@ -1225,8 +1225,8 @@ def write_plaintext_metadata(mf, app, w_comment, w_field, w_build):
     mf.write('\n')
     w_field_nonempty('Name')
     w_field_nonempty('Auto Name')
-    w_field_always('Summary')
-    w_field_always('Description', description_txt(app.Description))
+    w_field_nonempty('Summary')
+    w_field_nonempty('Description', description_txt(app.Description))
     mf.write('\n')
     if app.RequiresRoot:
         w_field_always('Requires Root', 'yes')