From: Lennart Poettering Date: Thu, 8 Dec 2016 18:35:05 +0000 (+0100) Subject: util-lib: make sure fd_check_fstype() opens files with O_CLOEXEC X-Git-Tag: v233.3~123 X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=2ab3c9b133f3a79f940593cc40b4555f6bfd7f4a;p=elogind.git util-lib: make sure fd_check_fstype() opens files with O_CLOEXEC Also, O_NOCTTY is a safer bet, let's add that too. --- diff --git a/src/basic/stat-util.c b/src/basic/stat-util.c index 2a6e89b75..b62acdb7a 100644 --- a/src/basic/stat-util.c +++ b/src/basic/stat-util.c @@ -212,7 +212,7 @@ int fd_check_fstype(int fd, statfs_f_type_t magic_value) { int path_check_fstype(const char *path, statfs_f_type_t magic_value) { _cleanup_close_ int fd = -1; - fd = open(path, O_RDONLY); + fd = open(path, O_RDONLY|O_CLOEXEC|O_NOCTTY); if (fd < 0) return -errno;