From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 27 Mar 2018 12:56:04 +0000 (+0200)
Subject: util: check for overflows in xbsearch_r()
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=1a32e6e6b0f8efd825ba0c4fc4d144a65f799455;p=elogind.git

util: check for overflows in xbsearch_r()
---

diff --git a/src/basic/util.c b/src/basic/util.c
index e096e3194..3ea2e6f67 100644
--- a/src/basic/util.c
+++ b/src/basic/util.c
@@ -186,11 +186,13 @@ void *xbsearch_r(const void *key, const void *base, size_t nmemb, size_t size,
         const void *p;
         int comparison;
 
+        assert(!size_multiply_overflow(nmemb, size));
+
         l = 0;
         u = nmemb;
         while (l < u) {
                 idx = (l + u) / 2;
-                p = (const char *) base + idx * size;
+                p = (const uint8_t*) base + idx * size;
                 comparison = compar(key, p, arg);
                 if (comparison < 0)
                         u = idx;