From: Daniel Martí <mvdan@mvdan.cc>
Date: Tue, 19 Nov 2013 14:47:53 +0000 (+0100)
Subject: Properly convert boolean strings to bools as before
X-Git-Tag: 0.1~162^2~2
X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=11f4165f374cee7e6fc6b7964bfd5fe304841d60;p=fdroidserver.git

Properly convert boolean strings to bools as before
---

diff --git a/fdroidserver/metadata.py b/fdroidserver/metadata.py
index f02079be..904dd134 100644
--- a/fdroidserver/metadata.py
+++ b/fdroidserver/metadata.py
@@ -107,15 +107,19 @@ valuetypes = {
 
 def check_metadata(info):
     for k, t in valuetypes.iteritems():
-        for field in [f for f in t.fields if f in info]:
-            t.check(info[field], info['id'])
-            if k == 'Bool':
-                info[field] = info[field] == "Yes"
+        for field in t.fields:
+            if field in info:
+                t.check(info[field], info['id'])
+                if k == 'Bool':
+                    info[field] = info[field] == "Yes"
         for build in info['builds']:
-            for attr in [a for a in t.attrs if a in build]:
-                t.check(build[attr], info['id'])
-                if k == 'bool':
-                    info[field] = info[field] == "yes"
+            for attr in t.attrs:
+                if attr in build:
+                    t.check(build[attr], info['id'])
+                    if k == 'bool':
+                        build[attr] = build[attr] == "yes"
+                elif k == 'bool':
+                    build[attr] = False
 
 # Formatter for descriptions. Create an instance, and call parseline() with
 # each line of the description source from the metadata. At the end, call