From: azarah@nosferatu.za.org Date: Tue, 25 Nov 2003 07:25:06 +0000 (-0800) Subject: [PATCH] more config file parsing robustness X-Git-Tag: 008~36 X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;ds=sidebyside;h=befd83cc4ee33f6a557b531d4a1be13472ec67cd;p=elogind.git [PATCH] more config file parsing robustness udev kept on segfaulting when it was in use, and not having the time (and building it with DEBUG=true showing nothing), I have not tracked it until tonight. Seems like I made a type-o, and forgotten the ':' between one line's group and permission parameters. Attached patch should stop the segfault, and warn at that at least. --- diff --git a/namedev.c b/namedev.c index 83852f9df..391da7efc 100644 --- a/namedev.c +++ b/namedev.c @@ -464,6 +464,10 @@ static int namedev_init_permissions(void) } strncpy(dev.group, temp2, sizeof(dev.owner)); + if (!temp) { + dbg("cannot parse line: %s", line); + continue; + } dev.mode = strtol(temp, NULL, 8); dbg_parse("name='%s', owner='%s', group='%s', mode=%#o",