From: Marcus Hoffmann Date: Wed, 16 Aug 2017 22:49:53 +0000 (+0200) Subject: makebuildserver: verify https all requests to avoid urllib3 warnings X-Git-Tag: 0.9~98^2 X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;ds=sidebyside;h=ae613ab277baff39d9ebc46445ee7734575057a4;p=fdroidserver.git makebuildserver: verify https all requests to avoid urllib3 warnings According to http://docs.python-requests.org/en/master/user/advanced/#ca-certificates python-requests >= 2.4.0 will use the certifi provided certificates. We already recommend installing python3-certifi in the docs. On debian requests is patched to use the system trust store instead. --- diff --git a/makebuildserver b/makebuildserver index df553fa2..797a8097 100755 --- a/makebuildserver +++ b/makebuildserver @@ -391,7 +391,7 @@ def update_cache(cachedir, cachefiles): if download: r = requests.get(srcurl, headers=resume_header, - stream=True, verify=False, allow_redirects=True) + stream=True, allow_redirects=True) content_length = int(r.headers.get('content-length')) with open(local_filename, 'ab') as f: for chunk in progress.bar(r.iter_content(chunk_size=65536),