fix mistake: lists use .append() not .add()

This was a mistake in 5ad3486741cee7d76d251cc27a49e1b4fa7310b9

diff --git a/fdroidserver/update.py b/fdroidserver/update.py
index e26388b60bbfc54ffe721c993547e772c87bc6f7..552ad33a37e9affbbc33106bcb08d733030a4559 100644 (file)
--- a/fdroidserver/update.py
+++ b/fdroidserver/update.py
@@ -857,7 +857,7 @@ def scan_apk(apkcache, apkfilename, repodir, knownapks, use_date_from_apk):
                     perm_match['maxSdkVersion']
                 )
 
-                apk['uses-permission'].add(permission)
+                apk['uses-permission'].append(permission)
             elif line.startswith('uses-permission-sdk-23:'):
                 perm_match = re.match(APK_PERMISSION_PAT, line).groupdict()
                 if perm_match['maxSdkVersion']:
@@ -867,7 +867,7 @@ def scan_apk(apkcache, apkfilename, repodir, knownapks, use_date_from_apk):
                     perm_match['maxSdkVersion']
                 )
 
-                apk['uses-permission-sdk-23'].add(permission_sdk_23)
+                apk['uses-permission-sdk-23'].append(permission_sdk_23)
 
             elif line.startswith('uses-feature:'):
                 feature = re.match(APK_FEATURE_PAT, line).group(1)

diff --git a/tests/repo/index.xml b/tests/repo/index.xml
index 01ee18a8a84f34526bbb40eff4cf010877fdcc7c..052381a22e35f9d16cef1f81efaa9b39a65ad59b 100644 (file)
--- a/tests/repo/index.xml
+++ b/tests/repo/index.xml
@@ -54,14 +54,18 @@
                        <version>0.1</version>
                        <versioncode>1444412523</versioncode>
                        <apkname>obb.main.oldversion_1444412523.apk</apkname>
-                       <hash type="sha256">7562a36c9e2b38013b96663cf41f0f290dc7a248a81befa8d89e14f390c94c7f</hash>
-                       <size>11470</size>
+                       <hash type="sha256">c5f149e526f89c05c62923bdb7bb1e2be5673c46ec85143f41e514340631449c</hash>
+                       <size>14323</size>
                        <sdkver>4</sdkver>
                        <targetSdkVersion>18</targetSdkVersion>
                        <obbMainFile>main.1434483388.obb.main.oldversion.obb</obbMainFile>
                        <obbMainFileSha256>d3eb539a556352f3f47881d71fb0e5777b2f3e9a4251d283c18c67ce996774b7</obbMainFileSha256>
                        <added>2013-12-31</added>
-                       <sig>b4964fd759edaa54e65bb476d0276880</sig>
+                       <sig>eb41d4d6082bb3e81c3d58dbf7fc7332</sig>
+                       <permissions>ACCESS_NETWORK_STATE,ACCESS_WIFI_STATE,BLUETOOTH,BLUETOOTH_ADMIN,CHANGE_NETWORK_STATE,CHANGE_WIFI_MULTICAST_STATE,CHANGE_WIFI_STATE,INTERNET,NFC,RECEIVE_BOOT_COMPLETED</permissions>
+                       <uses-permission maxSdkVersion="22" name="android.permission.ACCESS_NETWORK_STATE"/>
+                       <uses-permission maxSdkVersion="18" name="android.permission.BLUETOOTH_ADMIN"/>
+                       <uses-permission-sdk-23 maxSdkVersion="25" name="android.permission.WRITE_SETTINGS"/>
                </package>
        </application>
        <application id="obb.main.twoversions">

diff --git a/tests/repo/obb.main.oldversion_1444412523.apk b/tests/repo/obb.main.oldversion_1444412523.apk
index 94ed95034e692d6c163b6b481055f37f914298cc..b9c7d7fde54667dde100dde6e9632c8f83566cf4 100644 (file)
Binary files a/tests/repo/obb.main.oldversion_1444412523.apk and b/tests/repo/obb.main.oldversion_1444412523.apk differ