fix "fdroidserver/build.py:41: redefinition of unused 'paramiko' from line 39"

pyflakes gave this error based on the `paramiko = None` statement. I used
a different way to test whether paramiko was successfully imported that is
directly based on the relevant Exceptions.

diff --git a/fdroidserver/build.py b/fdroidserver/build.py
index ccb846051414d3bbc29470fd34b0b797afb84f24..d062cc9e4091850ad263b53b064e27bc09cf731c 100644 (file)
--- a/fdroidserver/build.py
+++ b/fdroidserver/build.py
@@ -37,8 +37,8 @@ from common import BuildException, VCSException, FDroidPopen, SilentPopen
 
 try:
     import paramiko
-except:
-    paramiko = None
+except ImportError:
+    pass
 
 def get_builder_vm_id():
     vd = os.path.join('builder', '.vagrant')
@@ -244,7 +244,9 @@ def release_vm():
 def build_server(app, thisbuild, vcs, build_dir, output_dir, force):
     """Do a build on the build server."""
 
-    if not paramiko:
+    try:
+        paramiko
+    except NameError:
         raise BuildException("Paramiko is required to use the buildserver")
     if options.verbose:
         logging.getLogger("paramiko").setLevel(logging.DEBUG)