Don't use the commits feed as a changelog link in import

If it's often not a replacement for a proper changelog, do not advise its
usage.

diff --git a/fdroidserver/import.py b/fdroidserver/import.py
index 5e0c6b02321618b2902ef9346062feb1d096e593..fa9c02537a3d8adda95ce0dc9497e2819babd393 100644 (file)
--- a/fdroidserver/import.py
+++ b/fdroidserver/import.py
@@ -128,7 +128,6 @@ def main():
     # Figure out what kind of project it is...
     projecttype = None
     issuetracker = None
-    changelog = None
     license = None
     website = url  # by default, we might override it
     if url.startswith('git://'):
@@ -144,7 +143,6 @@ def main():
         sourcecode = url
         issuetracker = url + '/issues'
         website = ""
-        changelog = url + '/commits'
     elif url.startswith('https://gitlab.com/'):
         projecttype = 'gitlab'
         repo = url
@@ -288,8 +286,6 @@ def main():
     app['Source Code'] = sourcecode
     if issuetracker:
         app['Issue Tracker'] = issuetracker
-    if changelog:
-        app['Changelog'] = changelog
     if license:
         app['License'] = license
     app['Repo Type'] = repotype

diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py
index 169dc14764c5359eef5a067653f1172bfbf845bc..d0dedecc9999710507f7de736cb1ac68d25658c6 100644 (file)
--- a/fdroidserver/lint.py
+++ b/fdroidserver/lint.py
@@ -125,10 +125,6 @@ regex_pedantic = {
         (re.compile(r'.*github\.com/[^/]+/[^/]+/issues/.*'),
          "/issues is often enough on its own"),
     ],
-    'Changelog': [
-        (re.compile(r'.*commit.*', re.IGNORECASE),
-         "Not every commit log is suitable as change log"),
-    ],
     'Summary': [
         (re.compile(r'.*[a-z0-9][.!?][ $]'),
          "Punctuation should be avoided"),