chiark / gitweb /
remove setting git name/email for binary transparency logs
authorHans-Christoph Steiner <hans@eds.org>
Sun, 2 Apr 2017 21:07:05 +0000 (23:07 +0200)
committerHans-Christoph Steiner <hans@eds.org>
Mon, 3 Apr 2017 18:24:21 +0000 (20:24 +0200)
The machine running the steps should include the git config, so that it is
specific to that machines.

fdroidserver/common.py

index cc4567dcc139e43c5ed4b462df1e43cf52c33cdb..e07c46c381d4940784fce2abaa647ba33a85ed05 100644 (file)
@@ -28,7 +28,6 @@ import re
 import shutil
 import glob
 import json
-import platform
 import stat
 import subprocess
 import time
@@ -2373,16 +2372,19 @@ def make_binary_transparency_log(repodirs, btrepo='binary_transparency',
             os.mkdir(btrepo)
         gitrepo = git.Repo.init(btrepo)
 
-        gitconfig = gitrepo.config_writer()
-        gitconfig.set_value('user', 'name', commit_title)
-        gitconfig.set_value('user', 'email', 'fdroid@' + platform.node())
-
         if not url:
             url = config['repo_url'].rstrip('/')
         with open(os.path.join(btrepo, 'README.md'), 'w') as fp:
             fp.write("""
 # Binary Transparency Log for %s
 
+This is a log of the signed app index metadata.  This is stored in a
+git repo, which serves as an imperfect append-only storage mechanism.
+People can then check that any file that they received from that
+F-Droid repository was a publicly released file.
+
+For more info on this idea:
+* https://wiki.mozilla.org/Security/Binary_Transparency
 """ % url[:url.rindex('/')])  # strip '/repo'
         gitrepo.index.add(['README.md', ])
         gitrepo.index.commit('add README')