chiark / gitweb /
lint: better type safety
authorDaniel Martí <mvdan@mvdan.cc>
Wed, 19 Aug 2015 01:07:01 +0000 (18:07 -0700)
committerDaniel Martí <mvdan@mvdan.cc>
Wed, 19 Aug 2015 01:07:01 +0000 (18:07 -0700)
fdroidserver/lint.py

index 9c59fd37d768c8ac2de01d4da6d07df3c7a9d005..ee6eca7cb077b8c1d89424686eb01c27ec7d9ca3 100644 (file)
@@ -260,14 +260,14 @@ def main():
         # Regex checks in all kinds of fields
         for f in regex_warnings:
             for m, r in regex_warnings[f]:
-                t = metadata.metafieldtype(f)
-                if t == 'string':
-                    if app[f] is None:
+                v = app[f]
+                if type(v) == str:
+                    if v is None:
                         continue
-                    if m.match(app[f]):
+                    if m.match(v):
                         warn("%s '%s': %s" % (f, app[f], r))
-                elif t == 'multiline':
-                    for l in app[f]:
+                elif type(v) == list:
+                    for l in v:
                         if m.match(l):
                             warn("%s at line '%s': %s" % (f, l, r))