chiark / gitweb /
Hotfix for 7b68b90569 - don't cal .split() on None
authorDaniel Martí <mvdan@mvdan.cc>
Fri, 26 Jun 2015 15:58:57 +0000 (17:58 +0200)
committerDaniel Martí <mvdan@mvdan.cc>
Fri, 26 Jun 2015 15:58:57 +0000 (17:58 +0200)
fdroidserver/update.py

index f44f3549814e69b2c4e6115582882a898fd45cf6..b54eb1efff16ddef3adf4ab90beadff0191283c2 100644 (file)
@@ -832,17 +832,19 @@ def make_index(apps, sortedids, apks, repodir, archive, categories):
         addElement('marketversion', app['Current Version'], doc, apel)
         addElement('marketvercode', app['Current Version Code'], doc, apel)
 
-        af = app['AntiFeatures'].split(',')
-        # TODO: Temporarily not including UpstreamNonFree in the index,
-        # because current F-Droid clients do not understand it, and also
-        # look ugly when they encounter an unknown antifeature. This
-        # filtering can be removed in time...
-        if 'UpstreamNonFree' in af:
-            af.remove('UpstreamNonFree')
-        if af:
-            addElement('antifeatures', ','.join(af), doc, apel)
-        pv = app['Provides'].split(',')
-        addElement('provides', ','.join(pv), doc, apel)
+        if app['AntiFeatures']:
+            af = app['AntiFeatures'].split(',')
+            # TODO: Temporarily not including UpstreamNonFree in the index,
+            # because current F-Droid clients do not understand it, and also
+            # look ugly when they encounter an unknown antifeature. This
+            # filtering can be removed in time...
+            if 'UpstreamNonFree' in af:
+                af.remove('UpstreamNonFree')
+            if af:
+                addElement('antifeatures', ','.join(af), doc, apel)
+        if app['Provides']:
+            pv = app['Provides'].split(',')
+            addElement('provides', ','.join(pv), doc, apel)
         if app['Requires Root']:
             addElement('requirements', 'root', doc, apel)