Remove a pointless test of an array for NULL

Fixes this harmless warning:

  ../src/types.c:459:7: warning: the comparison will always evaluate as 'true' for the address of 'sortlist' will never be NULL [-Waddress]

diff --git a/changelog b/changelog
index ad2b6188b79e771fa897803e7b0246ebd100540e..073db37d9bb183d4fc2a72c1a78a0684880ac1e3 100644 (file)
--- a/changelog
+++ b/changelog
@@ -2,6 +2,7 @@ adns (1.6.2) UPSTREAM; urgency=low
 
   * Disable debugging output to stderr from adns_addr2text
     and adns_text2addr.
+  * Fix a harmelss compiler warning about sortlist never being NULL.
 
  --
 

diff --git a/src/types.c b/src/types.c
index d79f4a07045e99f197b83b6aaaac34e0e7156f3a..03f8d07629249efd89abc4a7803e0dcd81d8deef 100644 (file)
--- a/src/types.c
+++ b/src/types.c
@@ -456,7 +456,6 @@ static int search_sortlist_sa(adns_state ads, const struct sockaddr *sa) {
 static int dip_sockaddr(adns_state ads,
                        const struct sockaddr *sa,
                        const struct sockaddr *sb) {
-  if (!ads->sortlist) return 0;
   return search_sortlist_sa(ads, sa) > search_sortlist_sa(ads, sb);
 }