if a build did verify against Binaries:, delete the comparison dirs

If the comparison between the provided APK and the built APK is verified,
then there is no need to keep the old comparison files around. On big build
servers like f-droid.org, there will be thousands of leftover dirs from all
the builds, so this is necessary.

diff --git a/fdroidserver/common.py b/fdroidserver/common.py
index 2ea438850f4d461d4ce7fb65c5d9cd7079f3818d..b7986d20e2476de96a8b0dc09114654201692692 100644 (file)
--- a/fdroidserver/common.py
+++ b/fdroidserver/common.py
@@ -1918,6 +1918,10 @@ def compare_apks(apk1, apk2, tmp_dir):
             p = FDroidPopen(['meld', apk1dir, apk2dir], output=False)
         return("Unexpected diff output - " + p.output)
 
+    # since everything verifies, delete the comparison to keep cruft down
+    shutil.rmtree(apk1dir)
+    shutil.rmtree(apk2dir)
+
     # If we get here, it seems like they're the same!
     return None