chiark / gitweb /
script: on insert, call piece_modify, implying _image
authorIan Jackson <ijackson@chiark.greenend.org.uk>
Tue, 21 Jun 2022 21:10:19 +0000 (22:10 +0100)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Tue, 21 Jun 2022 21:12:48 +0000 (22:12 +0100)
Previously, we ad-hoc open-coded:

  delem.innerHTML = info.svg
  p.pelem = pelem,
  p.uos = info.uos;
  piece_resolve_special(piece, p);

but this forgot:

  p.bbox = info.bbox;
  p.desc = info.desc;

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
templates/script.ts

index a01b19df483ef870ed60fa2f7653c34af12a8143..f63cd01f673795cc19dd58a03b1a93b956ff0159 100644 (file)
@@ -1914,7 +1914,6 @@ function insert_piece(piece: PieceId, xp: any,
   console.log('PIECE UPDATE INSERT ',piece,info)
   let delem = document.createElementNS(svg_ns,'defs');
   delem.setAttributeNS(null,'id','defs'+piece);
-  delem.innerHTML = info.svg;
   defs_marker.insertAdjacentElement('afterend', delem);
   let pelem = piece_element('piece',piece);
   let uelem = document.createElementNS(svg_ns,'use');
@@ -1923,14 +1922,11 @@ function insert_piece(piece: PieceId, xp: any,
   uelem.setAttributeNS(null,'data-piece',piece);
   let p = {
     uelem: uelem,
-    pelem: pelem,
     delem: delem,
   } as any as PieceInfo; // fudge this, piece_modify_core will fix it
   pieces[piece] = p;
-  p.uos = info.uos;
   p.queued_moves = 0;
-  piece_resolve_special(piece, p);
-  piece_modify_core(piece, p, info);
+  piece_modify(piece, p, info);
   return p;
 }