chiark / gitweb /
Don't try reading lines from directories
authorDaniel Martí <mvdan@mvdan.cc>
Fri, 17 Apr 2015 11:02:47 +0000 (13:02 +0200)
committerDaniel Martí <mvdan@mvdan.cc>
Fri, 17 Apr 2015 11:05:12 +0000 (13:05 +0200)
fdroidserver/build.py
fdroidserver/common.py

index f80fb933bdfe0a5999c96c541f4258509ec9388c..e44dd5bb4d6e2687adba80e448c03663d4dd1cdf 100644 (file)
@@ -434,6 +434,8 @@ def adapt_gradle(build_dir):
             if not filename.endswith('.gradle'):
                 continue
             path = os.path.join(root, filename)
+            if not os.path.isfile(path):
+                continue
             logging.debug("Adapting %s at %s" % (filename, path))
 
             FDroidPopen(['sed', '-i',
index 810cf729798b48582a0273e148c66784834de576..ec4a6eea48acaffb8575a0a7d1861fa1ef5dc817 100644 (file)
@@ -1312,6 +1312,8 @@ def prepare_source(vcs, app, build, build_dir, srclib_dir, extlib_dir, onserver=
                 if not filename.endswith('.gradle'):
                     continue
                 path = os.path.join(dir_path, filename)
+                if not os.path.isfile(path):
+                    continue
                 for line in file(path):
                     match = version_regex.match(line)
                     if match:
@@ -1588,6 +1590,8 @@ def scan_source(build_dir, root_dir, thisbuild):
                     warnproblem('unknown compressed or binary file', fd)
 
             elif has_extension(fp, 'java') and os.path.isfile(fp):
+                if not os.path.isfile(fp):
+                    continue
                 for line in file(fp):
                     if 'DexClassLoader' in line:
                         count += handleproblem('DexClassLoader', fd, fp)