chiark / gitweb /
A couple of minor update checking improvements
authorCiaran Gultnieks <ciaran@ciarang.com>
Fri, 27 Jan 2012 19:18:16 +0000 (19:18 +0000)
committerCiaran Gultnieks <ciaran@ciarang.com>
Fri, 27 Jan 2012 19:18:16 +0000 (19:18 +0000)
checkupdates.py

index 2532768d152e4fc842216f8efd2395873f2c251a..0ccb89871243835f6dead93c40fc876ff58683a1 100755 (executable)
@@ -37,7 +37,12 @@ execfile('config.py')
 def check_market(app):
     time.sleep(5)
     url = 'http://market.android.com/details?id=' + app['id']
-    page = urllib.urlopen(url).read()
+    req = urllib.urlopen(url)
+    if req.getcode() == 404:
+        return (None, 'Not in market')
+    elif req.getcode() != 200:
+        return (None, 'Return code ' + str(req.getcode()))
+    page = req.read()
 
     version = None
     vercode = None
@@ -46,6 +51,9 @@ def check_market(app):
     if m:
         version = html_parser.unescape(m.group(1))
 
+    if version == 'Varies with device':
+        return (None, 'Device-variable version, cannot use this method')
+
     m = re.search('data-paramValue="(\d+)"><div class="goog-menuitem-content">Latest Version<', page)
     if m:
         vercode = m.group(1)