chiark / gitweb /
Some firmware programming improvements in the error handling.
authordaid <daid303@gmail.com>
Fri, 28 Nov 2014 11:14:29 +0000 (12:14 +0100)
committerYouness Alaoui <kakaroto@kakaroto.homelinux.net>
Thu, 15 Jan 2015 18:51:57 +0000 (13:51 -0500)
Cura/avr_isp/stk500v2.py
Cura/gui/firmwareInstall.py

index 62fd17260f0d78ea7c91f510040378103a1a48f8..27e679f1da3bba9fda89aa12f4fff726db4664d3 100644 (file)
@@ -7,6 +7,7 @@ import os, struct, sys, time
 
 from serial import Serial
 from serial import SerialException
+from serial import SerialTimeoutException
 
 import ispBase, intelHex
 
@@ -133,7 +134,7 @@ class Stk500v2(ispBase.IspBase):
                try:
                        self.serial.write(message)
                        self.serial.flush()
-               except Serial.SerialTimeoutException:
+               except SerialTimeoutException:
                        raise ispBase.IspError('Serial send timeout')
                self.seq = (self.seq + 1) & 0xFF
                return self.recvMessage()
index 1dc9844b0c2998a1e0c1e9409e3a0c30a1a1d0a6..4dd751e709d42e57053b5f2617aef8bdb6b328ea 100644 (file)
@@ -110,7 +110,7 @@ class InstallFirmware(wx.Dialog):
                                                programmer.connect(self.port)
                                                break
                                        except ispBase.IspError:
-                                               pass
+                                               programmer.close()
                                time.sleep(1)
                                if not self:
                                        #Window destroyed
@@ -119,7 +119,7 @@ class InstallFirmware(wx.Dialog):
                        try:
                                programmer.connect(self.port)
                        except ispBase.IspError:
-                               pass
+                               programmer.close()
 
                if not programmer.isConnected():
                        wx.MessageBox(_("Failed to find machine for firmware upgrade\nIs your machine connected to the PC?"),