X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=udev-add.c;h=7d0bdadcb75fe3821bdfe1dff57f6a7fce6027db;hb=116176b0bde45832d212b60e8d7bcb5d87f5ce46;hp=d158c41b1d54adbc138a28d9ea098f1e855c9a95;hpb=c2405f502cae4a634a25674306cffefb85df9ebb;p=elogind.git

diff --git a/udev-add.c b/udev-add.c
index d158c41b1..7d0bdadcb 100644
--- a/udev-add.c
+++ b/udev-add.c
@@ -34,17 +34,14 @@
 #include "udevdb.h"
 #include "libsysfs/libsysfs.h"
 
-
 /* 
  * Right now the major/minor of a device is stored in a file called
  * "dev" in sysfs.
  * The number is stored as:
- * 	MMmm
+ * 	MM:mm
  * 		MM is the major
  * 		mm is the minor
- * 		The value is in hex.
- * Yes, this will probably change when we go to a bigger major/minor
- * range, and will have to be changed at that time.
+ * 		The value is in decimal.
  */
 static int get_major_minor(struct sysfs_class_device *class_dev, int *major, int *minor)
 {
@@ -71,51 +68,45 @@ exit:
 /*
  * We also want to add some permissions here, and possibly some symlinks
  */
-static int create_node(char *name, char type, int major, int minor, mode_t mode)
+static int create_node(struct udevice *dev)
 {
 	char filename[255];
 	int retval = 0;
-	strncpy(filename, UDEV_ROOT, sizeof(filename));
-	strncat(filename, name, sizeof(filename));
-	switch (type) {
+
+	strncpy(filename, udev_root, sizeof(filename));
+	strncat(filename, dev->name, sizeof(filename));
+
+	switch (dev->type) {
 	case 'b':
-		mode |= S_IFBLK;
+		dev->mode |= S_IFBLK;
 		break;
 	case 'c':
 	case 'u':
-		mode |= S_IFCHR;
+		dev->mode |= S_IFCHR;
 		break;
 	case 'p':
-		mode |= S_IFIFO;
+		dev->mode |= S_IFIFO;
 		break;
 	default:
-		dbg("unknown node type %c\n", type);
+		dbg("unknown node type %c\n", dev->type);
 		return -EINVAL;
 	}
 
-	dbg("mknod(%s, %#o, %u, %u)", filename, mode, major, minor);
-	retval = mknod(filename, mode, makedev(major, minor));
+	dbg("mknod(%s, %#o, %u, %u)", filename, dev->mode, dev->major, dev->minor);
+	retval = mknod(filename, dev->mode, makedev(dev->major, dev->minor));
 	if (retval)
 		dbg("mknod(%s, %#o, %u, %u) failed with error '%s'",
-		    filename, mode, major, minor, strerror(errno));
+		    filename, dev->mode, dev->major, dev->minor, strerror(errno));
+
+	// FIXME set the ownership of the node
 	return retval;
 }
 
 static struct sysfs_class_device *get_class_dev(char *device_name)
 {
-	char sysfs_path[SYSFS_PATH_MAX];
 	char dev_path[SYSFS_PATH_MAX];
-	int retval;
 	struct sysfs_class_device *class_dev = NULL;
 
-
-	retval = sysfs_get_mnt_path(sysfs_path, SYSFS_PATH_MAX);
-	dbg("sysfs_path = %s", sysfs_path);
-	if (retval) {
-		dbg("sysfs_get_mnt_path failed");
-		goto exit;
-	}
-
 	strcpy(dev_path, sysfs_path);
 	strcat(dev_path, device_name);
 
@@ -133,27 +124,57 @@ exit:
 	return class_dev;
 }
 
-int udev_add_device(char *device, char *subsystem)
+/* wait for the "dev" file to show up in the directory in sysfs.
+ * If it doesn't happen in about 10 seconds, give up.
+ */
+#define SECONDS_TO_WAIT_FOR_DEV		10
+static int sleep_for_dev(char *path)
+{
+	char filename[SYSFS_PATH_MAX + 6];
+	struct stat buf;
+	int loop = 0;
+	int retval = -ENODEV;
+
+	strcpy(filename, sysfs_path);
+	strcat(filename, path);
+	strcat(filename, "/dev");
+
+	while (loop < SECONDS_TO_WAIT_FOR_DEV) {
+		dbg("looking for %s", filename);
+		retval = stat(filename, &buf);
+		if (retval == 0) {
+			retval = 0;
+			goto exit;
+		}
+
+		/* sleep for a second or two to give the kernel a chance to
+		 * create the dev file */
+		sleep(1);
+		++loop;
+	}
+	retval = -ENODEV;
+exit:
+	return retval;
+}
+
+int udev_add_device(char *path, char *subsystem)
 {
 	struct sysfs_class_device *class_dev;
+	struct udevice dev;
 	struct device_attr attr;
-	int major;
-	int minor;
-	char type;
 	int retval = -EINVAL;
 
 	/* for now, the block layer is the only place where block devices are */
 	if (strcmp(subsystem, "block") == 0)
-		type = 'b';
+		dev.type = 'b';
 	else
-		type = 'c';
+		dev.type = 'c';
 
-	/* sleep for a second or two to give the kernel a chance to
-	 * create the dev file
-	 */
-	sleep(1);
+	retval = sleep_for_dev(path);
+	if (retval)
+		goto exit;
 
-	class_dev = get_class_dev(device);
+	class_dev = get_class_dev(path);
 	if (class_dev == NULL)
 		goto exit;
 
@@ -161,21 +182,26 @@ int udev_add_device(char *device, char *subsystem)
 	if (retval)
 		return retval;
 
-	retval = get_major_minor(class_dev, &major, &minor);
+	retval = get_major_minor(class_dev, &dev.major, &dev.minor);
 	if (retval) {
 		dbg("get_major_minor failed");
 		goto exit;
 	}
 
-	retval = udevdb_add_device(device, class_dev, attr.name, type, major, minor, attr.mode);
-
+	strcpy(dev.name, attr.name);
+	strcpy(dev.owner, attr.owner);
+	strcpy(dev.group, attr.group);
+	dev.mode = attr.mode;
+	
+	retval = udevdb_add_dev(path, &dev);
 	if (retval != 0)
-		dbg("udevdb_add_device failed, but we are going to try to create the node anyway. "
+		dbg("udevdb_add_dev failed, but we are going to try to create the node anyway. "
 		    "But remove might not work properly for this device.");
 
 	sysfs_close_class_device(class_dev);
 
-	return create_node(attr.name, type, major, minor, attr.mode);
+	dbg("name = %s", dev.name);
+	retval = create_node(&dev);
 
 exit:
 	return retval;