X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=udev%2Fudev-watch.c;h=f51a10dcabdd410589f3cdcdf1fd4386044d6214;hb=2514465f6a4ab61617482f068e475b945438c1f1;hp=d67083b51b3a67e3d14f9d2a7b6b4ef5113646a2;hpb=26347a4c5538008318188118872490128f43fcd3;p=elogind.git diff --git a/udev/udev-watch.c b/udev/udev-watch.c index d67083b51..f51a10dca 100644 --- a/udev/udev-watch.c +++ b/udev/udev-watch.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 2004-2008 Kay Sievers + * Copyright (C) 2004-2010 Kay Sievers * Copyright (C) 2009 Canonical Ltd. * Copyright (C) 2009 Scott James Remnant * @@ -73,28 +73,24 @@ void udev_watch_restore(struct udev *udev) ssize_t len; struct udev_device *dev; - if (ent->d_name[0] < '0' || ent->d_name[0] > '9') + if (ent->d_name[0] == '.') continue; s = device; l = util_strpcpy(&s, sizeof(device), udev_get_sys_path(udev)); len = readlinkat(dirfd(dir), ent->d_name, s, l); - if (len <= 0 || len >= (ssize_t)l) { - unlinkat(dirfd(dir), ent->d_name, 0); - continue; - } + if (len <= 0 || len == (ssize_t)l) + goto unlink; s[len] = '\0'; - dbg(udev, "old watch to '%s' found\n", device); - dev = udev_device_new_from_syspath(udev, device); - if (dev == NULL) { - unlinkat(dirfd(dir), ent->d_name, 0); - continue; - } + + dev = udev_device_new_from_id_filename(udev, s); + if (dev == NULL) + goto unlink; info(udev, "restoring old watch on '%s'\n", udev_device_get_devnode(dev)); udev_watch_begin(udev, dev); - udev_device_unref(dev); +unlink: unlinkat(dirfd(dir), ent->d_name, 0); } @@ -125,7 +121,7 @@ void udev_watch_begin(struct udev *udev, struct udev_device *dev) snprintf(filename, sizeof(filename), "%s/.udev/watch/%d", udev_get_dev_path(udev), wd); util_create_path(udev, filename); unlink(filename); - symlink(udev_device_get_devpath(dev), filename); + symlink(udev_device_get_id_filename(dev), filename); udev_device_set_watch_handle(dev, wd); } @@ -154,7 +150,7 @@ void udev_watch_end(struct udev *udev, struct udev_device *dev) struct udev_device *udev_watch_lookup(struct udev *udev, int wd) { char filename[UTIL_PATH_SIZE]; - char syspath[UTIL_PATH_SIZE]; + char majmin[UTIL_PATH_SIZE]; char *s; size_t l; ssize_t len; @@ -163,11 +159,12 @@ struct udev_device *udev_watch_lookup(struct udev *udev, int wd) return NULL; snprintf(filename, sizeof(filename), "%s/.udev/watch/%d", udev_get_dev_path(udev), wd); - s = syspath; - l = util_strpcpy(&s, sizeof(syspath), udev_get_sys_path(udev)); + s = majmin; + l = util_strpcpy(&s, sizeof(majmin), udev_get_sys_path(udev)); len = readlink(filename, s, l); - if (len < 0 || (size_t)len >= l) + if (len <= 0 || (size_t)len == l) return NULL; s[len] = '\0'; - return udev_device_new_from_syspath(udev, syspath); + + return udev_device_new_from_id_filename(udev, s); }