X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fupdate-utmp%2Fupdate-utmp.c;h=7162084062fe95f9861322266291b5517ad6406e;hb=cdc7b27bf58e294db71812932cd5f6f4a8dccc8b;hp=61db1e96d34a47b3fd77cd4d580277775c211ef9;hpb=0f8bd8debb0ff7f5bff7738841931f6c41e40bc1;p=elogind.git
diff --git a/src/update-utmp/update-utmp.c b/src/update-utmp/update-utmp.c
index 61db1e96d..716208406 100644
--- a/src/update-utmp/update-utmp.c
+++ b/src/update-utmp/update-utmp.c
@@ -1,5 +1,3 @@
-/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/
-
/***
This file is part of systemd.
@@ -19,10 +17,8 @@
along with systemd; If not, see .
***/
-#include
#include
#include
-#include
#include
#ifdef HAVE_AUDIT
@@ -31,13 +27,22 @@
#include "sd-bus.h"
-#include "log.h"
-#include "macro.h"
-#include "util.h"
-#include "special.h"
-#include "utmp-wtmp.h"
-#include "bus-util.h"
+//#include "alloc-util.h"
#include "bus-error.h"
+//#include "bus-util.h"
+//#include "formats-util.h"
+//#include "log.h"
+//#include "macro.h"
+//#include "special.h"
+//#include "unit-name.h"
+//#include "util.h"
+#include "utmp-wtmp.h"
+
+/// includes needed by elogind:
+#include "string-util.h"
+#include "time-util.h"
+#include "update-utmp.h"
+
typedef struct Context {
sd_bus *bus;
@@ -47,37 +52,29 @@ typedef struct Context {
} Context;
static usec_t get_startup_time(Context *c) {
+ _cleanup_(sd_bus_error_free) sd_bus_error error = SD_BUS_ERROR_NULL;
usec_t t = 0;
- _cleanup_bus_message_unref_ sd_bus_message *reply = NULL;
- _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL;
int r;
assert(c);
- r = sd_bus_call_method(
+ r = sd_bus_get_property_trivial(
c->bus,
"org.freedesktop.systemd1",
"/org/freedesktop/systemd1",
- "org.freedesktop.DBus.Properties",
- "Get",
- &error,
- &reply,
- "ss",
"org.freedesktop.systemd1.Manager",
- "UserspaceTimestamp");
- if (r < 0) {
- log_error("Failed to get timestamp: %s", bus_error_message(&error, -r));
- return t;
- }
-
- r = sd_bus_message_read(reply, "v", "t", &t);
+ "UserspaceTimestamp",
+ &error,
+ 't', &t);
if (r < 0) {
- log_error("Failed to parse reply: %s", strerror(-r));
+ log_error_errno(r, "Failed to get timestamp: %s", bus_error_message(&error, r));
+ return 0;
}
return t;
}
+#if 0 /// UNNEEDED by elogind
static int get_current_runlevel(Context *c) {
static const struct {
const int runlevel;
@@ -88,65 +85,34 @@ static int get_current_runlevel(Context *c) {
* here over the others, since these are the main
* runlevels used on Fedora. It might make sense to
* change the order on some distributions. */
- { '5', SPECIAL_RUNLEVEL5_TARGET },
- { '3', SPECIAL_RUNLEVEL3_TARGET },
- { '4', SPECIAL_RUNLEVEL4_TARGET },
- { '2', SPECIAL_RUNLEVEL2_TARGET },
- { '1', SPECIAL_RESCUE_TARGET },
+ { '5', SPECIAL_GRAPHICAL_TARGET },
+ { '3', SPECIAL_MULTI_USER_TARGET },
+ { '1', SPECIAL_RESCUE_TARGET },
};
- _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL;
+ _cleanup_(sd_bus_error_free) sd_bus_error error = SD_BUS_ERROR_NULL;
int r;
unsigned i;
assert(c);
for (i = 0; i < ELEMENTSOF(table); i++) {
- _cleanup_bus_message_unref_ sd_bus_message *reply1 = NULL, *reply2 = NULL;
- const char *path = NULL, *state;
+ _cleanup_free_ char *state = NULL, *path = NULL;
- r = sd_bus_call_method(
- c->bus,
- "org.freedesktop.systemd1",
- "/org/freedesktop/systemd1",
- "org.freedesktop.systemd1.Manager",
- "LoadUnit",
- &error,
- &reply1,
- "s", table[i].special);
- if (r < 0) {
- log_error("Failed to get runlevel: %s", bus_error_message(&error, -r));
- if (r == -ENOMEM)
- return r;
- else
- continue;
- }
-
- r = sd_bus_message_read(reply1, "o", &path);
- if (r < 0) {
- log_error("Failed to parse reply: %s", strerror(-r));
- return -EIO;
- }
+ path = unit_dbus_path_from_name(table[i].special);
+ if (!path)
+ return log_oom();
- r = sd_bus_call_method(
+ r = sd_bus_get_property_string(
c->bus,
"org.freedesktop.systemd1",
path,
- "org.freedesktop.DBus.Properties",
- "Get",
+ "org.freedesktop.systemd1.Unit",
+ "ActiveState",
&error,
- &reply2,
- "ss", "org.freedesktop.systemd1.Unit", "ActiveState");
- if (r < 0) {
- log_error("Failed to get state: %s", bus_error_message(&error, -r));
- return r;
- }
-
- r = sd_bus_message_read(reply2, "v", "s", &state);
- if (r < 0) {
- log_error("Failed to parse reply: %s", strerror(-r));
- return -EIO;
- }
+ &state);
+ if (r < 0)
+ return log_warning_errno(r, "Failed to get state: %s", bus_error_message(&error, r));
if (streq(state, "active") || streq(state, "reloading"))
return table[i].runlevel;
@@ -154,6 +120,7 @@ static int get_current_runlevel(Context *c) {
return 0;
}
+#endif // 0
static int on_reboot(Context *c) {
int r = 0, q;
@@ -166,10 +133,9 @@ static int on_reboot(Context *c) {
#ifdef HAVE_AUDIT
if (c->audit_fd >= 0)
- if (audit_log_user_message(c->audit_fd, AUDIT_SYSTEM_BOOT, "init", NULL, NULL, NULL, 1) < 0 &&
+ if (audit_log_user_comm_message(c->audit_fd, AUDIT_SYSTEM_BOOT, "", "systemd-update-utmp", NULL, NULL, NULL, 1) < 0 &&
errno != EPERM) {
- log_error("Failed to send audit message: %m");
- r = -errno;
+ r = log_error_errno(errno, "Failed to send audit message: %m");
}
#endif
@@ -177,8 +143,9 @@ static int on_reboot(Context *c) {
* utmp_put_reboot() will then fix to the current time */
t = get_startup_time(c);
- if ((q = utmp_put_reboot(t)) < 0) {
- log_error("Failed to write utmp record: %s", strerror(-q));
+ q = utmp_put_reboot(t);
+ if (q < 0) {
+ log_error_errno(q, "Failed to write utmp record: %m");
r = q;
}
@@ -195,21 +162,22 @@ static int on_shutdown(Context *c) {
#ifdef HAVE_AUDIT
if (c->audit_fd >= 0)
- if (audit_log_user_message(c->audit_fd, AUDIT_SYSTEM_SHUTDOWN, "init", NULL, NULL, NULL, 1) < 0 &&
+ if (audit_log_user_comm_message(c->audit_fd, AUDIT_SYSTEM_SHUTDOWN, "", "systemd-update-utmp", NULL, NULL, NULL, 1) < 0 &&
errno != EPERM) {
- log_error("Failed to send audit message: %m");
- r = -errno;
+ r = log_error_errno(errno, "Failed to send audit message: %m");
}
#endif
- if ((q = utmp_put_shutdown()) < 0) {
- log_error("Failed to write utmp record: %s", strerror(-q));
+ q = utmp_put_shutdown();
+ if (q < 0) {
+ log_error_errno(q, "Failed to write utmp record: %m");
r = q;
}
return r;
}
+#if 0 /// UNNEEDED by elogind
static int on_runlevel(Context *c) {
int r = 0, q, previous, runlevel;
@@ -219,21 +187,19 @@ static int on_runlevel(Context *c) {
* utmp record and send the audit msg */
/* First, get last runlevel */
- if ((q = utmp_get_runlevel(&previous, NULL)) < 0) {
+ q = utmp_get_runlevel(&previous, NULL);
- if (q != -ESRCH && q != -ENOENT) {
- log_error("Failed to get current runlevel: %s", strerror(-q));
- return q;
- }
+ if (q < 0) {
+ if (q != -ESRCH && q != -ENOENT)
+ return log_error_errno(q, "Failed to get current runlevel: %m");
- /* Hmm, we didn't find any runlevel, that means we
- * have been rebooted */
- r = on_reboot(c);
previous = 0;
}
/* Secondly, get new runlevel */
- if ((runlevel = get_current_runlevel(c)) < 0)
+ runlevel = get_current_runlevel(c);
+
+ if (runlevel < 0)
return runlevel;
if (previous == runlevel)
@@ -241,40 +207,40 @@ static int on_runlevel(Context *c) {
#ifdef HAVE_AUDIT
if (c->audit_fd >= 0) {
- char *s = NULL;
+ _cleanup_free_ char *s = NULL;
if (asprintf(&s, "old-level=%c new-level=%c",
previous > 0 ? previous : 'N',
runlevel > 0 ? runlevel : 'N') < 0)
- return -ENOMEM;
+ return log_oom();
- if (audit_log_user_message(c->audit_fd, AUDIT_SYSTEM_RUNLEVEL, s, NULL, NULL, NULL, 1) < 0 &&
- errno != EPERM) {
- log_error("Failed to send audit message: %m");
- r = -errno;
- }
-
- free(s);
+ if (audit_log_user_comm_message(c->audit_fd, AUDIT_SYSTEM_RUNLEVEL, s, "systemd-update-utmp", NULL, NULL, NULL, 1) < 0 && errno != EPERM)
+ r = log_error_errno(errno, "Failed to send audit message: %m");
}
#endif
- if ((q = utmp_put_runlevel(runlevel, previous)) < 0) {
- if (q != -ESRCH && q != -ENOENT) {
- log_error("Failed to write utmp record: %s", strerror(-q));
- r = q;
- }
+ q = utmp_put_runlevel(runlevel, previous);
+ if (q < 0 && q != -ESRCH && q != -ENOENT) {
+ log_error_errno(q, "Failed to write utmp record: %m");
+ r = q;
}
return r;
}
+#endif // 0
+#if 0 /// elogind needs this to be a callable function
int main(int argc, char *argv[]) {
- int r;
- Context c = {};
-
+#else
+void update_utmp(int argc, char* argv[], sd_bus *bus) {
+#endif // 0
+ Context c = {
#ifdef HAVE_AUDIT
- c.audit_fd = -1;
+ .audit_fd = -1
#endif
+ };
+#if 0 /// UNNEEDED by elogind
+ int r;
if (getppid() != 1) {
log_error("This program should be invoked by init only.");
@@ -291,22 +257,29 @@ int main(int argc, char *argv[]) {
log_open();
umask(0022);
+#else
+ assert(2 == argc);
+ assert(argv[1]);
+ assert(bus);
+#endif // 0
#ifdef HAVE_AUDIT
- if ((c.audit_fd = audit_open()) < 0 &&
- /* If the kernel lacks netlink or audit support,
- * don't worry about it. */
- errno != EAFNOSUPPORT && errno != EPROTONOSUPPORT)
- log_error("Failed to connect to audit log: %m");
+ /* If the kernel lacks netlink or audit support,
+ * don't worry about it. */
+ c.audit_fd = audit_open();
+ if (c.audit_fd < 0 && errno != EAFNOSUPPORT && errno != EPROTONOSUPPORT)
+ log_error_errno(errno, "Failed to connect to audit log: %m");
#endif
- r = bus_open_system_systemd(&c.bus);
+
+#if 0 /// UNNEEDED by elogind
+ r = bus_connect_system_systemd(&c.bus);
if (r < 0) {
- log_error("Failed to get D-Bus connection: %s", strerror(-r));
+ log_error_errno(r, "Failed to get D-Bus connection: %m");
r = -EIO;
goto finish;
}
- log_debug("systemd-update-utmp running as pid %lu", (unsigned long) getpid());
+ log_debug("systemd-update-utmp running as pid "PID_FMT, getpid());
if (streq(argv[1], "reboot"))
r = on_reboot(&c);
@@ -319,16 +292,25 @@ int main(int argc, char *argv[]) {
r = -EINVAL;
}
- log_debug("systemd-update-utmp stopped as pid %lu", (unsigned long) getpid());
+ log_debug("systemd-update-utmp stopped as pid "PID_FMT, getpid());
finish:
+#else
+ c.bus = bus;
+ if (streq(argv[1], "reboot"))
+ (void)on_reboot(&c);
+ else if (streq(argv[1], "shutdown"))
+ (void)on_shutdown(&c);
+#endif // 0
+
#ifdef HAVE_AUDIT
if (c.audit_fd >= 0)
audit_close(c.audit_fd);
#endif
- if (c.bus)
- sd_bus_unref(c.bus);
+ sd_bus_flush_close_unref(c.bus);
+#if 0 /// UNNEEDED by elogind
return r < 0 ? EXIT_FAILURE : EXIT_SUCCESS;
+#endif // 0
}