X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fudev%2Fnet%2Fethtool-util.c;fp=src%2Fudev%2Fnet%2Fethtool-util.c;h=ec67126b21b1995ce01bddb453260afe9b076a30;hb=f647962d64e844689f3e2acfce6102fc47e76df2;hp=4608a6c982beadb51fc8cc8b3cfca071830e4220;hpb=e80733be33e52d8ab2f1ae845326d39c600f5612;p=elogind.git

diff --git a/src/udev/net/ethtool-util.c b/src/udev/net/ethtool-util.c
index 4608a6c98..ec67126b2 100644
--- a/src/udev/net/ethtool-util.c
+++ b/src/udev/net/ethtool-util.c
@@ -75,10 +75,8 @@ int ethtool_get_driver(int *fd, const char *ifname, char **ret) {
 
         if (*fd < 0) {
                 r = ethtool_connect(fd);
-                if (r < 0) {
-                        log_warning_errno(r, "link_config: could not connect to ethtool: %m");
-                        return r;
-                }
+                if (r < 0)
+                        return log_warning_errno(r, "link_config: could not connect to ethtool: %m");
         }
 
         strscpy(ifr.ifr_name, IFNAMSIZ, ifname);
@@ -111,10 +109,8 @@ int ethtool_set_speed(int *fd, const char *ifname, unsigned int speed, Duplex du
 
         if (*fd < 0) {
                 r = ethtool_connect(fd);
-                if (r < 0) {
-                        log_warning_errno(r, "link_config: could not connect to ethtool: %m");
-                        return r;
-                }
+                if (r < 0)
+                        return log_warning_errno(r, "link_config: could not connect to ethtool: %m");
         }
 
         strscpy(ifr.ifr_name, IFNAMSIZ, ifname);
@@ -171,10 +167,8 @@ int ethtool_set_wol(int *fd, const char *ifname, WakeOnLan wol) {
 
         if (*fd < 0) {
                 r = ethtool_connect(fd);
-                if (r < 0) {
-                        log_warning_errno(r, "link_config: could not connect to ethtool: %m");
-                        return r;
-                }
+                if (r < 0)
+                        return log_warning_errno(r, "link_config: could not connect to ethtool: %m");
         }
 
         strscpy(ifr.ifr_name, IFNAMSIZ, ifname);