X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fsystemctl.c;h=390cec9f9a792715a954951a1412be9bc4936cab;hb=16c42ce173e8c1e64b6d9275719a405c891b0d22;hp=9eb72f9747c492462f97fdb35866f0f7f00ab510;hpb=5ec7ed4ec693cd69bdc329c38b220d2462df5eba;p=elogind.git diff --git a/src/systemctl.c b/src/systemctl.c index 9eb72f974..390cec9f9 100644 --- a/src/systemctl.c +++ b/src/systemctl.c @@ -46,12 +46,13 @@ static const char *arg_type = NULL; static bool arg_all = false; static bool arg_replace = false; static bool arg_session = false; -static bool arg_block = false; +static bool arg_no_block = false; static bool arg_immediate = false; static bool arg_no_wtmp = false; static bool arg_no_sync = false; static bool arg_no_wall = false; static bool arg_dry = false; +static bool arg_quiet = false; static char **arg_wall = NULL; enum action { ACTION_INVALID, @@ -529,13 +530,18 @@ finish: return r; } +typedef struct WaitData { + Set *set; + bool failed; +} WaitData; + static DBusHandlerResult wait_filter(DBusConnection *connection, DBusMessage *message, void *data) { DBusError error; - Set *s = data; + WaitData *d = data; assert(connection); assert(message); - assert(s); + assert(d); dbus_error_init(&error); @@ -551,17 +557,22 @@ static DBusHandlerResult wait_filter(DBusConnection *connection, DBusMessage *me } else if (dbus_message_is_signal(message, "org.freedesktop.systemd1.Manager", "JobRemoved")) { uint32_t id; const char *path; + dbus_bool_t success = true; if (!dbus_message_get_args(message, &error, DBUS_TYPE_UINT32, &id, DBUS_TYPE_OBJECT_PATH, &path, + DBUS_TYPE_BOOLEAN, &success, DBUS_TYPE_INVALID)) log_error("Failed to parse message: %s", error.message); else { char *p; - if ((p = set_remove(s, (char*) path))) + if ((p = set_remove(d->set, (char*) path))) free(p); + + if (!success) + d->failed = true; } } @@ -626,11 +637,16 @@ finish: static int wait_for_jobs(DBusConnection *bus, Set *s) { int r; + WaitData d; assert(bus); assert(s); - if (!dbus_connection_add_filter(bus, wait_filter, s, NULL)) { + zero(d); + d.set = s; + d.failed = false; + + if (!dbus_connection_add_filter(bus, wait_filter, &d, NULL)) { log_error("Failed to add filter."); r = -ENOMEM; goto finish; @@ -640,7 +656,10 @@ static int wait_for_jobs(DBusConnection *bus, Set *s) { dbus_connection_read_write_dispatch(bus, -1)) ; - r = 0; + if (!arg_quiet && d.failed) + log_error("Job failed, see logs for details."); + + r = d.failed ? -EIO : 0; finish: /* This is slightly dirty, since we don't undo the filter registration. */ @@ -663,7 +682,7 @@ static int start_unit_one( assert(method); assert(name); assert(mode); - assert(!arg_block || s); + assert(arg_no_block || s); dbus_error_init(&error); @@ -700,7 +719,7 @@ static int start_unit_one( goto finish; } - if (arg_block) { + if (!arg_no_block) { const char *path; char *p; @@ -806,7 +825,7 @@ static int start_unit(DBusConnection *bus, char **args, unsigned n) { one_name = table[arg_action]; } - if (arg_block) { + if (!arg_no_block) { if ((r = enable_wait_for_jobs(bus)) < 0) { log_error("Could not watch jobs: %s", strerror(-r)); goto finish; @@ -830,7 +849,7 @@ static int start_unit(DBusConnection *bus, char **args, unsigned n) { goto finish; } - if (arg_block) + if (!arg_no_block) r = wait_for_jobs(bus, s); finish: @@ -849,6 +868,128 @@ static int start_special(DBusConnection *bus, char **args, unsigned n) { return start_unit(bus, args, n); } +static int check_unit(DBusConnection *bus, char **args, unsigned n) { + DBusMessage *m = NULL, *reply = NULL; + const char + *interface = "org.freedesktop.systemd1.Unit", + *property = "ActiveState"; + int r = -EADDRNOTAVAIL; + DBusError error; + unsigned i; + + assert(bus); + assert(args); + + dbus_error_init(&error); + + for (i = 1; i < n; i++) { + const char *path = NULL; + const char *state; + DBusMessageIter iter, sub; + + if (!(m = dbus_message_new_method_call( + "org.freedesktop.systemd1", + "/org/freedesktop/systemd1", + "org.freedesktop.systemd1.Manager", + "GetUnit"))) { + log_error("Could not allocate message."); + r = -ENOMEM; + goto finish; + } + + if (!dbus_message_append_args(m, + DBUS_TYPE_STRING, &args[i], + DBUS_TYPE_INVALID)) { + log_error("Could not append arguments to message."); + r = -ENOMEM; + goto finish; + } + + if (!(reply = dbus_connection_send_with_reply_and_block(bus, m, -1, &error))) { + + /* Hmm, cannot figure out anything about this unit... */ + if (!arg_quiet) + puts("unknown"); + + continue; + } + + if (!dbus_message_get_args(reply, &error, + DBUS_TYPE_OBJECT_PATH, &path, + DBUS_TYPE_INVALID)) { + log_error("Failed to parse reply: %s", error.message); + r = -EIO; + goto finish; + } + + dbus_message_unref(m); + if (!(m = dbus_message_new_method_call( + "org.freedesktop.systemd1", + path, + "org.freedesktop.DBus.Properties", + "Get"))) { + log_error("Could not allocate message."); + r = -ENOMEM; + goto finish; + } + + if (!dbus_message_append_args(m, + DBUS_TYPE_STRING, &interface, + DBUS_TYPE_STRING, &property, + DBUS_TYPE_INVALID)) { + log_error("Could not append arguments to message."); + r = -ENOMEM; + goto finish; + } + + dbus_message_unref(reply); + if (!(reply = dbus_connection_send_with_reply_and_block(bus, m, -1, &error))) { + log_error("Failed to issue method call: %s", error.message); + r = -EIO; + goto finish; + } + + if (!dbus_message_iter_init(reply, &iter) || + dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_VARIANT) { + log_error("Failed to parse reply."); + r = -EIO; + goto finish; + } + + dbus_message_iter_recurse(&iter, &sub); + + if (dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_STRING) { + log_error("Failed to parse reply."); + r = -EIO; + goto finish; + } + + dbus_message_iter_get_basic(&sub, &state); + + if (!arg_quiet) + puts(state); + + if (streq(state, "active") || startswith(state, "reloading")) + r = 0; + + dbus_message_unref(m); + dbus_message_unref(reply); + m = reply = NULL; + } + +finish: + if (m) + dbus_message_unref(m); + + if (reply) + dbus_message_unref(reply); + + dbus_error_free(&error); + + return r; + +} + static DBusHandlerResult monitor_filter(DBusConnection *connection, DBusMessage *message, void *data) { DBusError error; DBusMessage *m = NULL, *reply = NULL; @@ -1205,7 +1346,9 @@ static int snapshot(DBusConnection *bus, char **args, unsigned n) { } dbus_message_iter_get_basic(&sub, &id); - puts(id); + + if (!arg_quiet) + puts(id); r = 0; finish: @@ -1436,7 +1579,8 @@ static int systemctl_help(void) { " --replace When installing a new job, replace existing conflicting ones\n" " --system Connect to system bus\n" " --session Connect to session bus\n" - " --block Wait until operation finished\n" + " -q --quiet Suppress output\n" + " --no-block Do not wait until operation finished\n" " --no-wall Don't send wall message before halt/power-off/reboot\n\n" "Commands:\n" " list-units List units\n" @@ -1449,6 +1593,7 @@ static int systemctl_help(void) { " restart [NAME...] Restart one or more units\n" " reload [NAME...] Reload one or more units\n" " isolate [NAME] Start one unit and stop all others\n" + " check [NAME...] Check whether any of the passed units are active\n" " monitor Monitor unit/job changes\n" " dump Dump server status\n" " snapshot [NAME] Create a snapshot\n" @@ -1540,20 +1685,21 @@ static int systemctl_parse_argv(int argc, char *argv[]) { ARG_REPLACE = 0x100, ARG_SESSION, ARG_SYSTEM, - ARG_BLOCK, + ARG_NO_BLOCK, ARG_NO_WALL }; static const struct option options[] = { - { "help", no_argument, NULL, 'h' }, - { "type", required_argument, NULL, 't' }, - { "all", no_argument, NULL, 'a' }, - { "replace", no_argument, NULL, ARG_REPLACE }, - { "session", no_argument, NULL, ARG_SESSION }, - { "system", no_argument, NULL, ARG_SYSTEM }, - { "block", no_argument, NULL, ARG_BLOCK }, - { "no-wall", no_argument, NULL, ARG_NO_WALL }, - { NULL, 0, NULL, 0 } + { "help", no_argument, NULL, 'h' }, + { "type", required_argument, NULL, 't' }, + { "all", no_argument, NULL, 'a' }, + { "replace", no_argument, NULL, ARG_REPLACE }, + { "session", no_argument, NULL, ARG_SESSION }, + { "system", no_argument, NULL, ARG_SYSTEM }, + { "no-block", no_argument, NULL, ARG_NO_BLOCK }, + { "no-wall", no_argument, NULL, ARG_NO_WALL }, + { "quiet", no_argument, NULL, 'q' }, + { NULL, 0, NULL, 0 } }; int c; @@ -1561,7 +1707,7 @@ static int systemctl_parse_argv(int argc, char *argv[]) { assert(argc >= 0); assert(argv); - while ((c = getopt_long(argc, argv, "hta", options, NULL)) >= 0) { + while ((c = getopt_long(argc, argv, "htaq", options, NULL)) >= 0) { switch (c) { @@ -1589,14 +1735,18 @@ static int systemctl_parse_argv(int argc, char *argv[]) { arg_session = false; break; - case ARG_BLOCK: - arg_block = true; + case ARG_NO_BLOCK: + arg_no_block = true; break; case ARG_NO_WALL: arg_no_wall = true; break; + case 'q': + arg_quiet = true; + break; + case '?': return -EINVAL; @@ -1839,7 +1989,7 @@ static int telinit_parse_argv(int argc, char *argv[]) { } if (optind >= argc) { - log_error("Argument missing."); + telinit_help(); return -EINVAL; } @@ -2108,6 +2258,7 @@ static int systemctl_main(DBusConnection *bus, int argc, char *argv[]) { { "reload", MORE, 2, start_unit }, { "restart", MORE, 2, start_unit }, { "isolate", EQUAL, 2, start_unit }, + { "check", MORE, 2, check_unit }, { "monitor", EQUAL, 1, monitor }, { "dump", EQUAL, 1, dump }, { "snapshot", LESS, 2, snapshot }, @@ -2138,6 +2289,11 @@ static int systemctl_main(DBusConnection *bus, int argc, char *argv[]) { /* Special rule: no arguments means "list-units" */ i = 0; else { + if (streq(argv[optind], "help")) { + systemctl_help(); + return 0; + } + for (i = 0; i < ELEMENTSOF(verbs); i++) if (streq(argv[optind], verbs[i].verb)) break;