X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fpath.c;h=a9fa3771ab0454786a9a1b3326de1f4ba3d8b548;hb=d06428248aa80f72862b86297335ee01c31d918b;hp=56936fd673fd76d427c18eb8fdce7f2105279be5;hpb=2c966c038dc32ef39baa176371395cde4e541d01;p=elogind.git diff --git a/src/path.c b/src/path.c index 56936fd67..a9fa3771a 100644 --- a/src/path.c +++ b/src/path.c @@ -29,6 +29,8 @@ #include "unit-name.h" #include "path.h" #include "dbus-path.h" +#include "special.h" +#include "bus-errors.h" static const UnitActiveState state_translation_table[_PATH_STATE_MAX] = { [PATH_DEAD] = UNIT_INACTIVE, @@ -99,6 +101,18 @@ static int path_verify(Path *p) { return 0; } +static int path_add_default_dependencies(Path *p) { + int r; + + assert(p); + + if (p->meta.manager->running_as == MANAGER_SYSTEM) + if ((r = unit_add_two_dependencies_by_name(UNIT(p), UNIT_AFTER, UNIT_REQUIRES, SPECIAL_SYSINIT_TARGET, NULL, true)) < 0) + return r; + + return unit_add_two_dependencies_by_name(UNIT(p), UNIT_BEFORE, UNIT_CONFLICTS, SPECIAL_SHUTDOWN_TARGET, NULL, true); +} + static int path_load(Unit *u) { Path *p = PATH(u); int r; @@ -120,6 +134,10 @@ static int path_load(Unit *u) { if ((r = path_add_mount_links(p)) < 0) return r; + + if (p->meta.default_dependencies) + if ((r = path_add_default_dependencies(p)) < 0) + return r; } return path_verify(p); @@ -292,17 +310,26 @@ static void path_enter_dead(Path *p, bool success) { static void path_enter_running(Path *p) { int r; + DBusError error; + assert(p); + dbus_error_init(&error); - if ((r = manager_add_job(p->meta.manager, JOB_START, p->unit, JOB_REPLACE, true, NULL)) < 0) + /* Don't start job if we are supposed to go down */ + if (p->meta.job && p->meta.job->type == JOB_STOP) + return; + + if ((r = manager_add_job(p->meta.manager, JOB_START, p->unit, JOB_REPLACE, true, &error, NULL)) < 0) goto fail; path_set_state(p, PATH_RUNNING); return; fail: - log_warning("%s failed to queue unit startup job: %s", p->meta.id, strerror(-r)); + log_warning("%s failed to queue unit startup job: %s", p->meta.id, bus_error(&error, r)); path_enter_dead(p, false); + + dbus_error_free(&error); }