X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fnspawn%2Fnspawn.c;h=efeba596658079606376811963586f61da49df3a;hb=f6c51a8136de3f27e28caea2003e18f4bc4cb9a8;hp=2783c97f2065d46a163629ca68c8cf3aa3baac3a;hpb=5e4074aa3188ff439c0509908284469807d2749e;p=elogind.git diff --git a/src/nspawn/nspawn.c b/src/nspawn/nspawn.c index 2783c97f2..efeba5966 100644 --- a/src/nspawn/nspawn.c +++ b/src/nspawn/nspawn.c @@ -43,6 +43,8 @@ #include #include #include +#include +#include #ifdef HAVE_SELINUX #include @@ -1029,7 +1031,7 @@ static int mount_cgroup(const char *dest) { return r; if (symlink(combined, target) < 0) - return log_error_errno(errno, "Failed to create symlink for combined hiearchy: %m"); + return log_error_errno(errno, "Failed to create symlink for combined hierarchy: %m"); } } @@ -2557,9 +2559,67 @@ static int setup_image(char **device_path, int *loop_nr) { return r; } +static int wait_for_block_device(struct udev *udev, dev_t devnum, struct udev_device **ret) { + _cleanup_udev_monitor_unref_ struct udev_monitor *monitor = NULL; + int r; + + assert(udev); + assert(ret); + + for (;;) { + _cleanup_udev_device_unref_ struct udev_device *d = NULL; + struct pollfd pfd = { + .events = POLLIN + }; + + d = udev_device_new_from_devnum(udev, 'b', devnum); + if (!d) + return log_oom(); + + r = udev_device_get_is_initialized(d); + if (r < 0) + return log_error_errno(r, "Failed to check if device is initialized: %m"); + if (r > 0) { + *ret = d; + d = NULL; + return 0; + } + d = udev_device_unref(d); + + if (!monitor) { + monitor = udev_monitor_new_from_netlink(udev, "udev"); + if (!monitor) + return log_oom(); + + r = udev_monitor_filter_add_match_subsystem_devtype(monitor, "block", NULL); + if (r < 0) + return log_error_errno(r, "Failed to add block match: %m"); + + r = udev_monitor_enable_receiving(monitor); + if (r < 0) + return log_error_errno(r, "Failed to turn on monitor: %m"); + + continue; + } + + pfd.fd = udev_monitor_get_fd(monitor); + if (pfd.fd < 0) + return log_error_errno(r, "Failed to get udev monitor fd: %m"); + + r = poll(&pfd, 1, -1); + if (r < 0) + return log_error_errno(errno, "Failed to wait for device initialization: %m"); + + d = udev_monitor_receive_device(monitor); + } + + return 0; +} + #define PARTITION_TABLE_BLURB \ "Note that the disk image needs to either contain only a single MBR partition of\n" \ - "type 0x83 that is marked bootable, or follow\n" \ + "type 0x83 that is marked bootable, or a sinlge GPT partition of type" \ + "0FC63DAF-8483-4772-8E79-3D69D8477DE4 or follow\n" \ " http://www.freedesktop.org/wiki/Specifications/DiscoverablePartitionsSpec/\n" \ "to be bootable with systemd-nspawn." @@ -2578,19 +2638,18 @@ static int dissect_image( #ifdef GPT_ROOT_SECONDARY int secondary_root_nr = -1; #endif - - _cleanup_free_ char *home = NULL, *root = NULL, *secondary_root = NULL, *srv = NULL; + _cleanup_free_ char *home = NULL, *root = NULL, *secondary_root = NULL, *srv = NULL, *generic = NULL; _cleanup_udev_enumerate_unref_ struct udev_enumerate *e = NULL; _cleanup_udev_device_unref_ struct udev_device *d = NULL; _cleanup_blkid_free_probe_ blkid_probe b = NULL; _cleanup_udev_unref_ struct udev *udev = NULL; struct udev_list_entry *first, *item; - bool home_rw = true, root_rw = true, secondary_root_rw = true, srv_rw = true; + bool home_rw = true, root_rw = true, secondary_root_rw = true, srv_rw = true, generic_rw = true; const char *pttype = NULL; blkid_partlist pl; struct stat st; int r; - bool is_gpt, is_mbr; + bool is_gpt, is_mbr, multiple_generic = false; assert(fd >= 0); assert(root_device); @@ -2659,9 +2718,9 @@ static int dissect_image( if (fstat(fd, &st) < 0) return log_error_errno(errno, "Failed to stat block device: %m"); - d = udev_device_new_from_devnum(udev, 'b', st.st_rdev); - if (!d) - return log_oom(); + r = wait_for_block_device(udev, st.st_rdev, &d); + if (r < 0) + return r; e = udev_enumerate_new(udev); if (!e) @@ -2710,10 +2769,6 @@ static int dissect_image( continue; flags = blkid_partition_get_flags(pp); - if (is_gpt && (flags & GPT_FLAG_NO_AUTO)) - continue; - if (is_mbr && (flags != 0x80)) /* Bootable flag */ - continue; nr = blkid_partition_get_partno(pp); if (nr < 0) @@ -2723,6 +2778,9 @@ static int dissect_image( sd_id128_t type_id; const char *stype; + if (flags & GPT_FLAG_NO_AUTO) + continue; + stype = blkid_partition_get_type_string(pp); if (!stype) continue; @@ -2782,48 +2840,41 @@ static int dissect_image( return log_oom(); } #endif + else if (sd_id128_equal(type_id, GPT_LINUX_GENERIC)) { + + if (generic) + multiple_generic = true; + else { + generic_rw = !(flags & GPT_FLAG_READ_ONLY); + + r = free_and_strdup(&generic, node); + if (r < 0) + return log_oom(); + } + } } else if (is_mbr) { int type; + if (flags != 0x80) /* Bootable flag */ + continue; + type = blkid_partition_get_type(pp); if (type != 0x83) /* Linux partition */ continue; - /* Note that there's a certain, intended - * asymmetry here: while for GPT we simply - * take the first valid partition and ignore - * all others of the same type, for MBR we - * fail if there are multiple suitable - * partitions. This is because the GPT - * partition types are defined by us, and - * hence we can define their lookup semantics, - * while for the MBR logic we reuse existing - * definitions, and simply don't want to make - * out the situation. */ - - if (root) { - log_error("Identified multiple bootable Linux 0x83 partitions on\n" - " %s\n" - PARTITION_TABLE_BLURB, arg_image); - return -EINVAL; - } - - root_nr = nr; + if (generic) + multiple_generic = true; + else { + generic_rw = true; - r = free_and_strdup(&root, node); - if (r < 0) - return log_oom(); + r = free_and_strdup(&root, node); + if (r < 0) + return log_oom(); + } } } - if (!root && !secondary_root) { - log_error("Failed to identify root partition in disk image\n" - " %s\n" - PARTITION_TABLE_BLURB, arg_image); - return -EINVAL; - } - if (root) { *root_device = root; root = NULL; @@ -2836,6 +2887,31 @@ static int dissect_image( *root_device_rw = secondary_root_rw; *secondary = true; + } else if (generic) { + + /* There were no partitions with precise meanings + * around, but we found generic partitions. In this + * case, if there's only one, we can go ahead and boot + * it, otherwise we bail out, because we really cannot + * make any sense of it. */ + + if (multiple_generic) { + log_error("Identified multiple bootable Linux partitions on\n" + " %s\n" + PARTITION_TABLE_BLURB, arg_image); + return -EINVAL; + } + + *root_device = generic; + generic = NULL; + + *root_device_rw = generic_rw; + *secondary = false; + } else { + log_error("Failed to identify root partition in disk image\n" + " %s\n" + PARTITION_TABLE_BLURB, arg_image); + return -EINVAL; } if (home) { @@ -3321,7 +3397,7 @@ static int determine_names(void) { return -ENOENT; } - if (i->type == IMAGE_GPT) + if (i->type == IMAGE_RAW) r = set_sanitized_path(&arg_image, i->path); else r = set_sanitized_path(&arg_directory, i->path); @@ -3490,7 +3566,7 @@ int main(int argc, char *argv[]) { if (!arg_quiet) log_info("Directory %s already exists, not populating from template %s.", arg_directory, arg_template); } else if (r < 0) { - log_error_errno(r, "Couldn't create snapshort %s from %s: %m", arg_directory, arg_template); + log_error_errno(r, "Couldn't create snapshot %s from %s: %m", arg_directory, arg_template); goto finish; } else { if (!arg_quiet)