X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fnetwork%2Fnetworkd.c;h=ced319de1dd9c9af06f72c296e09faae61a00aa0;hb=fe21f16764147d51819a904d57ac36967f9913e3;hp=2f6a12dbccfddb58f5068a63ff1fb7b1c86141bb;hpb=f0c4cd7a2c2835a392b5b1807d8c506ab0af44de;p=elogind.git diff --git a/src/network/networkd.c b/src/network/networkd.c index 2f6a12dbc..ced319de1 100644 --- a/src/network/networkd.c +++ b/src/network/networkd.c @@ -19,6 +19,7 @@ along with systemd; If not, see . ***/ +#include "capability.h" #include "sd-event.h" #include "sd-daemon.h" @@ -26,6 +27,9 @@ int main(int argc, char *argv[]) { _cleanup_manager_free_ Manager *m = NULL; + const char *user = "systemd-network"; + uid_t uid; + gid_t gid; int r; log_set_target(LOG_TARGET_AUTO); @@ -40,52 +44,81 @@ int main(int argc, char *argv[]) { goto out; } + r = get_user_creds(&user, &uid, &gid, NULL, NULL); + if (r < 0) { + log_error_errno(r, "Cannot resolve user name %s: %m", user); + goto out; + } + /* Always create the directories people can create inotify * watches in. */ - mkdir_label("/run/systemd/network/links", 0755); - mkdir_label("/run/systemd/network/leases", 0755); + r = mkdir_safe_label("/run/systemd/netif", 0755, uid, gid); + if (r < 0) + log_error_errno(r, "Could not create runtime directory: %m"); + + r = mkdir_safe_label("/run/systemd/netif/links", 0755, uid, gid); + if (r < 0) + log_error_errno(r, "Could not create runtime directory 'links': %m"); + + r = mkdir_safe_label("/run/systemd/netif/leases", 0755, uid, gid); + if (r < 0) + log_error_errno(r, "Could not create runtime directory 'leases': %m"); + + r = mkdir_safe_label("/run/systemd/netif/lldp", 0755, uid, gid); + if (r < 0) + log_error("Could not create runtime directory 'lldp': %s", + strerror(-r)); + + + r = drop_privileges(uid, gid, + (1ULL << CAP_NET_ADMIN) | + (1ULL << CAP_NET_BIND_SERVICE) | + (1ULL << CAP_NET_BROADCAST) | + (1ULL << CAP_NET_RAW)); + if (r < 0) + goto out; + + assert_se(sigprocmask_many(SIG_BLOCK, SIGTERM, SIGINT, -1) == 0); r = manager_new(&m); if (r < 0) { - log_error("Could not create manager: %s", strerror(-r)); + log_error_errno(r, "Could not create manager: %m"); goto out; } r = manager_udev_listen(m); if (r < 0) { - log_error("Could not connect to udev: %s", strerror(-r)); + log_error_errno(r, "Could not connect to udev: %m"); goto out; } r = manager_rtnl_listen(m); if (r < 0) { - log_error("Could not connect to rtnl: %s", strerror(-r)); + log_error_errno(r, "Could not connect to rtnl: %m"); goto out; } r = manager_bus_listen(m); if (r < 0) { - log_error("Could not connect to system bus: %s", strerror(-r)); + log_error_errno(r, "Could not connect to system bus: %m"); goto out; } r = manager_load_config(m); if (r < 0) { - log_error("Could not load configuration files: %s", strerror(-r)); + log_error_errno(r, "Could not load configuration files: %m"); goto out; } - r = manager_udev_enumerate_links(m); + r = manager_rtnl_enumerate_links(m); if (r < 0) { - log_error("Could not enumerate links: %s", strerror(-r)); + log_error_errno(r, "Could not enumerate links: %m"); goto out; } - /* write out empty resolv.conf to avoid a - * dangling symlink */ - r = manager_update_resolv_conf(m); + r = manager_rtnl_enumerate_addresses(m); if (r < 0) { - log_error("Could not create resolv.conf: %s", strerror(-r)); + log_error_errno(r, "Could not enumerate links: %m"); goto out; } @@ -95,12 +128,13 @@ int main(int argc, char *argv[]) { r = sd_event_loop(m->event); if (r < 0) { - log_error("Event loop failed: %s", strerror(-r)); + log_error_errno(r, "Event loop failed: %m"); goto out; } out: sd_notify(false, + "STOPPING=1\n" "STATUS=Shutting down..."); return r < 0 ? EXIT_FAILURE : EXIT_SUCCESS;