X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fnetwork%2Fnetworkd-network.c;h=6e9915b75dabb2834ffbed4b14dd97fa4b4656f4;hb=06f021a8048583d66202e3ac5cd0a12386d33ac2;hp=02ffdb1a72fbbf967b6b14c8e54ec2936744abf6;hpb=4f882b2a5007e51032459e29d15a86df6b5ea9f4;p=elogind.git diff --git a/src/network/networkd-network.c b/src/network/networkd-network.c index 02ffdb1a7..6e9915b75 100644 --- a/src/network/networkd-network.c +++ b/src/network/networkd-network.c @@ -53,6 +53,14 @@ static int network_load_one(Manager *manager, const char *filename) { LIST_HEAD_INIT(network->static_addresses); LIST_HEAD_INIT(network->static_routes); + network->vlans = hashmap_new(string_hash_func, string_compare_func); + if (!network->vlans) + return log_oom(); + + network->macvlans = hashmap_new(uint64_hash_func, uint64_compare_func); + if (!network->macvlans) + return log_oom(); + network->addresses_by_section = hashmap_new(uint64_hash_func, uint64_compare_func); if (!network->addresses_by_section) return log_oom(); @@ -61,15 +69,20 @@ static int network_load_one(Manager *manager, const char *filename) { if (!network->routes_by_section) return log_oom(); + network->dns = set_new(NULL, NULL); + if (!network->dns) + return log_oom(); + network->filename = strdup(filename); if (!network->filename) return log_oom(); network->dhcp_dns = true; - network->dhcp_mtu = true; + network->dhcp_hostname = true; + network->dhcp_domainname = true; r = config_parse(NULL, filename, file, "Match\0Network\0Address\0Route\0DHCPv4\0", config_item_perf_lookup, - (void*) network_gperf_lookup, false, false, network); + (void*) network_network_gperf_lookup, false, false, network); if (r < 0) { log_warning("Could not parse config file %s: %s", filename, strerror(-r)); return r; @@ -83,12 +96,6 @@ static int network_load_one(Manager *manager, const char *filename) { "Ignoring", filename); return 0; } - - if (route->dst_family && route->family != route->dst_family) { - log_warning("Route section with conflicting Gateway and Destination address " - "family configured in %s. Ignoring", filename); - return 0; - } } LIST_FOREACH(static_addresses, address, network->static_addresses) { @@ -133,6 +140,7 @@ int network_load(Manager *manager) { void network_free(Network *network) { Route *route; Address *address; + Iterator i; if (!network) return; @@ -147,7 +155,14 @@ void network_free(Network *network) { free(network->description); - address_free(network->dns); + SET_FOREACH(address, network->dns, i) + address_free(address); + + set_free(network->dns); + + hashmap_free(network->vlans); + + hashmap_free(network->macvlans); while ((route = network->static_routes)) route_free(route); @@ -174,10 +189,13 @@ int network_get(Manager *manager, struct udev_device *device, Network **ret) { LIST_FOREACH(networks, network, manager->networks) { if (net_match_config(network->match_mac, network->match_path, network->match_driver, network->match_type, - network->match_name, + network->match_name, network->match_host, + network->match_virt, network->match_kernel, + network->match_arch, udev_device_get_sysattr_value(device, "address"), udev_device_get_property_value(device, "ID_PATH"), - udev_device_get_driver(device), + udev_device_get_driver(udev_device_get_parent(device)), + udev_device_get_property_value(device, "ID_NET_DRIVER"), udev_device_get_devtype(device), udev_device_get_sysname(device))) { log_debug("%s: found matching network '%s'", @@ -198,10 +216,6 @@ int network_apply(Manager *manager, Network *network, Link *link) { link->network = network; - r = link_configure(link); - if (r < 0) - return r; - if (network->dns) { r = manager_update_resolv_conf(manager); if (r < 0) @@ -222,7 +236,7 @@ int config_parse_bridge(const char *unit, void *data, void *userdata) { Network *network = userdata; - Bridge *bridge; + NetDev *netdev; int r; assert(filename); @@ -230,14 +244,141 @@ int config_parse_bridge(const char *unit, assert(rvalue); assert(data); - r = bridge_get(network->manager, rvalue, &bridge); + r = netdev_get(network->manager, rvalue, &netdev); if (r < 0) { log_syntax(unit, LOG_ERR, filename, line, EINVAL, "Bridge is invalid, ignoring assignment: %s", rvalue); return 0; } - network->bridge = bridge; + if (netdev->kind != NETDEV_KIND_BRIDGE) { + log_syntax(unit, LOG_ERR, filename, line, EINVAL, + "NetDev is not a bridge, ignoring assignment: %s", rvalue); + return 0; + } + + network->bridge = netdev; + + return 0; +} + +int config_parse_bond(const char *unit, + const char *filename, + unsigned line, + const char *section, + unsigned section_line, + const char *lvalue, + int ltype, + const char *rvalue, + void *data, + void *userdata) { + Network *network = userdata; + NetDev *netdev; + int r; + + assert(filename); + assert(lvalue); + assert(rvalue); + assert(data); + + r = netdev_get(network->manager, rvalue, &netdev); + if (r < 0) { + log_syntax(unit, LOG_ERR, filename, line, EINVAL, + "Bond is invalid, ignoring assignment: %s", rvalue); + return 0; + } + + if (netdev->kind != NETDEV_KIND_BOND) { + log_syntax(unit, LOG_ERR, filename, line, EINVAL, + "NetDev is not a bond, ignoring assignment: %s", rvalue); + return 0; + } + + network->bond = netdev; + + return 0; +} + +int config_parse_vlan(const char *unit, + const char *filename, + unsigned line, + const char *section, + unsigned section_line, + const char *lvalue, + int ltype, + const char *rvalue, + void *data, + void *userdata) { + Network *network = userdata; + NetDev *netdev; + int r; + + assert(filename); + assert(lvalue); + assert(rvalue); + assert(data); + + r = netdev_get(network->manager, rvalue, &netdev); + if (r < 0) { + log_syntax(unit, LOG_ERR, filename, line, EINVAL, + "VLAN is invalid, ignoring assignment: %s", rvalue); + return 0; + } + + if (netdev->kind != NETDEV_KIND_VLAN) { + log_syntax(unit, LOG_ERR, filename, line, EINVAL, + "NetDev is not a VLAN, ignoring assignment: %s", rvalue); + return 0; + } + + r = hashmap_put(network->vlans, &netdev->vlanid, netdev); + if (r < 0) { + log_syntax(unit, LOG_ERR, filename, line, EINVAL, + "Can not add VLAN to network: %s", rvalue); + return 0; + } + + return 0; +} + +int config_parse_macvlan(const char *unit, + const char *filename, + unsigned line, + const char *section, + unsigned section_line, + const char *lvalue, + int ltype, + const char *rvalue, + void *data, + void *userdata) { + Network *network = userdata; + NetDev *netdev; + int r; + + assert(filename); + assert(lvalue); + assert(rvalue); + assert(data); + + r = netdev_get(network->manager, rvalue, &netdev); + if (r < 0) { + log_syntax(unit, LOG_ERR, filename, line, EINVAL, + "MACVLAN is invalid, ignoring assignment: %s", rvalue); + return 0; + } + + if (netdev->kind != NETDEV_KIND_MACVLAN) { + log_syntax(unit, LOG_ERR, filename, line, EINVAL, + "NetDev is not a MACVLAN, ignoring assignment: %s", rvalue); + return 0; + } + + r = hashmap_put(network->macvlans, netdev->name, netdev); + if (r < 0) { + log_syntax(unit, LOG_ERR, filename, line, EINVAL, + "Can not add MACVLAN to network: %s", rvalue); + return 0; + } return 0; }