X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fnetwork%2Fnetworkd-network.c;h=56e5637a6601cdabcb9c19ae57cef9e3a552199d;hb=f048a16b464295a4e0a4f4c1210f06343ad31231;hp=d4239ab8d0f80479bd892661c97d83fa0bb5ae6a;hpb=0617ffabe86a6d366252477eafbe59a888b149d4;p=elogind.git diff --git a/src/network/networkd-network.c b/src/network/networkd-network.c index d4239ab8d..56e5637a6 100644 --- a/src/network/networkd-network.c +++ b/src/network/networkd-network.c @@ -30,6 +30,9 @@ static int network_load_one(Manager *manager, const char *filename) { _cleanup_fclose_ FILE *file = NULL; int r; + assert(manager); + assert(filename); + file = fopen(filename, "re"); if (!file) { if (errno == ENOENT) @@ -42,9 +45,24 @@ static int network_load_one(Manager *manager, const char *filename) { if (!network) return log_oom(); - LIST_HEAD_INIT(network->addresses); + network->manager = manager; + + LIST_HEAD_INIT(network->static_addresses); + LIST_HEAD_INIT(network->static_routes); + + network->addresses_by_section = hashmap_new(uint64_hash_func, uint64_compare_func); + if (!network->addresses_by_section) + return log_oom(); + + network->routes_by_section = hashmap_new(uint64_hash_func, uint64_compare_func); + if (!network->routes_by_section) + return log_oom(); + + network->filename = strdup(filename); + if (!network->filename) + return log_oom(); - r = config_parse(NULL, filename, file, "Match\0Network\0", config_item_perf_lookup, + r = config_parse(NULL, filename, file, "Match\0Network\0Address\0Route\0", config_item_perf_lookup, (void*) network_gperf_lookup, false, false, network); if (r < 0) { log_warning("Could not parse config file %s: %s", filename, strerror(-r)); @@ -52,12 +70,6 @@ static int network_load_one(Manager *manager, const char *filename) { } else log_debug("Parsed configuration file %s", filename); - network->filename = strdup(filename); - if (!network->filename) - return log_oom(); - - network->manager = manager; - LIST_PREPEND(networks, manager->networks, network); network = NULL; @@ -74,9 +86,6 @@ int network_load(Manager *manager) { while ((network = manager->networks)) network_free(network); - /* update timestamp */ - paths_check_timestamp(manager->network_dirs, &manager->network_dirs_ts_usec, true); - r = conf_files_list_strv(&files, ".network", NULL, (const char **)manager->network_dirs); if (r < 0) { log_error("failed to enumerate network files: %s", strerror(-r)); @@ -94,10 +103,6 @@ int network_load(Manager *manager) { return 0; } -bool network_should_reload(Manager *manager) { - return paths_check_timestamp(manager->network_dirs, &manager->network_dirs_ts_usec, false); -} - void network_free(Network *network) { Route *route; Address *address; @@ -115,12 +120,15 @@ void network_free(Network *network) { free(network->description); - while ((route = network->routes)) + while ((route = network->static_routes)) route_free(route); - while ((address = network->addresses)) + while ((address = network->static_addresses)) address_free(address); + hashmap_free(network->addresses_by_section); + hashmap_free(network->routes_by_section); + LIST_REMOVE(networks, network->manager->networks, network); free(network); @@ -133,8 +141,8 @@ int network_get(Manager *manager, struct udev_device *device, Network **ret) { assert(device); assert(ret); - if (network_should_reload(manager)) - network_load(manager); + if (manager_should_reload(manager)) + manager_load_config(manager); LIST_FOREACH(networks, network, manager->networks) { if (net_match_config(network->match_mac, network->match_path, @@ -161,8 +169,8 @@ int network_get(Manager *manager, struct udev_device *device, Network **ret) { int network_apply(Manager *manager, Network *network, Link *link) { int r; - log_info("Network '%s' being applied to link '%u'", - network->description, (unsigned) link->ifindex); + log_info("Network '%s' being applied to link '%s'", + network->description, link->ifname); link->network = network; @@ -172,3 +180,34 @@ int network_apply(Manager *manager, Network *network, Link *link) { return 0; } + +int config_parse_bridge(const char *unit, + const char *filename, + unsigned line, + const char *section, + unsigned section_line, + const char *lvalue, + int ltype, + const char *rvalue, + void *data, + void *userdata) { + Network *network = userdata; + Bridge *bridge; + int r; + + assert(filename); + assert(lvalue); + assert(rvalue); + assert(data); + + r = bridge_get(network->manager, rvalue, &bridge); + if (r < 0) { + log_syntax(unit, LOG_ERR, filename, line, EINVAL, + "Bridge is invalid, ignoring assignment: %s", rvalue); + return 0; + } + + network->bridge = bridge; + + return 0; +}