X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fjournal%2Fjournald-stream.c;h=b2291a260f32318716a306ba46314ebc8c628dc2;hb=e9174f29c7e3ee45137537b126458718913a3ec5;hp=5c15a56bacf61e038ed9c9d8320f548e7c772cc7;hpb=e3bfb7be07d9b1f4ebb12eb22c4c8bcd2a988d51;p=elogind.git

diff --git a/src/journal/journald-stream.c b/src/journal/journald-stream.c
index 5c15a56ba..b2291a260 100644
--- a/src/journal/journald-stream.c
+++ b/src/journal/journald-stream.c
@@ -22,12 +22,12 @@
 #include <fcntl.h>
 #include <unistd.h>
 #include <stddef.h>
-#include <sys/epoll.h>
 
 #ifdef HAVE_SELINUX
 #include <selinux/selinux.h>
 #endif
 
+#include "sd-event.h"
 #include "socket-util.h"
 #include "selinux-util.h"
 #include "journald-server.h"
@@ -71,6 +71,8 @@ struct StdoutStream {
         char buffer[LINE_MAX+1];
         size_t length;
 
+        sd_event_source *event_source;
+
         LIST_FIELDS(StdoutStream, stdout_stream);
 };
 
@@ -282,12 +284,19 @@ static int stdout_stream_scan(StdoutStream *s, bool force_flush) {
         return 0;
 }
 
-int stdout_stream_process(StdoutStream *s) {
+static int stdout_stream_process(sd_event_source *es, int fd, uint32_t revents, void *userdata) {
+        StdoutStream *s = userdata;
         ssize_t l;
         int r;
 
         assert(s);
 
+        if ((revents|EPOLLIN|EPOLLHUP) != (EPOLLIN|EPOLLHUP)) {
+                log_error("Got invalid event from epoll for stdout stream: %"PRIx32, revents);
+                r = -EIO;
+                goto terminate;
+        }
+
         l = read(s->fd, s->buffer+s->length, sizeof(s->buffer)-1-s->length);
         if (l < 0) {
 
@@ -295,24 +304,25 @@ int stdout_stream_process(StdoutStream *s) {
                         return 0;
 
                 log_warning("Failed to read from stream: %m");
-                return -errno;
+                r = -errno;
+                goto terminate;
         }
 
         if (l == 0) {
                 r = stdout_stream_scan(s, true);
-                if (r < 0)
-                        return r;
-
-                return 0;
+                goto terminate;
         }
 
         s->length += l;
         r = stdout_stream_scan(s, false);
         if (r < 0)
-                return r;
+                goto terminate;
 
         return 1;
 
+terminate:
+        stdout_stream_free(s);
+        return 0;
 }
 
 void stdout_stream_free(StdoutStream *s) {
@@ -324,12 +334,11 @@ void stdout_stream_free(StdoutStream *s) {
                 LIST_REMOVE(stdout_stream, s->server->stdout_streams, s);
         }
 
-        if (s->fd >= 0) {
-                if (s->server)
-                        epoll_ctl(s->server->epoll_fd, EPOLL_CTL_DEL, s->fd, NULL);
+        if (s->event_source)
+                s->event_source = sd_event_source_unref(s->event_source);
 
+        if (s->fd >= 0)
                 close_nointr_nofail(s->fd);
-        }
 
 #ifdef HAVE_SELINUX
         if (s->security_context)
@@ -341,14 +350,19 @@ void stdout_stream_free(StdoutStream *s) {
         free(s);
 }
 
-int stdout_stream_new(Server *s) {
+static int stdout_stream_new(sd_event_source *es, int listen_fd, uint32_t revents, void *userdata) {
+        Server *s = userdata;
         StdoutStream *stream;
         int fd, r;
         socklen_t len;
-        struct epoll_event ev;
 
         assert(s);
 
+        if (revents != EPOLLIN) {
+                log_error("Got invalid event from epoll for stdout server fd: %"PRIx32, revents);
+                return -EIO;
+        }
+
         fd = accept4(s->stdout_fd, NULL, NULL, SOCK_NONBLOCK|SOCK_CLOEXEC);
         if (fd < 0) {
                 if (errno == EAGAIN)
@@ -392,12 +406,15 @@ int stdout_stream_new(Server *s) {
                 goto fail;
         }
 
-        zero(ev);
-        ev.data.ptr = stream;
-        ev.events = EPOLLIN;
-        if (epoll_ctl(s->epoll_fd, EPOLL_CTL_ADD, fd, &ev) < 0) {
-                log_error("Failed to add stream to event loop: %m");
-                r = -errno;
+        r = sd_event_add_io(s->event, fd, EPOLLIN, stdout_stream_process, stream, &stream->event_source);
+        if (r < 0) {
+                log_error("Failed to add stream to event loop: %s", strerror(-r));
+                goto fail;
+        }
+
+        r = sd_event_source_set_priority(stream->event_source, SD_EVENT_PRIORITY_NORMAL+5);
+        if (r < 0) {
+                log_error("Failed to adjust stdout event source priority: %s", strerror(-r));
                 goto fail;
         }
 
@@ -414,7 +431,6 @@ fail:
 
 int server_open_stdout_socket(Server *s) {
         int r;
-        struct epoll_event ev = { .events = EPOLLIN };
 
         assert(s);
 
@@ -447,10 +463,16 @@ int server_open_stdout_socket(Server *s) {
         } else
                 fd_nonblock(s->stdout_fd, 1);
 
-        ev.data.fd = s->stdout_fd;
-        if (epoll_ctl(s->epoll_fd, EPOLL_CTL_ADD, s->stdout_fd, &ev) < 0) {
-                log_error("Failed to add stdout server fd to epoll object: %m");
-                return -errno;
+        r = sd_event_add_io(s->event, s->stdout_fd, EPOLLIN, stdout_stream_new, s, &s->stdout_event_source);
+        if (r < 0) {
+                log_error("Failed to add stdout server fd to event source: %s", strerror(-r));
+                return r;
+        }
+
+        r = sd_event_source_set_priority(s->stdout_event_source, SD_EVENT_PRIORITY_NORMAL+10);
+        if (r < 0) {
+                log_error("Failed to adjust priority of stdout server event source: %s", strerror(-r));
+                return r;
         }
 
         return 0;