X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fjournal%2Fjournal-remote.c;h=ec4054f2f543930aadbea90a48ecc56e9c95f2f5;hb=dfd9cf7f0b257d38f5527989dd9315e767fbe41b;hp=f8979daca67e0c5e0de5cc684dd6b0b2e8dd2f44;hpb=fdfccdbc985944a57017a25f44dd6acc1a937bab;p=elogind.git diff --git a/src/journal/journal-remote.c b/src/journal/journal-remote.c index f8979daca..ec4054f2f 100644 --- a/src/journal/journal-remote.c +++ b/src/journal/journal-remote.c @@ -41,6 +41,12 @@ #include "build.h" #include "macro.h" #include "strv.h" +#include "fileio.h" +#include "microhttpd-util.h" + +#ifdef HAVE_GNUTLS +#include +#endif #include "journal-remote-parse.h" #include "journal-remote-write.h" @@ -50,10 +56,17 @@ static char* arg_output = NULL; static char* arg_url = NULL; static char* arg_getter = NULL; -static bool arg_stdin = false; static char* arg_listen_raw = NULL; +static char* arg_listen_http = NULL; +static char* arg_listen_https = NULL; +static char** arg_files = NULL; static int arg_compress = true; static int arg_seal = false; +static int http_socket = -1, https_socket = -1; + +static char *key_pem = NULL; +static char *cert_pem = NULL; +static char *trust_pem = NULL; /********************************************************************** ********************************************************************** @@ -75,7 +88,7 @@ static int spawn_child(const char* child, char** argv) { if (child_pid < 0) { r = -errno; log_error("Failed to fork: %m"); - close_pipe(fd); + safe_close_pair(fd); return r; } @@ -87,9 +100,7 @@ static int spawn_child(const char* child, char** argv) { _exit(EXIT_FAILURE); } - r = close_pipe(fd); - if (r < 0) - log_warning("Failed to close pipe fds: %m"); + safe_close_pair(fd); /* Make sure the child goes away when the parent dies */ if (prctl(PR_SET_PDEATHSIG, SIGTERM) < 0) @@ -128,7 +139,7 @@ static int spawn_curl(char* url) { static int spawn_getter(char *getter, char *url) { int r; - char _cleanup_strv_free_ **words = NULL, **words2 = NULL; + char _cleanup_strv_free_ **words = NULL; assert(getter); words = strv_split_quoted(getter); @@ -201,17 +212,33 @@ static int open_output(Writer *s, const char* url) { return r; } +/********************************************************************** + ********************************************************************** + **********************************************************************/ + +typedef struct MHDDaemonWrapper { + uint64_t fd; + struct MHD_Daemon *daemon; + + sd_event_source *event; +} MHDDaemonWrapper; + typedef struct RemoteServer { RemoteSource **sources; - ssize_t sources_size; - ssize_t active; + size_t sources_size; + size_t active; sd_event *events; sd_event_source *sigterm_event, *sigint_event, *listen_event; Writer writer; + + Hashmap *daemons; } RemoteServer; +/* This should go away as soon as µhttpd allows state to be passed around. */ +static RemoteServer *server; + static int dispatch_raw_source_event(sd_event_source *event, int fd, uint32_t revents, @@ -220,12 +247,16 @@ static int dispatch_raw_connection_event(sd_event_source *event, int fd, uint32_t revents, void *userdata); +static int dispatch_http_event(sd_event_source *event, + int fd, + uint32_t revents, + void *userdata); static int get_source_for_fd(RemoteServer *s, int fd, RemoteSource **source) { assert(fd >= 0); assert(source); - if (!GREEDY_REALLOC0_T(s->sources, s->sources_size, fd + 1)) + if (!GREEDY_REALLOC0(s->sources, s->sources_size, fd + 1)) return log_oom(); if (s->sources[fd] == NULL) { @@ -244,8 +275,7 @@ static int remove_source(RemoteServer *s, int fd) { RemoteSource *source; assert(s); - assert(fd >= 0); - assert(fd < s->sources_size); + assert(fd >= 0 && fd < (ssize_t) s->sources_size); source = s->sources[fd]; if (source) { @@ -303,22 +333,307 @@ static int add_source(RemoteServer *s, int fd, const char* name) { return r; } +static int add_raw_socket(RemoteServer *s, int fd) { + int r; + + r = sd_event_add_io(s->events, &s->listen_event, fd, EPOLLIN, + dispatch_raw_connection_event, s); + if (r < 0) { + close(fd); + return r; + } + + s->active ++; + return 0; +} + static int setup_raw_socket(RemoteServer *s, const char *address) { - int fd, r; + int fd; fd = make_socket_fd(LOG_INFO, address, SOCK_STREAM | SOCK_CLOEXEC); if (fd < 0) return fd; - r = sd_event_add_io(s->events, &s->listen_event, fd, EPOLLIN, - dispatch_raw_connection_event, s); + return add_raw_socket(s, fd); +} + +/********************************************************************** + ********************************************************************** + **********************************************************************/ + +static RemoteSource *request_meta(void **connection_cls) { + RemoteSource *source; + + assert(connection_cls); + if (*connection_cls) + return *connection_cls; + + source = new0(RemoteSource, 1); + if (!source) + return NULL; + source->fd = -1; + + log_debug("Added RemoteSource as connection metadata %p", source); + + *connection_cls = source; + return source; +} + +static void request_meta_free(void *cls, + struct MHD_Connection *connection, + void **connection_cls, + enum MHD_RequestTerminationCode toe) { + RemoteSource *s; + + assert(connection_cls); + s = *connection_cls; + + log_debug("Cleaning up connection metadata %p", s); + source_free(s); + *connection_cls = NULL; +} + +static int process_http_upload( + struct MHD_Connection *connection, + const char *upload_data, + size_t *upload_data_size, + RemoteSource *source) { + + bool finished = false; + int r; + + assert(source); + + log_debug("request_handler_upload: connection %p, %zu bytes", + connection, *upload_data_size); + + if (*upload_data_size) { + log_info("Received %zu bytes", *upload_data_size); + + r = push_data(source, upload_data, *upload_data_size); + if (r < 0) { + log_error("Failed to store received data of size %zu: %s", + *upload_data_size, strerror(-r)); + return mhd_respond_oom(connection); + } + *upload_data_size = 0; + } else + finished = true; + + while (true) { + r = process_source(source, &server->writer, arg_compress, arg_seal); + if (r == -E2BIG) + log_warning("Entry too big, skipped"); + else if (r == -EAGAIN || r == -EWOULDBLOCK) + break; + else if (r < 0) { + log_warning("Failed to process data for connection %p", connection); + return mhd_respondf(connection, MHD_HTTP_UNPROCESSABLE_ENTITY, + "Processing failed: %s", strerror(-r)); + } + } + + if (!finished) + return MHD_YES; + + /* The upload is finished */ + + if (source_non_empty(source)) { + log_warning("EOF reached with incomplete data"); + return mhd_respond(connection, MHD_HTTP_EXPECTATION_FAILED, + "Trailing data not processed."); + } + + return mhd_respond(connection, MHD_HTTP_ACCEPTED, "OK.\n"); +}; + +static int request_handler( + void *cls, + struct MHD_Connection *connection, + const char *url, + const char *method, + const char *version, + const char *upload_data, + size_t *upload_data_size, + void **connection_cls) { + + const char *header; + int r ,code; + + assert(connection); + assert(connection_cls); + assert(url); + assert(method); + + log_debug("Handling a connection %s %s %s", method, url, version); + + if (*connection_cls) + return process_http_upload(connection, + upload_data, upload_data_size, + *connection_cls); + + if (!streq(method, "POST")) + return mhd_respond(connection, MHD_HTTP_METHOD_NOT_ACCEPTABLE, + "Unsupported method.\n"); + + if (!streq(url, "/upload")) + return mhd_respond(connection, MHD_HTTP_NOT_FOUND, + "Not found.\n"); + + header = MHD_lookup_connection_value(connection, + MHD_HEADER_KIND, "Content-Type"); + if (!header || !streq(header, "application/vnd.fdo.journal")) + return mhd_respond(connection, MHD_HTTP_UNSUPPORTED_MEDIA_TYPE, + "Content-Type: application/vnd.fdo.journal" + " is required.\n"); + + if (trust_pem) { + r = check_permissions(connection, &code); + if (r < 0) + return code; + } + + if (!request_meta(connection_cls)) + return respond_oom(connection); + return MHD_YES; +} + +static int setup_microhttpd_server(RemoteServer *s, int fd, bool https) { + struct MHD_OptionItem opts[] = { + { MHD_OPTION_NOTIFY_COMPLETED, (intptr_t) request_meta_free}, + { MHD_OPTION_EXTERNAL_LOGGER, (intptr_t) microhttpd_logger}, + { MHD_OPTION_LISTEN_SOCKET, fd}, + { MHD_OPTION_END}, + { MHD_OPTION_END}, + { MHD_OPTION_END}, + { MHD_OPTION_END}}; + int opts_pos = 3; + int flags = + MHD_USE_DEBUG | + MHD_USE_PEDANTIC_CHECKS | + MHD_USE_EPOLL_LINUX_ONLY | + MHD_USE_DUAL_STACK; + + const union MHD_DaemonInfo *info; + int r, epoll_fd; + MHDDaemonWrapper *d; + + assert(fd >= 0); + + r = fd_nonblock(fd, true); if (r < 0) { - close(fd); + log_error("Failed to make fd:%d nonblocking: %s", fd, strerror(-r)); return r; } + if (https) { + opts[opts_pos++] = (struct MHD_OptionItem) + {MHD_OPTION_HTTPS_MEM_KEY, 0, key_pem}; + opts[opts_pos++] = (struct MHD_OptionItem) + {MHD_OPTION_HTTPS_MEM_CERT, 0, cert_pem}; + + flags |= MHD_USE_SSL; + + if (trust_pem) + opts[opts_pos++] = (struct MHD_OptionItem) + {MHD_OPTION_HTTPS_MEM_TRUST, 0, trust_pem}; + } + + d = new(MHDDaemonWrapper, 1); + if (!d) + return log_oom(); + + d->fd = (uint64_t) fd; + + d->daemon = MHD_start_daemon(flags, 0, + NULL, NULL, + request_handler, NULL, + MHD_OPTION_ARRAY, opts, + MHD_OPTION_END); + if (!d->daemon) { + log_error("Failed to start µhttp daemon"); + r = -EINVAL; + goto error; + } + + log_debug("Started MHD %s daemon on fd:%d (wrapper @ %p)", + https ? "HTTPS" : "HTTP", fd, d); + + + info = MHD_get_daemon_info(d->daemon, MHD_DAEMON_INFO_EPOLL_FD_LINUX_ONLY); + if (!info) { + log_error("µhttp returned NULL daemon info"); + r = -ENOTSUP; + goto error; + } + + epoll_fd = info->listen_fd; + if (epoll_fd < 0) { + log_error("µhttp epoll fd is invalid"); + r = -EUCLEAN; + goto error; + } + + r = sd_event_add_io(s->events, &d->event, + epoll_fd, EPOLLIN, dispatch_http_event, d); + if (r < 0) { + log_error("Failed to add event callback: %s", strerror(-r)); + goto error; + } + + r = hashmap_ensure_allocated(&s->daemons, uint64_hash_func, uint64_compare_func); + if (r < 0) { + log_oom(); + goto error; + } + + r = hashmap_put(s->daemons, &d->fd, d); + if (r < 0) { + log_error("Failed to add daemon to hashmap: %s", strerror(-r)); + goto error; + } + s->active ++; return 0; + +error: + MHD_stop_daemon(d->daemon); + free(d->daemon); + free(d); + return r; +} + +static int setup_microhttpd_socket(RemoteServer *s, + const char *address, + bool https) { + int fd; + + fd = make_socket_fd(LOG_INFO, address, SOCK_STREAM | SOCK_CLOEXEC); + if (fd < 0) + return fd; + + return setup_microhttpd_server(s, fd, https); +} + +static int dispatch_http_event(sd_event_source *event, + int fd, + uint32_t revents, + void *userdata) { + MHDDaemonWrapper *d = userdata; + int r; + + assert(d); + + log_info("%s", __func__); + + r = MHD_run(d->daemon); + if (r == MHD_NO) { + log_error("MHD_run failed!"); + // XXX: unregister daemon + return -EINVAL; + } + + return 1; /* work to do */ } /********************************************************************** @@ -359,9 +674,24 @@ static int setup_signals(RemoteServer *s) { return 0; } +static int fd_fd(const char *spec) { + int fd, r; + + r = safe_atoi(spec, &fd); + if (r < 0) + return r; + + if (fd >= 0) + return -ENOENT; + + return -fd; +} + + static int remoteserver_init(RemoteServer *s) { int r, n, fd; const char *output_name = NULL; + char **file; assert(s); @@ -369,6 +699,9 @@ static int remoteserver_init(RemoteServer *s) { setup_signals(s); + assert(server == NULL); + server = s; + n = sd_listen_fds(true); if (n < 0) { log_error("Failed to read listening file descriptors from environment: %s", @@ -377,18 +710,38 @@ static int remoteserver_init(RemoteServer *s) { } else log_info("Received %d descriptors", n); + if (MAX(http_socket, https_socket) >= SD_LISTEN_FDS_START + n) { + log_error("Received fewer sockets than expected"); + return -EBADFD; + } + for (fd = SD_LISTEN_FDS_START; fd < SD_LISTEN_FDS_START + n; fd++) { if (sd_is_socket(fd, AF_UNSPEC, 0, false)) { - assert_not_reached("not implemented"); + log_info("Received a listening socket (fd:%d)", fd); + + if (fd == http_socket) + r = setup_microhttpd_server(s, fd, false); + else if (fd == https_socket) + r = setup_microhttpd_server(s, fd, true); + else + r = add_raw_socket(s, fd); } else if (sd_is_socket(fd, AF_UNSPEC, 0, true)) { log_info("Received a connection socket (fd:%d)", fd); r = add_source(s, fd, NULL); - output_name = "socket"; } else { log_error("Unknown socket passed on fd:%d", fd); + return -EINVAL; } + + if(r < 0) { + log_error("Failed to register socket (fd:%d): %s", + fd, strerror(-r)); + return r; + } + + output_name = "socket"; } if (arg_url) { @@ -426,13 +779,42 @@ static int remoteserver_init(RemoteServer *s) { output_name = arg_listen_raw; } - if (arg_stdin) { - log_info("Reading standard input..."); - r = add_source(s, STDIN_FILENO, "stdin"); + if (arg_listen_http) { + r = setup_microhttpd_socket(s, arg_listen_http, false); if (r < 0) return r; - output_name = "stdin"; + output_name = arg_listen_http; + } + + if (arg_listen_https) { + r = setup_microhttpd_socket(s, arg_listen_https, true); + if (r < 0) + return r; + + output_name = arg_listen_https; + } + + STRV_FOREACH(file, arg_files) { + if (streq(*file, "-")) { + log_info("Reading standard input..."); + + fd = STDIN_FILENO; + output_name = "stdin"; + } else { + log_info("Reading file %s...", *file); + + fd = open(*file, O_RDONLY|O_CLOEXEC|O_NOCTTY|O_NONBLOCK); + if (fd < 0) { + log_error("Failed to open %s: %m", *file); + return -errno; + } + output_name = *file; + } + + r = add_source(s, fd, output_name); + if (r < 0) + return r; } if (s->active == 0) { @@ -440,7 +822,7 @@ static int remoteserver_init(RemoteServer *s) { return -EINVAL; } - if (!!n + !!arg_url + !!arg_listen_raw + !!arg_stdin > 1) + if (!!n + !!arg_url + !!arg_listen_raw + !!arg_files) output_name = "multiple"; r = writer_init(&s->writer); @@ -453,12 +835,21 @@ static int remoteserver_init(RemoteServer *s) { static int server_destroy(RemoteServer *s) { int r; - ssize_t i; + size_t i; + MHDDaemonWrapper *d; r = writer_close(&s->writer); + while ((d = hashmap_steal_first(s->daemons))) { + MHD_stop_daemon(d->daemon); + sd_event_source_unref(d->event); + free(d); + } + + hashmap_free(s->daemons); + assert(s->sources_size == 0 || s->sources); - for(i = 0; i < s->sources_size; i++) + for (i = 0; i < s->sources_size; i++) remove_source(s, i); free(s->sources); @@ -486,7 +877,7 @@ static int dispatch_raw_source_event(sd_event_source *event, RemoteSource *source; int r; - assert(fd < s->sources_size); + assert(fd >= 0 && fd < (ssize_t) s->sources_size); source = s->sources[fd]; assert(source->fd == fd); @@ -506,69 +897,75 @@ static int dispatch_raw_source_event(sd_event_source *event, return r; } -static int dispatch_raw_connection_event(sd_event_source *event, - int fd, - uint32_t revents, - void *userdata) { - RemoteServer *s = userdata; - - SocketAddress addr = { - .size = sizeof(union sockaddr_union), - .type = SOCK_STREAM, - }; +static int accept_connection(const char* type, int fd, SocketAddress *addr) { int fd2, r; - log_debug("Accepting new connection on fd:%d", fd); - fd2 = accept4(fd, &addr.sockaddr.sa, &addr.size, SOCK_NONBLOCK|SOCK_CLOEXEC); + log_debug("Accepting new %s connection on fd:%d", type, fd); + fd2 = accept4(fd, &addr->sockaddr.sa, &addr->size, SOCK_NONBLOCK|SOCK_CLOEXEC); if (fd2 < 0) { log_error("accept() on fd:%d failed: %m", fd); return -errno; } - switch(socket_address_family(&addr)) { + switch(socket_address_family(addr)) { case AF_INET: case AF_INET6: { char* _cleanup_free_ a = NULL; - r = socket_address_print(&addr, &a); + r = socket_address_print(addr, &a); if (r < 0) { log_error("socket_address_print(): %s", strerror(-r)); close(fd2); return r; } - log_info("Accepted %s connection from %s", - socket_address_family(&addr) == AF_INET ? "IP" : "IPv6", + log_info("Accepted %s %s connection from %s", + type, + socket_address_family(addr) == AF_INET ? "IP" : "IPv6", a); - break; + + return fd2; }; default: - log_error("Connection with unsupported family %d", - socket_address_family(&addr)); + log_error("Rejected %s connection with unsupported family %d", + type, socket_address_family(addr)); close(fd2); + return -EINVAL; } +} - r = add_source(s, fd2, NULL); - if (r < 0) - log_error("failed to create source from fd:%d: %s", fd2, strerror(-r)); +static int dispatch_raw_connection_event(sd_event_source *event, + int fd, + uint32_t revents, + void *userdata) { + RemoteServer *s = userdata; + int fd2; + SocketAddress addr = { + .size = sizeof(union sockaddr_union), + .type = SOCK_STREAM, + }; - return r; -} + fd2 = accept_connection("raw", fd, &addr); + if (fd2 < 0) + return fd2; + return add_source(s, fd2, NULL); +} /********************************************************************** ********************************************************************** **********************************************************************/ static int help(void) { - printf("%s [OPTIONS...]\n\n" + printf("%s [OPTIONS...] {FILE|-}...\n\n" "Write external journal events to a journal file.\n\n" "Options:\n" " --url=URL Read events from systemd-journal-gatewayd at URL\n" " --getter=COMMAND Read events from the output of COMMAND\n" " --listen-raw=ADDR Listen for connections at ADDR\n" - " --stdin Read events from standard input\n" + " --listen-http=ADDR Listen for HTTP connections at ADDR\n" + " --listen-https=ADDR Listen for HTTPS connections at ADDR\n" " -o --output=FILE|DIR Write output to FILE or DIR/external-*.journal\n" " --[no-]compress Use XZ-compression in the output journal (default: yes)\n" " --[no-]seal Use Event sealing in the output journal (default: no)\n" @@ -586,12 +983,16 @@ static int parse_argv(int argc, char *argv[]) { ARG_VERSION = 0x100, ARG_URL, ARG_LISTEN_RAW, - ARG_STDIN, + ARG_LISTEN_HTTP, + ARG_LISTEN_HTTPS, ARG_GETTER, ARG_COMPRESS, ARG_NO_COMPRESS, ARG_SEAL, ARG_NO_SEAL, + ARG_KEY, + ARG_CERT, + ARG_TRUST, }; static const struct option options[] = { @@ -600,16 +1001,20 @@ static int parse_argv(int argc, char *argv[]) { { "url", required_argument, NULL, ARG_URL }, { "getter", required_argument, NULL, ARG_GETTER }, { "listen-raw", required_argument, NULL, ARG_LISTEN_RAW }, - { "stdin", no_argument, NULL, ARG_STDIN }, + { "listen-http", required_argument, NULL, ARG_LISTEN_HTTP }, + { "listen-https", required_argument, NULL, ARG_LISTEN_HTTPS }, { "output", required_argument, NULL, 'o' }, { "compress", no_argument, NULL, ARG_COMPRESS }, { "no-compress", no_argument, NULL, ARG_NO_COMPRESS }, { "seal", no_argument, NULL, ARG_SEAL }, { "no-seal", no_argument, NULL, ARG_NO_SEAL }, + { "key", required_argument, NULL, ARG_KEY }, + { "cert", required_argument, NULL, ARG_CERT }, + { "trust", required_argument, NULL, ARG_TRUST }, {} }; - int c; + int c, r; assert(argc >= 0); assert(argv); @@ -652,10 +1057,87 @@ static int parse_argv(int argc, char *argv[]) { arg_listen_raw = optarg; break; - case ARG_STDIN: - arg_stdin = true; + case ARG_LISTEN_HTTP: + if (arg_listen_http || http_socket >= 0) { + log_error("cannot currently use --listen-http more than once"); + return -EINVAL; + } + + r = fd_fd(optarg); + if (r >= 0) + http_socket = r; + else if (r == -ENOENT) + arg_listen_http = optarg; + else { + log_error("Invalid port/fd specification %s: %s", + optarg, strerror(-r)); + return -EINVAL; + } + break; + case ARG_LISTEN_HTTPS: + if (arg_listen_https || https_socket >= 0) { + log_error("cannot currently use --listen-https more than once"); + return -EINVAL; + } + + r = fd_fd(optarg); + if (r >= 0) + https_socket = r; + else if (r == -ENOENT) + arg_listen_https = optarg; + else { + log_error("Invalid port/fd specification %s: %s", + optarg, strerror(-r)); + return -EINVAL; + } + + break; + + case ARG_KEY: + if (key_pem) { + log_error("Key file specified twice"); + return -EINVAL; + } + r = read_full_file(optarg, &key_pem, NULL); + if (r < 0) { + log_error("Failed to read key file: %s", strerror(-r)); + return r; + } + assert(key_pem); + break; + + case ARG_CERT: + if (cert_pem) { + log_error("Certificate file specified twice"); + return -EINVAL; + } + r = read_full_file(optarg, &cert_pem, NULL); + if (r < 0) { + log_error("Failed to read certificate file: %s", strerror(-r)); + return r; + } + assert(cert_pem); + break; + + case ARG_TRUST: +#ifdef HAVE_GNUTLS + if (trust_pem) { + log_error("CA certificate file specified twice"); + return -EINVAL; + } + r = read_full_file(optarg, &trust_pem, NULL); + if (r < 0) { + log_error("Failed to read CA certificate file: %s", strerror(-r)); + return r; + } + assert(trust_pem); + break; +#else + log_error("Option --trust is not available."); +#endif + case 'o': if (arg_output) { log_error("cannot use --output/-o more than once"); @@ -686,14 +1168,29 @@ static int parse_argv(int argc, char *argv[]) { return -EINVAL; } - if (optind < argc) { - log_error("This program takes no positional arguments"); + if (arg_listen_https && !(key_pem && cert_pem)) { + log_error("Options --key and --cert must be used when https sources are specified"); return -EINVAL; } + if (optind < argc) + arg_files = argv + optind; + return 1 /* work to do */; } +static int setup_gnutls_logger(void) { + if (!arg_listen_http && !arg_listen_https) + return 0; + +#ifdef HAVE_GNUTLS + gnutls_global_set_log_function(log_func_gnutls); + gnutls_global_set_log_level(GNUTLS_LOG_LEVEL); +#endif + + return 0; +} + int main(int argc, char **argv) { RemoteServer s = {}; int r, r2; @@ -706,6 +1203,10 @@ int main(int argc, char **argv) { if (r <= 0) return r == 0 ? EXIT_SUCCESS : EXIT_FAILURE; + r = setup_gnutls_logger(); + if (r < 0) + return EXIT_FAILURE; + if (remoteserver_init(&s) < 0) return EXIT_FAILURE;