X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fcore%2Floopback-setup.c;h=ca10e20a344cdb85980c475d739eecc0bf37ee03;hb=687f6a0ba77872299b9fb1f2f04d31c977088a63;hp=ab6335c0ceb576198b03630ac7288b90dae25dd7;hpb=58a489c2b3628f3003d3901537bec8b5e6c1b7bd;p=elogind.git diff --git a/src/core/loopback-setup.c b/src/core/loopback-setup.c index ab6335c0c..ca10e20a3 100644 --- a/src/core/loopback-setup.c +++ b/src/core/loopback-setup.c @@ -56,30 +56,24 @@ static int start_loopback(sd_rtnl *rtnl) { return 0; } -static int check_loopback(void) { +static bool check_loopback(sd_rtnl *rtnl) { + _cleanup_rtnl_message_unref_ sd_rtnl_message *req = NULL, *reply = NULL; + unsigned flags; int r; - _cleanup_close_ int fd = -1; - union { - struct sockaddr sa; - struct sockaddr_in in; - } sa = { - .in.sin_family = AF_INET, - .in.sin_addr.s_addr = htonl(INADDR_LOOPBACK), - }; - - /* If we failed to set up the loop back device, check whether - * it might already be set up */ - - fd = socket(AF_INET, SOCK_DGRAM|SOCK_NONBLOCK|SOCK_CLOEXEC, 0); - if (fd < 0) - return -errno; - - if (bind(fd, &sa.sa, sizeof(sa.in)) >= 0) - r = 1; - else - r = errno == EADDRNOTAVAIL ? 0 : -errno; - - return r; + + r = sd_rtnl_message_new_link(rtnl, &req, RTM_GETLINK, LOOPBACK_IFINDEX); + if (r < 0) + return false; + + r = sd_rtnl_call(rtnl, req, 0, &reply); + if (r < 0) + return false; + + r = sd_rtnl_message_link_get_flags(reply, &flags); + if (r < 0) + return false; + + return flags & IFF_UP; } int loopback_setup(void) { @@ -92,7 +86,7 @@ int loopback_setup(void) { r = start_loopback(rtnl); if (r == -EPERM) { - if (check_loopback() < 0) + if (!check_loopback(rtnl)) return log_warning_errno(EPERM, "Failed to configure loopback device: %m"); } else if (r < 0) return log_warning_errno(r, "Failed to configure loopback device: %m");