X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fask-password-api.c;h=9c3dad965e03099bd509ef9b3e379fc84ed6db82;hb=f9b72cd804f99222cf999c63eb3610a7f54bbf2c;hp=dd54fb6abf22a0680f0849b67fd31f138a5a180a;hpb=c0f9c7da07fccafed646e0a15df9bc132e3fc7fb;p=elogind.git

diff --git a/src/ask-password-api.c b/src/ask-password-api.c
index dd54fb6ab..9c3dad965 100644
--- a/src/ask-password-api.c
+++ b/src/ask-password-api.c
@@ -179,8 +179,6 @@ int ask_password_tty(
                 }
         }
 
-        if (ttyfd >= 0)
-
         passphrase[p] = 0;
 
         if (!(*_passphrase = strdup(passphrase))) {
@@ -225,7 +223,7 @@ static int create_socket(char **name) {
 
         zero(sa);
         sa.un.sun_family = AF_UNIX;
-        snprintf(sa.un.sun_path, sizeof(sa.un.sun_path)-1, "/dev/.systemd/ask-password/sck.%llu", random_ull());
+        snprintf(sa.un.sun_path, sizeof(sa.un.sun_path)-1, "/dev/.run/systemd/ask-password/sck.%llu", random_ull());
 
         if (bind(fd, &sa.sa, offsetof(struct sockaddr_un, sun_path) + strlen(sa.un.sun_path)) < 0) {
                 r = -errno;
@@ -267,18 +265,22 @@ int ask_password_agent(
                 _FD_MAX
         };
 
-        char temp[] = "/dev/.systemd/ask-password/tmp.XXXXXX";
+        char temp[] = "/dev/.run/systemd/ask-password/tmp.XXXXXX";
         char final[sizeof(temp)] = "";
         int fd = -1, r;
         FILE *f = NULL;
         char *socket_name = NULL;
         int socket_fd = -1, signal_fd = -1;
-        sigset_t mask;
+        sigset_t mask, oldmask;
         struct pollfd pollfd[_FD_MAX];
 
         assert(_passphrases);
 
-        mkdir_p("/dev/.systemd/ask-password", 0755);
+        assert_se(sigemptyset(&mask) == 0);
+        sigset_add_many(&mask, SIGINT, SIGTERM, -1);
+        assert_se(sigprocmask(SIG_BLOCK, &mask, &oldmask) == 0);
+
+        mkdir_p("/dev/.run/systemd/ask-password", 0755);
 
         if ((fd = mkostemp(temp, O_CLOEXEC|O_CREAT|O_WRONLY)) < 0) {
                 log_error("Failed to create password file: %m");
@@ -296,10 +298,6 @@ int ask_password_agent(
 
         fd = -1;
 
-        assert_se(sigemptyset(&mask) == 0);
-        sigset_add_many(&mask, SIGINT, SIGTERM, -1);
-        assert_se(sigprocmask(SIG_SETMASK, &mask, NULL) == 0);
-
         if ((signal_fd = signalfd(-1, &mask, SFD_NONBLOCK|SFD_CLOEXEC)) < 0) {
                 log_error("signalfd(): %m");
                 r = -errno;
@@ -495,6 +493,8 @@ finish:
         if (final[0])
                 unlink(final);
 
+        assert_se(sigprocmask(SIG_SETMASK, &oldmask, NULL) == 0);
+
         return r;
 }