X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;f=src%2Fanalyze%2Fsystemd-analyze.c;h=01bf55eda59971f9bf905b7a4b73433cad498323;hb=2b4ac8896bdc6cc5159088d7d208559d53caacf3;hp=1ea56c6896ff7242141e56885e22472ae3b4c0d1;hpb=2265fbf7e5614e9a9e5272937219181290f86e07;p=elogind.git
diff --git a/src/analyze/systemd-analyze.c b/src/analyze/systemd-analyze.c
index 1ea56c689..01bf55eda 100644
--- a/src/analyze/systemd-analyze.c
+++ b/src/analyze/systemd-analyze.c
@@ -3,7 +3,8 @@
/***
This file is part of systemd.
- Copyright 2010 Lennart Poettering
+ Copyright 2010-2013 Lennart Poettering
+ Copyright 2013 Simon Peeters
systemd is free software; you can redistribute it and/or modify it
under the terms of the GNU Lesser General Public License as published by
@@ -31,50 +32,59 @@
#include "build.h"
#include "util.h"
#include "strxcpyx.h"
+#include "fileio.h"
+
+#define SCALE_X (0.1 / 1000.0) /* pixels per us */
+#define SCALE_Y 20.0
#define compare(a, b) (((a) > (b))? 1 : (((b) > (a))? -1 : 0))
+
#define svg(...) printf(__VA_ARGS__)
-#define svg_bar(class, x1, x2, y) \
+
+#define svg_bar(class, x1, x2, y) \
svg(" \n", \
- (class), \
- scale_x * (x1), scale_y * (y), \
- scale_x * ((x2) - (x1)), scale_y - 1.0)
-#define svg_text(x, y, format, ...) do {\
- svg(" ", scale_x * (x) + 5.0, scale_y * (y) + 14.0); \
- svg(format, ## __VA_ARGS__); \
- svg("\n"); \
+ (class), \
+ SCALE_X * (x1), SCALE_Y * (y), \
+ SCALE_X * ((x2) - (x1)), SCALE_Y - 1.0)
+
+#define svg_text(b, x, y, format, ...) \
+ do { \
+ svg(" ", (b) ? "left" : "right", SCALE_X * (x) + (b ? 5.0 : -5.0), SCALE_Y * (y) + 14.0); \
+ svg(format, ## __VA_ARGS__); \
+ svg("\n"); \
} while(false)
static UnitFileScope arg_scope = UNIT_FILE_SYSTEM;
-
-double scale_x = 0.1; // pixels per ms
-double scale_y = 20.0;
+static enum dot {
+ DEP_ALL,
+ DEP_ORDER,
+ DEP_REQUIRE
+} arg_dot = DEP_ALL;
struct boot_times {
- uint64_t firmware_time;
- uint64_t loader_time;
- uint64_t kernel_time;
- uint64_t kernel_done_time;
- uint64_t initrd_time;
- uint64_t userspace_time;
- uint64_t finish_time;
+ usec_t firmware_time;
+ usec_t loader_time;
+ usec_t kernel_time;
+ usec_t kernel_done_time;
+ usec_t initrd_time;
+ usec_t userspace_time;
+ usec_t finish_time;
};
struct unit_times {
char *name;
- uint64_t ixt;
- uint64_t iet;
- uint64_t axt;
- uint64_t aet;
- uint64_t time;
+ usec_t ixt;
+ usec_t iet;
+ usec_t axt;
+ usec_t aet;
+ usec_t time;
};
-static int bus_get_uint64_property (DBusConnection *bus, const char *path, const char *interface, const char *property, uint64_t *val)
-{
+static int bus_get_uint64_property(DBusConnection *bus, const char *path, const char *interface, const char *property, uint64_t *val) {
_cleanup_dbus_message_unref_ DBusMessage *reply = NULL;
- int r;
DBusMessageIter iter, sub;
+ int r;
- r = bus_method_call_with_reply (
+ r = bus_method_call_with_reply(
bus,
"org.freedesktop.systemd1",
path,
@@ -106,34 +116,47 @@ static int bus_get_uint64_property (DBusConnection *bus, const char *path, const
return 0;
}
-static int compare_unit_time(const void *a, const void *b)
-{
+static int compare_unit_time(const void *a, const void *b) {
return compare(((struct unit_times *)b)->time,
((struct unit_times *)a)->time);
}
-static int compare_unit_start(const void *a, const void *b)
-{
+static int compare_unit_start(const void *a, const void *b) {
return compare(((struct unit_times *)a)->ixt,
((struct unit_times *)b)->ixt);
}
-static char *get_os_name(void)
-{
+static int get_os_name(char **_n) {
char *n = NULL;
+ int r;
- parse_env_file("/etc/os-release", NEWLINE, "PRETTY_NAME", &n, NULL);
- return n;
+ r = parse_env_file("/etc/os-release", NEWLINE, "PRETTY_NAME", &n, NULL);
+ if (r < 0)
+ return r;
+
+ if (!n)
+ return -ENOENT;
+
+ *_n = n;
+ return 0;
}
-static int acquire_time_data(DBusConnection *bus, struct unit_times **out)
-{
+static void free_unit_times(struct unit_times *t, unsigned n) {
+ struct unit_times *p;
+
+ for (p = t; p < t + n; p++)
+ free(p->name);
+
+ free(t);
+}
+
+static int acquire_time_data(DBusConnection *bus, struct unit_times **out) {
_cleanup_dbus_message_unref_ DBusMessage *reply = NULL;
DBusMessageIter iter, sub;
int r, c = 0, n_units = 0;
struct unit_times *unit_times = NULL;
- r = bus_method_call_with_reply (
+ r = bus_method_call_with_reply(
bus,
"org.freedesktop.systemd1",
"/org/freedesktop/systemd1",
@@ -142,7 +165,7 @@ static int acquire_time_data(DBusConnection *bus, struct unit_times **out)
&reply,
NULL,
DBUS_TYPE_INVALID);
- if (r)
+ if (r < 0)
goto fail;
if (!dbus_message_iter_init(reply, &iter) ||
@@ -185,6 +208,8 @@ static int acquire_time_data(DBusConnection *bus, struct unit_times **out)
if (r < 0)
goto fail;
+ assert_cc(sizeof(usec_t) == sizeof(uint64_t));
+
if (bus_get_uint64_property(bus, u.unit_path,
"org.freedesktop.systemd1.Unit",
"InactiveExitTimestampMonotonic",
@@ -205,11 +230,6 @@ static int acquire_time_data(DBusConnection *bus, struct unit_times **out)
goto fail;
}
- t->iet /= 1000;
- t->ixt /= 1000;
- t->aet /= 1000;
- t->axt /= 1000;
-
if (t->aet >= t->ixt)
t->time = t->aet - t->ixt;
else if (t->iet >= t->ixt)
@@ -230,19 +250,20 @@ static int acquire_time_data(DBusConnection *bus, struct unit_times **out)
*out = unit_times;
return c;
+
fail:
- for (; c >= 0; c--)
- free(unit_times[c].name);
- free(unit_times);
+ free_unit_times(unit_times, (unsigned) c);
return r;
}
-static struct boot_times *acquire_boot_times(DBusConnection *bus)
-{
+static int acquire_boot_times(DBusConnection *bus, struct boot_times **bt) {
static struct boot_times times;
static bool cached = false;
+
if (cached)
- return ×
+ goto finish;
+
+ assert_cc(sizeof(usec_t) == sizeof(uint64_t));
if (bus_get_uint64_property(bus,
"/org/freedesktop/systemd1",
@@ -274,112 +295,114 @@ static struct boot_times *acquire_boot_times(DBusConnection *bus)
"org.freedesktop.systemd1.Manager",
"FinishTimestampMonotonic",
×.finish_time) < 0)
- return NULL;
+ return -EIO;
- if (!times.finish_time) {
+ if (times.finish_time <= 0) {
log_error("Bootup is not yet finished. Please try again later.");
- return NULL;
+ return -EAGAIN;
}
- times.firmware_time /= 1000;
- times.loader_time /= 1000;
- times.initrd_time /= 1000;
- times.userspace_time /= 1000;
- times.finish_time /= 1000;
-
if (times.initrd_time)
times.kernel_done_time = times.initrd_time;
else
times.kernel_done_time = times.userspace_time;
cached = true;
- return ×
+
+finish:
+ *bt = ×
+ return 0;
}
-static char *pretty_boot_time(DBusConnection *bus)
-{
+static int pretty_boot_time(DBusConnection *bus, char **_buf) {
+ char ts[FORMAT_TIMESPAN_MAX];
struct boot_times *t;
- size_t size = 4096;
static char buf[4096];
- char *ptr = buf;
+ size_t size;
+ char *ptr;
+ int r;
+
+ r = acquire_boot_times(bus, &t);
+ if (r < 0)
+ return r;
- t = acquire_boot_times(bus);
- if (!t)
- return NULL;
+ ptr = buf;
+ size = sizeof(buf);
size = strpcpyf(&ptr, size, "Startup finished in ");
if (t->firmware_time)
- size = strpcpyf(&ptr, size, "%llums (firmware) + ", (unsigned long long)(t->firmware_time - t->loader_time));
+ size = strpcpyf(&ptr, size, "%s (firmware) + ", format_timespan(ts, sizeof(ts), t->firmware_time - t->loader_time));
if (t->loader_time)
- size = strpcpyf(&ptr, size, "%llums (loader) + ", (unsigned long long)t->loader_time);
+ size = strpcpyf(&ptr, size, "%s (loader) + ", format_timespan(ts, sizeof(ts), t->loader_time));
if (t->kernel_time)
- size = strpcpyf(&ptr, size, "%llums (kernel) + ", (unsigned long long)t->kernel_done_time);
+ size = strpcpyf(&ptr, size, "%s (kernel) + ", format_timespan(ts, sizeof(ts), t->kernel_done_time));
if (t->initrd_time > 0)
- size = strpcpyf(&ptr, size, "%llums (initrd) + ", (unsigned long long)(t->userspace_time - t->initrd_time));
+ size = strpcpyf(&ptr, size, "%s (initrd) + ", format_timespan(ts, sizeof(ts), t->userspace_time - t->initrd_time));
- size = strpcpyf(&ptr, size, "%llums (userspace) ", (unsigned long long)(t->finish_time - t->userspace_time));
+ size = strpcpyf(&ptr, size, "%s (userspace) ", format_timespan(ts, sizeof(ts), t->finish_time - t->userspace_time));
if (t->kernel_time > 0)
- size = strpcpyf(&ptr, size, "= %llums", (unsigned long long)(t->firmware_time + t->finish_time));
+ size = strpcpyf(&ptr, size, "= %s", format_timespan(ts, sizeof(ts), t->firmware_time + t->finish_time));
else
- size = strpcpyf(&ptr, size, "= %llums", (unsigned long long)(t->finish_time - t->userspace_time));
+ size = strpcpyf(&ptr, size, "= %s", format_timespan(ts, sizeof(ts), t->finish_time - t->userspace_time));
- return buf;
+ ptr = strdup(buf);
+ if (!ptr)
+ return log_oom();
+
+ *_buf = ptr;
+ return 0;
}
-static void svg_graph_box(int height, int64_t begin, int64_t end)
-{
+static void svg_graph_box(double height, double begin, double end) {
+ long long i;
+
/* outside box, fill */
svg("\n",
- scale_x * (end - begin), scale_y * height);
+ SCALE_X * (end - begin), SCALE_Y * height);
- for (int i = (begin / 100) * 100; i <= end; i+=100) {
+ for (i = ((long long) (begin / 100000)) * 100000; i <= end; i+=100000) {
/* lines for each second */
- if (i % 5000 == 0)
+ if (i % 5000000 == 0)
svg(" \n"
" %.01fs\n",
- scale_x * i, scale_x * i, scale_y * height, scale_x * i, -5.0, 0.001 * i);
- else if (i % 1000 == 0)
+ SCALE_X * i, SCALE_X * i, SCALE_Y * height, SCALE_X * i, -5.0, 0.000001 * i);
+ else if (i % 1000000 == 0)
svg(" \n"
" %.01fs\n",
- scale_x * i, scale_x * i, scale_y * height, scale_x * i, -5.0, 0.001 * i);
+ SCALE_X * i, SCALE_X * i, SCALE_Y * height, SCALE_X * i, -5.0, 0.000001 * i);
else
svg(" \n",
- scale_x * i, scale_x * i, scale_y * height);
+ SCALE_X * i, SCALE_X * i, SCALE_Y * height);
}
}
-static int analyze_plot(DBusConnection *bus)
-{
+static int analyze_plot(DBusConnection *bus) {
struct unit_times *times;
struct boot_times *boot;
struct utsname name;
int n, m = 1, y=0;
double width;
- char *osname;
- char *pretty_times;
+ _cleanup_free_ char *pretty_times = NULL, *osname = NULL;
+ struct unit_times *u;
- boot = acquire_boot_times(bus);
- if (!boot)
- return -EIO;
- pretty_times = pretty_boot_time(bus);
- if (!pretty_times)
- return -EIO;
+ n = acquire_boot_times(bus, &boot);
+ if (n < 0)
+ return n;
- osname = get_os_name();
+ n = pretty_boot_time(bus, &pretty_times);
+ if (n < 0)
+ return n;
- n = uname(&name);
- if (n < 0) {
- log_error("Cannot get system name: %m");
- return -errno;
- }
+ get_os_name(&osname);
+ assert_se(uname(&name) >= 0);
n = acquire_time_data(bus, ×);
- if (n<=0)
+ if (n <= 0)
return n;
qsort(times, n, sizeof(struct unit_times), compare_unit_start);
- width = scale_x * (boot->firmware_time + boot->finish_time);
+ width = SCALE_X * (boot->firmware_time + boot->finish_time);
if (width < 800.0)
width = 800.0;
@@ -395,15 +418,16 @@ static int analyze_plot(DBusConnection *bus)
if (boot->kernel_time)
m++;
- for (struct unit_times *u = times; u < times + n; u++) {
+ for (u = times; u < times + n; u++) {
double len;
+
if (u->ixt < boot->userspace_time ||
u->ixt > boot->finish_time) {
free(u->name);
u->name = NULL;
continue;
}
- len = ((boot->firmware_time + u->ixt) * scale_x)
+ len = ((boot->firmware_time + u->ixt) * SCALE_X)
+ (10.0 * strlen(u->name));
if (len > width)
width = len;
@@ -426,7 +450,7 @@ static int analyze_plot(DBusConnection *bus)
svg("");
+
+ free_unit_times(times, (unsigned) n);
+
return 0;
}
-static int analyze_blame(DBusConnection *bus)
-{
+static int analyze_blame(DBusConnection *bus) {
struct unit_times *times;
- int n = acquire_time_data(bus, ×);
- if (n<=0)
+ unsigned i;
+ int n;
+
+ n = acquire_time_data(bus, ×);
+ if (n <= 0)
return n;
qsort(times, n, sizeof(struct unit_times), compare_unit_time);
- for (int i = 0; i < n; i++) {
- if (times[i].time)
- printf("%6llums %s\n", (unsigned long long)times[i].time, times[i].name);
+ for (i = 0; i < (unsigned) n; i++) {
+ char ts[FORMAT_TIMESPAN_MAX];
+
+ if (times[i].time > 0)
+ printf("%16s %s\n", format_timespan(ts, sizeof(ts), times[i].time), times[i].name);
}
+
+ free_unit_times(times, (unsigned) n);
return 0;
}
-static int analyze_time(DBusConnection *bus)
-{
- char *buf;
- buf = pretty_boot_time(bus);
- if (!buf)
+static int analyze_time(DBusConnection *bus) {
+ _cleanup_free_ char *buf = NULL;
+ int r;
+
+ r = pretty_boot_time(bus, &buf);
+ if (r < 0)
+ return r;
+
+ puts(buf);
+ return 0;
+}
+
+static int graph_one_property(const char *name, const char *prop, DBusMessageIter *iter) {
+
+ static const char * const colors[] = {
+ "Requires", "[color=\"black\"]",
+ "RequiresOverridable", "[color=\"black\"]",
+ "Requisite", "[color=\"darkblue\"]",
+ "RequisiteOverridable", "[color=\"darkblue\"]",
+ "Wants", "[color=\"grey66\"]",
+ "Conflicts", "[color=\"red\"]",
+ "ConflictedBy", "[color=\"red\"]",
+ "After", "[color=\"green\"]"
+ };
+
+ const char *c = NULL;
+ unsigned i;
+
+ assert(name);
+ assert(prop);
+ assert(iter);
+
+ for (i = 0; i < ELEMENTSOF(colors); i += 2)
+ if (streq(colors[i], prop)) {
+ c = colors[i+1];
+ break;
+ }
+
+ if (!c)
+ return 0;
+
+ if (arg_dot != DEP_ALL)
+ if ((arg_dot == DEP_ORDER) != streq(prop, "After"))
+ return 0;
+
+ if (dbus_message_iter_get_arg_type(iter) == DBUS_TYPE_ARRAY &&
+ dbus_message_iter_get_element_type(iter) == DBUS_TYPE_STRING) {
+ DBusMessageIter sub;
+
+ dbus_message_iter_recurse(iter, &sub);
+
+ for (dbus_message_iter_recurse(iter, &sub);
+ dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_INVALID;
+ dbus_message_iter_next(&sub)) {
+ const char *s;
+
+ assert(dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_STRING);
+ dbus_message_iter_get_basic(&sub, &s);
+ printf("\t\"%s\"->\"%s\" %s;\n", name, s, c);
+ }
+ }
+
+ return 0;
+}
+
+static int graph_one(DBusConnection *bus, const struct unit_info *u) {
+ _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;
+ const char *interface = "org.freedesktop.systemd1.Unit";
+ int r;
+ DBusMessageIter iter, sub, sub2, sub3;
+
+ assert(bus);
+ assert(u);
+
+ r = bus_method_call_with_reply(
+ bus,
+ "org.freedesktop.systemd1",
+ u->unit_path,
+ "org.freedesktop.DBus.Properties",
+ "GetAll",
+ &reply,
+ NULL,
+ DBUS_TYPE_STRING, &interface,
+ DBUS_TYPE_INVALID);
+ if (r < 0)
+ return r;
+
+ if (!dbus_message_iter_init(reply, &iter) ||
+ dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_ARRAY ||
+ dbus_message_iter_get_element_type(&iter) != DBUS_TYPE_DICT_ENTRY) {
+ log_error("Failed to parse reply.");
+ return -EIO;
+ }
+
+ for (dbus_message_iter_recurse(&iter, &sub);
+ dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_INVALID;
+ dbus_message_iter_next(&sub)) {
+ const char *prop;
+
+ assert(dbus_message_iter_get_arg_type(&sub) == DBUS_TYPE_DICT_ENTRY);
+ dbus_message_iter_recurse(&sub, &sub2);
+
+ if (bus_iter_get_basic_and_next(&sub2, DBUS_TYPE_STRING, &prop, true) < 0 ||
+ dbus_message_iter_get_arg_type(&sub2) != DBUS_TYPE_VARIANT) {
+ log_error("Failed to parse reply.");
+ return -EIO;
+ }
+
+ dbus_message_iter_recurse(&sub2, &sub3);
+ r = graph_one_property(u->id, prop, &sub3);
+ if (r < 0)
+ return r;
+ }
+
+ return 0;
+}
+
+static int dot(DBusConnection *bus) {
+ _cleanup_dbus_message_unref_ DBusMessage *reply = NULL;
+ DBusMessageIter iter, sub;
+ int r;
+
+ r = bus_method_call_with_reply(
+ bus,
+ "org.freedesktop.systemd1",
+ "/org/freedesktop/systemd1",
+ "org.freedesktop.systemd1.Manager",
+ "ListUnits",
+ &reply,
+ NULL,
+ DBUS_TYPE_INVALID);
+ if (r < 0)
+ return r;
+
+ if (!dbus_message_iter_init(reply, &iter) ||
+ dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_ARRAY ||
+ dbus_message_iter_get_element_type(&iter) != DBUS_TYPE_STRUCT) {
+ log_error("Failed to parse reply.");
return -EIO;
- if (puts(buf) == EOF)
- return -errno;
+ }
+
+ printf("digraph systemd {\n");
+
+ for (dbus_message_iter_recurse(&iter, &sub);
+ dbus_message_iter_get_arg_type(&sub) != DBUS_TYPE_INVALID;
+ dbus_message_iter_next(&sub)) {
+ struct unit_info u;
+
+ r = bus_parse_unit_info(&sub, &u);
+ if (r < 0)
+ return -EIO;
+
+ r = graph_one(bus, &u);
+ if (r < 0)
+ return r;
+ }
+
+ printf("}\n");
+
+ log_info(" Color legend: black = Requires\n"
+ " dark blue = Requisite\n"
+ " dark grey = Wants\n"
+ " red = Conflicts\n"
+ " green = After\n");
+
+ if (on_tty())
+ log_notice("-- You probably want to process this output with graphviz' dot tool.\n"
+ "-- Try a shell pipeline like 'systemd-analyze dot | dot -Tsvg > systemd.svg'!\n");
+
return 0;
}
@@ -539,11 +745,14 @@ static void analyze_help(void)
" -h --help Show this help\n"
" --version Show package version\n"
" --system Connect to system manager\n"
- " --user Connect to user service manager\n\n"
+ " --user Connect to user service manager\n"
+ " --order When generating a dependency graph, show only order\n"
+ " --require When generating a dependency graph, show only requirement\n\n"
"Commands:\n"
- " time print time spent in the kernel before reaching userspace\n"
- " blame print list of running units ordered by time to init\n"
- " plot output SVG graphic showing service initialization\n\n",
+ " time Print time spent in the kernel before reaching userspace\n"
+ " blame Print list of running units ordered by time to init\n"
+ " plot Output SVG graphic showing service initialization\n"
+ " dot Dump dependency graph (in dot(1) format)\n\n",
program_invocation_short_name);
}
@@ -551,6 +760,8 @@ static int parse_argv(int argc, char *argv[])
{
enum {
ARG_VERSION = 0x100,
+ ARG_ORDER,
+ ARG_REQUIRE,
ARG_USER,
ARG_SYSTEM
};
@@ -558,6 +769,8 @@ static int parse_argv(int argc, char *argv[])
static const struct option options[] = {
{ "help", no_argument, NULL, 'h' },
{ "version", no_argument, NULL, ARG_VERSION },
+ { "order", no_argument, NULL, ARG_ORDER },
+ { "require", no_argument, NULL, ARG_REQUIRE },
{ "user", no_argument, NULL, ARG_USER },
{ "system", no_argument, NULL, ARG_SYSTEM },
{ NULL, 0, NULL, 0 }
@@ -566,26 +779,41 @@ static int parse_argv(int argc, char *argv[])
assert(argc >= 0);
assert(argv);
- while (true) {
+ for (;;) {
switch (getopt_long(argc, argv, "h", options, NULL)) {
- case 'h':
- analyze_help();
- return 0;
- case ARG_VERSION:
- puts(PACKAGE_STRING "\n" SYSTEMD_FEATURES);
- return 0;
- case ARG_USER:
- arg_scope = UNIT_FILE_USER;
- break;
- case ARG_SYSTEM:
- arg_scope = UNIT_FILE_SYSTEM;
- break;
- case -1:
- return 1;
- case '?':
- return -EINVAL;
- default:
- assert_not_reached("Unhandled option");
+
+ case 'h':
+ analyze_help();
+ return 0;
+
+ case ARG_VERSION:
+ puts(PACKAGE_STRING "\n" SYSTEMD_FEATURES);
+ return 0;
+
+ case ARG_USER:
+ arg_scope = UNIT_FILE_USER;
+ break;
+
+ case ARG_SYSTEM:
+ arg_scope = UNIT_FILE_SYSTEM;
+ break;
+
+ case ARG_ORDER:
+ arg_dot = DEP_ORDER;
+ break;
+
+ case ARG_REQUIRE:
+ arg_dot = DEP_REQUIRE;
+ break;
+
+ case -1:
+ return 1;
+
+ case '?':
+ return -EINVAL;
+
+ default:
+ assert_not_reached("Unhandled option");
}
}
}
@@ -595,18 +823,19 @@ int main(int argc, char *argv[]) {
DBusConnection *bus = NULL;
setlocale(LC_ALL, "");
+ setlocale(LC_NUMERIC, "C"); /* we want to format/parse floats in C style */
log_parse_environment();
log_open();
r = parse_argv(argc, argv);
- if (r == 0)
- return 0;
if (r < 0)
- return 1;
+ return EXIT_FAILURE;
+ else if (r <= 0)
+ return EXIT_SUCCESS;
bus = dbus_bus_get(arg_scope == UNIT_FILE_SYSTEM ? DBUS_BUS_SYSTEM : DBUS_BUS_SESSION, NULL);
if (!bus)
- return 1;
+ return EXIT_FAILURE;
if (!argv[optind] || streq(argv[optind], "time"))
r = analyze_time(bus);
@@ -614,11 +843,12 @@ int main(int argc, char *argv[]) {
r = analyze_blame(bus);
else if (streq(argv[optind], "plot"))
r = analyze_plot(bus);
+ else if (streq(argv[optind], "dot"))
+ r = dot(bus);
else
log_error("Unknown operation '%s'.", argv[optind]);
dbus_connection_unref(bus);
- if (r)
- return 1;
- return 0;
+
+ return r < 0 ? EXIT_FAILURE : EXIT_SUCCESS;
}