X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;ds=sidebyside;f=src%2Fshared%2Fgenerator.c;h=569b25bb7c882ded2e3863ec6b7fd4a0d2826f98;hb=2eec67acbb00593e414549a7e5b35eb7dd776b1b;hp=61103031db23b31df7a5d7c79dc98d11608a3d4a;hpb=6db615c17ee7a434f9e0c40d67a1f833d8f3cc9d;p=elogind.git diff --git a/src/shared/generator.c b/src/shared/generator.c index 61103031d..569b25bb7 100644 --- a/src/shared/generator.c +++ b/src/shared/generator.c @@ -26,6 +26,9 @@ #include "mkdir.h" #include "unit-name.h" #include "generator.h" +#include "path-util.h" +#include "fstab-util.h" +#include "dropin.h" int generator_write_fsck_deps( FILE *f, @@ -45,29 +48,24 @@ int generator_write_fsck_deps( } if (!isempty(fstype) && !streq(fstype, "auto")) { - const char *checker; int r; - - checker = strappenda("/sbin/fsck.", fstype); - r = access(checker, X_OK); - if (r < 0) { - log_warning("Checking was requested for %s, but %s cannot be used: %m", what, checker); - + r = fsck_exists(fstype); + if (r == -ENOENT) { /* treat missing check as essentially OK */ - return errno == ENOENT ? 0 : -errno; - } + log_debug_errno(r, "Checking was requested for %s, but fsck.%s does not exist: %m", what, fstype); + return 0; + } else if (r < 0) + return log_warning_errno(r, "Checking was requested for %s, but fsck.%s cannot be used: %m", what, fstype); } if (streq(where, "/")) { char *lnk; - lnk = strappenda(dest, "/" SPECIAL_LOCAL_FS_TARGET ".wants/systemd-fsck-root.service"); + lnk = strjoina(dest, "/" SPECIAL_LOCAL_FS_TARGET ".wants/systemd-fsck-root.service"); mkdir_parents(lnk, 0755); - if (symlink(SYSTEM_DATA_UNIT_PATH "/systemd-fsck-root.service", lnk) < 0) { - log_error("Failed to create symlink %s: %m", lnk); - return -errno; - } + if (symlink(SYSTEM_DATA_UNIT_PATH "/systemd-fsck-root.service", lnk) < 0) + return log_error_errno(errno, "Failed to create symlink %s: %m", lnk); } else { _cleanup_free_ char *fsck = NULL; @@ -85,3 +83,42 @@ int generator_write_fsck_deps( return 0; } + +int generator_write_timeouts(const char *dir, const char *what, const char *where, + const char *opts, char **filtered) { + + /* Allow configuration how long we wait for a device that + * backs a mount point to show up. This is useful to support + * endless device timeouts for devices that show up only after + * user input, like crypto devices. */ + + _cleanup_free_ char *node = NULL, *unit = NULL, *timeout = NULL; + usec_t u; + int r; + + r = fstab_filter_options(opts, "comment=systemd.device-timeout\0" "x-systemd.device-timeout\0", + NULL, &timeout, filtered); + if (r <= 0) + return r; + + r = parse_sec(timeout, &u); + if (r < 0) { + log_warning("Failed to parse timeout for %s, ignoring: %s", + where, timeout); + return 0; + } + + node = fstab_node_to_udev_node(what); + if (!node) + return log_oom(); + + unit = unit_name_from_path(node, ".device"); + if (!unit) + return log_oom(); + + return write_drop_in_format(dir, unit, 50, "device-timeout", + "# Automatically generated by %s\n\n" + "[Unit]\nJobTimeoutSec=" USEC_FMT, + program_invocation_short_name, + u / USEC_PER_SEC); +}