X-Git-Url: http://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=blobdiff_plain;ds=sidebyside;f=src%2Flibsystemd-bus%2Fbus-objects.c;h=aa0be37a9de8061d918e9bbb258c651cd0d252f2;hb=bd037038840501916aaf8b65a0c3a6e7357d3c74;hp=8d953762be9939839ff2a9450c6c940b4114d57f;hpb=77a874a3fb6f65d2308c20827f005c43bb075752;p=elogind.git diff --git a/src/libsystemd-bus/bus-objects.c b/src/libsystemd-bus/bus-objects.c index 8d953762b..aa0be37a9 100644 --- a/src/libsystemd-bus/bus-objects.c +++ b/src/libsystemd-bus/bus-objects.c @@ -27,6 +27,7 @@ #include "bus-signature.h" #include "bus-introspect.h" #include "bus-objects.h" +#include "bus-util.h" static int node_vtable_get_userdata( sd_bus *bus, @@ -77,12 +78,19 @@ static int vtable_property_get_userdata( r = node_vtable_get_userdata(bus, path, p->parent, &u); if (r <= 0) return r; + if (bus->nodes_modified) + return 0; *userdata = vtable_property_convert_userdata(p->vtable, u); return 1; } -static int add_enumerated_to_set(sd_bus *bus, const char *prefix, struct node_enumerator *first, Set *s) { +static int add_enumerated_to_set( + sd_bus *bus, + const char *prefix, + struct node_enumerator *first, + Set *s) { + struct node_enumerator *c; int r; @@ -93,6 +101,9 @@ static int add_enumerated_to_set(sd_bus *bus, const char *prefix, struct node_en LIST_FOREACH(enumerators, c, first) { char **children = NULL, **k; + if (bus->nodes_modified) + return 0; + r = c->callback(bus, prefix, &children, c->userdata); if (r < 0) return r; @@ -120,7 +131,12 @@ static int add_enumerated_to_set(sd_bus *bus, const char *prefix, struct node_en return 0; } -static int add_subtree_to_set(sd_bus *bus, const char *prefix, struct node *n, Set *s) { +static int add_subtree_to_set( + sd_bus *bus, + const char *prefix, + struct node *n, + Set *s) { + struct node *i; int r; @@ -132,6 +148,8 @@ static int add_subtree_to_set(sd_bus *bus, const char *prefix, struct node *n, S r = add_enumerated_to_set(bus, prefix, n->enumerators, s); if (r < 0) return r; + if (bus->nodes_modified) + return 0; LIST_FOREACH(siblings, i, n->child) { char *t; @@ -147,16 +165,24 @@ static int add_subtree_to_set(sd_bus *bus, const char *prefix, struct node *n, S r = add_subtree_to_set(bus, prefix, i, s); if (r < 0) return r; + if (bus->nodes_modified) + return 0; } return 0; } -static int get_child_nodes(sd_bus *bus, const char *prefix, struct node *n, Set **_s) { +static int get_child_nodes( + sd_bus *bus, + const char *prefix, + struct node *n, + Set **_s) { + Set *s = NULL; int r; assert(bus); + assert(prefix); assert(n); assert(_s); @@ -189,6 +215,9 @@ static int node_callbacks_run( assert(found_object); LIST_FOREACH(callbacks, c, first) { + if (bus->nodes_modified) + return 0; + if (require_fallback && !c->is_fallback) continue; @@ -197,6 +226,8 @@ static int node_callbacks_run( if (c->last_iteration == bus->iteration_counter) continue; + c->last_iteration = bus->iteration_counter; + r = sd_bus_message_rewind(m, true); if (r < 0) return r; @@ -231,20 +262,27 @@ static int method_callbacks_run( r = node_vtable_get_userdata(bus, m->path, c->parent, &u); if (r <= 0) return r; + if (bus->nodes_modified) + return 0; *found_object = true; + if (c->last_iteration == bus->iteration_counter) + return 0; + + c->last_iteration = bus->iteration_counter; + r = sd_bus_message_rewind(m, true); if (r < 0) return r; - r = sd_bus_message_get_signature(m, true, &signature); - if (r < 0) - return r; + signature = sd_bus_message_get_signature(m, true); + if (!signature) + return -EINVAL; if (!streq(strempty(c->vtable->x.method.signature), signature)) { r = sd_bus_reply_method_errorf(bus, m, - "org.freedesktop.DBus.Error.InvalidArgs", + SD_BUS_ERROR_INVALID_ARGS, "Invalid arguments '%s' to call %s:%s, expecting '%s'.", signature, c->interface, c->member, strempty(c->vtable->x.method.signature)); if (r < 0) @@ -275,10 +313,14 @@ static int invoke_property_get( void *userdata) { int r; - void *p; + const void *p; assert(bus); assert(v); + assert(path); + assert(interface); + assert(property); + assert(m); if (v->x.property.get) return v->x.property.get(bus, path, interface, property, m, error, userdata); @@ -291,9 +333,13 @@ static int invoke_property_get( switch (v->x.property.signature[0]) { case SD_BUS_TYPE_STRING: - case SD_BUS_TYPE_OBJECT_PATH: case SD_BUS_TYPE_SIGNATURE: + p = strempty(*(char**) userdata); + break; + + case SD_BUS_TYPE_OBJECT_PATH: p = *(char**) userdata; + assert(p); break; default: @@ -322,6 +368,10 @@ static int invoke_property_set( assert(bus); assert(v); + assert(path); + assert(interface); + assert(property); + assert(value); if (v->x.property.set) return v->x.property.set(bus, path, interface, property, value, error, userdata); @@ -379,6 +429,7 @@ static int property_get_set_callbacks_run( assert(bus); assert(m); + assert(c); assert(found_object); if (require_fallback && !c->parent->is_fallback) @@ -387,6 +438,8 @@ static int property_get_set_callbacks_run( r = vtable_property_get_userdata(bus, m->path, c, &u); if (r <= 0) return r; + if (bus->nodes_modified) + return 0; *found_object = true; @@ -394,9 +447,14 @@ static int property_get_set_callbacks_run( if (r < 0) return r; - c->last_iteration = bus->iteration_counter; - if (is_get) { + /* Note that we do not protect against reexecution + * here (using the last_iteration check, see below), + * should the node tree have changed and we got called + * again. We assume that property Get() calls are + * ultimately without side-effects or if they aren't + * then at least idempotent. */ + r = sd_bus_message_open_container(reply, 'v', c->vtable->x.property.signature); if (r < 0) return r; @@ -413,14 +471,26 @@ static int property_get_set_callbacks_run( return 1; } + if (bus->nodes_modified) + return 0; + r = sd_bus_message_close_container(reply); if (r < 0) return r; } else { if (c->vtable->type != _SD_BUS_VTABLE_WRITABLE_PROPERTY) - sd_bus_error_setf(&error, "org.freedesktop.DBus.Error.PropertyReadOnly", "Property '%s' is not writable.", c->member); + sd_bus_error_setf(&error, SD_BUS_ERROR_PROPERTY_READ_ONLY, "Property '%s' is not writable.", c->member); else { + /* Avoid that we call the set routine more + * than once if the processing of this message + * got restarted because the node tree + * changed. */ + if (c->last_iteration == bus->iteration_counter) + return 0; + + c->last_iteration = bus->iteration_counter; + r = sd_bus_message_enter_container(m, 'v', c->vtable->x.property.signature); if (r < 0) return r; @@ -438,6 +508,9 @@ static int property_get_set_callbacks_run( return 1; } + if (bus->nodes_modified) + return 0; + r = sd_bus_message_exit_container(m); if (r < 0) return r; @@ -463,6 +536,7 @@ static int vtable_append_all_properties( assert(bus); assert(reply); + assert(path); assert(c); for (v = c->vtable+1; v->type != _SD_BUS_VTABLE_END; v++) { @@ -473,7 +547,7 @@ static int vtable_append_all_properties( if (r < 0) return r; - r = sd_bus_message_append(reply, "s", c->interface); + r = sd_bus_message_append(reply, "s", v->x.property.member); if (r < 0) return r; @@ -484,9 +558,10 @@ static int vtable_append_all_properties( r = invoke_property_get(bus, v, path, c->interface, v->x.property.member, reply, error, vtable_property_convert_userdata(v, userdata)); if (r < 0) return r; - if (sd_bus_error_is_set(error)) return 0; + if (bus->nodes_modified) + return 0; r = sd_bus_message_close_container(reply); if (r < 0) @@ -510,7 +585,7 @@ static int property_get_all_callbacks_run( _cleanup_bus_message_unref_ sd_bus_message *reply = NULL; struct node_vtable *c; - bool found_interface = false; + bool found_interface; int r; assert(bus); @@ -525,6 +600,11 @@ static int property_get_all_callbacks_run( if (r < 0) return r; + found_interface = + streq(iface, "org.freedesktop.DBus.Properties") || + streq(iface, "org.freedesktop.DBus.Peer") || + streq(iface, "org.freedesktop.DBus.Introspectable"); + LIST_FOREACH(vtables, c, first) { _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; void *u; @@ -535,6 +615,8 @@ static int property_get_all_callbacks_run( r = node_vtable_get_userdata(bus, m->path, c, &u); if (r < 0) return r; + if (bus->nodes_modified) + return 0; if (r == 0) continue; @@ -544,8 +626,6 @@ static int property_get_all_callbacks_run( continue; found_interface = true; - c->last_iteration = bus->iteration_counter; - r = vtable_append_all_properties(bus, reply, m->path, c, u, &error); if (r < 0) return r; @@ -557,12 +637,14 @@ static int property_get_all_callbacks_run( return 1; } + if (bus->nodes_modified) + return 0; } if (!found_interface) { r = sd_bus_reply_method_errorf( bus, m, - "org.freedesktop.DBus.Error.UnknownInterface", + SD_BUS_ERROR_UNKNOWN_INTERFACE, "Unknown interface '%s'.", iface); if (r < 0) return r; @@ -583,6 +665,7 @@ static int property_get_all_callbacks_run( static bool bus_node_with_object_manager(sd_bus *bus, struct node *n) { assert(bus); + assert(n); if (n->object_manager) return true; @@ -593,12 +676,18 @@ static bool bus_node_with_object_manager(sd_bus *bus, struct node *n) { return false; } -static bool bus_node_exists(sd_bus *bus, struct node *n, const char *path, bool require_fallback) { +static bool bus_node_exists( + sd_bus *bus, + struct node *n, + const char *path, + bool require_fallback) { + struct node_vtable *c; struct node_callback *k; assert(bus); assert(n); + assert(path); /* Tests if there's anything attached directly to this node * for the specified path */ @@ -617,6 +706,8 @@ static bool bus_node_exists(sd_bus *bus, struct node *n, const char *path, bool if (node_vtable_get_userdata(bus, path, c, NULL) > 0) return true; + if (bus->nodes_modified) + return false; } return !require_fallback && (n->enumerators || n->object_manager); @@ -644,6 +735,8 @@ static int process_introspect( r = get_child_nodes(bus, m->path, n, &s); if (r < 0) return r; + if (bus->nodes_modified) + return 0; r = introspect_begin(&intro); if (r < 0) @@ -662,6 +755,8 @@ static int process_introspect( r = node_vtable_get_userdata(bus, m->path, c, NULL); if (r < 0) return r; + if (bus->nodes_modified) + return 0; if (r == 0) continue; @@ -678,7 +773,8 @@ static int process_introspect( r = bus_node_exists(bus, n, m->path, require_fallback); if (r < 0) return r; - + if (bus->nodes_modified) + return 0; if (r == 0) goto finish; } @@ -709,9 +805,9 @@ static int object_manager_serialize_vtable( sd_bus_message *reply, const char *path, struct node_vtable *c, - sd_bus_error *error) { + sd_bus_error *error, + void *userdata) { - void *u; int r; assert(bus); @@ -720,10 +816,6 @@ static int object_manager_serialize_vtable( assert(c); assert(error); - r = node_vtable_get_userdata(bus, path, c, &u); - if (r <= 0) - return r; - r = sd_bus_message_open_container(reply, 'e', "sa{sv}"); if (r < 0) return r; @@ -736,9 +828,11 @@ static int object_manager_serialize_vtable( if (r < 0) return r; - r = vtable_append_all_properties(bus, reply, path, c, u, error); + r = vtable_append_all_properties(bus, reply, path, c, userdata, error); if (r < 0) return r; + if (bus->nodes_modified) + return 0; r = sd_bus_message_close_container(reply); if (r < 0) @@ -761,6 +855,7 @@ static int object_manager_serialize_path( struct node_vtable *i; struct node *n; + bool found_something = false; int r; assert(bus); @@ -773,37 +868,54 @@ static int object_manager_serialize_path( if (!n) return 0; - r = sd_bus_message_open_container(reply, 'e', "oa{sa{sv}}"); - if (r < 0) - return r; - - r = sd_bus_message_append(reply, "o", path); - if (r < 0) - return r; - - r = sd_bus_message_open_container(reply, 'a', "{sa{sv}}"); - if (r < 0) - return r; - LIST_FOREACH(vtables, i, n->vtables) { + void *u; if (require_fallback && !i->is_fallback) continue; - r = object_manager_serialize_vtable(bus, reply, path, i, error); + r = node_vtable_get_userdata(bus, path, i, &u); + if (r < 0) + return r; + if (bus->nodes_modified) + return 0; + if (r == 0) + continue; + + if (!found_something) { + r = sd_bus_message_open_container(reply, 'e', "oa{sa{sv}}"); + if (r < 0) + return r; + + r = sd_bus_message_append(reply, "o", path); + if (r < 0) + return r; + + r = sd_bus_message_open_container(reply, 'a', "{sa{sv}}"); + if (r < 0) + return r; + + found_something = true; + } + + r = object_manager_serialize_vtable(bus, reply, path, i, error, u); if (r < 0) return r; if (sd_bus_error_is_set(error)) return 0; + if (bus->nodes_modified) + return 0; } - r = sd_bus_message_close_container(reply); - if (r < 0) - return r; + if (found_something) { + r = sd_bus_message_close_container(reply); + if (r < 0) + return r; - r = sd_bus_message_close_container(reply); - if (r < 0) - return r; + r = sd_bus_message_close_container(reply); + if (r < 0) + return r; + } return 1; } @@ -814,7 +926,7 @@ static int object_manager_serialize_path_and_fallbacks( const char *path, sd_bus_error *error) { - size_t pl; + char *prefix; int r; assert(bus); @@ -828,29 +940,19 @@ static int object_manager_serialize_path_and_fallbacks( return r; if (sd_bus_error_is_set(error)) return 0; + if (bus->nodes_modified) + return 0; /* Second, add fallback vtables registered for any of the prefixes */ - pl = strlen(path); - if (pl > 1) { - char p[pl + 1]; - strcpy(p, path); - - for (;;) { - char *e; - - e = strrchr(p, '/'); - if (e == p || !e) - break; - - *e = 0; - - r = object_manager_serialize_path(bus, reply, p, path, true, error); - if (r < 0) - return r; - - if (sd_bus_error_is_set(error)) - return 0; - } + prefix = alloca(strlen(path) + 1); + OBJECT_PATH_FOREACH_PREFIX(prefix, path) { + r = object_manager_serialize_path(bus, reply, prefix, path, true, error); + if (r < 0) + return r; + if (sd_bus_error_is_set(error)) + return 0; + if (bus->nodes_modified) + return 0; } return 0; @@ -879,6 +981,8 @@ static int process_get_managed_objects( r = get_child_nodes(bus, m->path, n, &s); if (r < 0) return r; + if (bus->nodes_modified) + return 0; r = sd_bus_message_new_method_return(bus, m, &reply); if (r < 0) @@ -930,6 +1034,9 @@ static int process_get_managed_objects( return 1; } + + if (bus->nodes_modified) + return 0; } } @@ -968,6 +1075,8 @@ static int object_find_and_run( r = node_callbacks_run(bus, m, n->callbacks, require_fallback, found_object); if (r != 0) return r; + if (bus->nodes_modified) + return 0; if (!m->interface || !m->member) return 0; @@ -982,6 +1091,8 @@ static int object_find_and_run( r = method_callbacks_run(bus, m, v, require_fallback, found_object); if (r != 0) return r; + if (bus->nodes_modified) + return 0; } /* Then, look for a known property */ @@ -1041,11 +1152,13 @@ static int object_find_and_run( return r; } + if (bus->nodes_modified) + return 0; + if (!*found_object) { r = bus_node_exists(bus, n, m->path, require_fallback); if (r < 0) return r; - if (r > 0) *found_object = true; } @@ -1061,7 +1174,7 @@ int bus_process_object(sd_bus *bus, sd_bus_message *m) { assert(bus); assert(m); - if (m->header->type != SD_BUS_MESSAGE_TYPE_METHOD_CALL) + if (m->header->type != SD_BUS_MESSAGE_METHOD_CALL) return 0; if (!m->path) @@ -1072,7 +1185,7 @@ int bus_process_object(sd_bus *bus, sd_bus_message *m) { pl = strlen(m->path); do { - char p[pl+1]; + char prefix[pl+1]; bus->nodes_modified = false; @@ -1081,24 +1194,12 @@ int bus_process_object(sd_bus *bus, sd_bus_message *m) { return r; /* Look for fallback prefixes */ - strcpy(p, m->path); - for (;;) { - char *e; - - if (streq(p, "/")) - break; + OBJECT_PATH_FOREACH_PREFIX(prefix, m->path) { if (bus->nodes_modified) break; - e = strrchr(p, '/'); - assert(e); - if (e == p) - *(e+1) = 0; - else - *e = 0; - - r = object_find_and_run(bus, m, p, true, &found_object); + r = object_find_and_run(bus, m, prefix, true, &found_object); if (r != 0) return r; } @@ -1112,12 +1213,12 @@ int bus_process_object(sd_bus *bus, sd_bus_message *m) { sd_bus_message_is_method_call(m, "org.freedesktop.DBus.Properties", "Set")) r = sd_bus_reply_method_errorf( bus, m, - "org.freedesktop.DBus.Error.UnknownProperty", + SD_BUS_ERROR_UNKNOWN_PROPERTY, "Unknown property or interface."); else r = sd_bus_reply_method_errorf( bus, m, - "org.freedesktop.DBus.Error.UnknownMethod", + SD_BUS_ERROR_UNKNOWN_METHOD, "Unknown method '%s' or interface '%s'.", m->member, m->interface); if (r < 0) @@ -1178,7 +1279,7 @@ static struct node *bus_node_allocate(sd_bus *bus, const char *path) { } if (parent) - LIST_PREPEND(struct node, siblings, parent->child, n); + LIST_PREPEND(siblings, parent->child, n); return n; } @@ -1199,7 +1300,7 @@ static void bus_node_gc(sd_bus *b, struct node *n) { assert(hashmap_remove(b->nodes, n->path) == n); if (n->parent) - LIST_REMOVE(struct node, siblings, n->parent->child, n); + LIST_REMOVE(siblings, n->parent->child, n); free(n->path); bus_node_gc(b, n->parent); @@ -1207,7 +1308,7 @@ static void bus_node_gc(sd_bus *b, struct node *n) { } static int bus_add_object( - sd_bus *b, + sd_bus *bus, bool fallback, const char *path, sd_bus_message_handler_t callback, @@ -1217,16 +1318,12 @@ static int bus_add_object( struct node *n; int r; - if (!b) - return -EINVAL; - if (!object_path_is_valid(path)) - return -EINVAL; - if (!callback) - return -EINVAL; - if (bus_pid_changed(b)) - return -ECHILD; + assert_return(bus, -EINVAL); + assert_return(object_path_is_valid(path), -EINVAL); + assert_return(callback, -EINVAL); + assert_return(!bus_pid_changed(bus), -ECHILD); - n = bus_node_allocate(b, path); + n = bus_node_allocate(bus, path); if (!n) return -ENOMEM; @@ -1241,12 +1338,14 @@ static int bus_add_object( c->userdata = userdata; c->is_fallback = fallback; - LIST_PREPEND(struct node_callback, callbacks, n->callbacks, c); + LIST_PREPEND(callbacks, n->callbacks, c); + bus->nodes_modified = true; + return 0; fail: free(c); - bus_node_gc(b, n); + bus_node_gc(bus, n); return r; } @@ -1260,14 +1359,10 @@ static int bus_remove_object( struct node_callback *c; struct node *n; - if (!bus) - return -EINVAL; - if (!object_path_is_valid(path)) - return -EINVAL; - if (!callback) - return -EINVAL; - if (bus_pid_changed(bus)) - return -ECHILD; + assert_return(bus, -EINVAL); + assert_return(object_path_is_valid(path), -EINVAL); + assert_return(callback, -EINVAL); + assert_return(!bus_pid_changed(bus), -ECHILD); n = hashmap_get(bus->nodes, path); if (!n) @@ -1279,10 +1374,11 @@ static int bus_remove_object( if (!c) return 0; - LIST_REMOVE(struct node_callback, callbacks, n->callbacks, c); + LIST_REMOVE(callbacks, n->callbacks, c); free(c); bus_node_gc(bus, n); + bus->nodes_modified = true; return 1; } @@ -1350,6 +1446,8 @@ static void free_node_vtable(sd_bus *bus, struct node_vtable *w) { static unsigned vtable_member_hash_func(const void *a) { const struct vtable_member *m = a; + assert(m); + return string_hash_func(m->path) ^ string_hash_func(m->interface) ^ @@ -1360,6 +1458,9 @@ static int vtable_member_compare_func(const void *a, const void *b) { const struct vtable_member *x = a, *y = b; int r; + assert(x); + assert(y); + r = strcmp(x->path, y->path); if (r != 0) return r; @@ -1385,16 +1486,13 @@ static int add_object_vtable_internal( struct node *n; int r; - if (!bus) - return -EINVAL; - if (!object_path_is_valid(path)) - return -EINVAL; - if (!interface_name_is_valid(interface)) - return -EINVAL; - if (!vtable || vtable[0].type != _SD_BUS_VTABLE_START || vtable[0].x.start.element_size != sizeof(struct sd_bus_vtable)) - return -EINVAL; - if (bus_pid_changed(bus)) - return -ECHILD; + assert_return(bus, -EINVAL); + assert_return(object_path_is_valid(path), -EINVAL); + assert_return(interface_name_is_valid(interface), -EINVAL); + assert_return(vtable, -EINVAL); + assert_return(vtable[0].type == _SD_BUS_VTABLE_START, -EINVAL); + assert_return(vtable[0].x.start.element_size == sizeof(struct sd_bus_vtable), -EINVAL); + assert_return(!bus_pid_changed(bus), -ECHILD); r = hashmap_ensure_allocated(&bus->vtable_methods, vtable_member_hash_func, vtable_member_compare_func); if (r < 0) @@ -1534,7 +1632,9 @@ static int add_object_vtable_internal( } } - LIST_PREPEND(struct node_vtable, vtables, n->vtables, c); + LIST_PREPEND(vtables, n->vtables, c); + bus->nodes_modified = true; + return 0; fail: @@ -1554,14 +1654,10 @@ static int remove_object_vtable_internal( struct node_vtable *c; struct node *n; - if (!bus) - return -EINVAL; - if (!object_path_is_valid(path)) - return -EINVAL; - if (!interface_name_is_valid(interface)) - return -EINVAL; - if (bus_pid_changed(bus)) - return -ECHILD; + assert_return(bus, -EINVAL); + assert_return(object_path_is_valid(path), -EINVAL); + assert_return(interface_name_is_valid(interface), -EINVAL); + assert_return(!bus_pid_changed(bus), -ECHILD); n = hashmap_get(bus->nodes, path); if (!n) @@ -1574,9 +1670,13 @@ static int remove_object_vtable_internal( if (!c) return 0; - LIST_REMOVE(struct node_vtable, vtables, n->vtables, c); + LIST_REMOVE(vtables, n->vtables, c); free_node_vtable(bus, c); + bus_node_gc(bus, n); + + bus->nodes_modified = true; + return 1; } @@ -1627,14 +1727,10 @@ int sd_bus_add_node_enumerator( struct node *n; int r; - if (!bus) - return -EINVAL; - if (!object_path_is_valid(path)) - return -EINVAL; - if (!callback) - return -EINVAL; - if (bus_pid_changed(bus)) - return -ECHILD; + assert_return(bus, -EINVAL); + assert_return(object_path_is_valid(path), -EINVAL); + assert_return(callback, -EINVAL); + assert_return(!bus_pid_changed(bus), -ECHILD); n = bus_node_allocate(bus, path); if (!n) @@ -1650,7 +1746,10 @@ int sd_bus_add_node_enumerator( c->callback = callback; c->userdata = userdata; - LIST_PREPEND(struct node_enumerator, enumerators, n->enumerators, c); + LIST_PREPEND(enumerators, n->enumerators, c); + + bus->nodes_modified = true; + return 0; fail: @@ -1668,14 +1767,10 @@ int sd_bus_remove_node_enumerator( struct node_enumerator *c; struct node *n; - if (!bus) - return -EINVAL; - if (!object_path_is_valid(path)) - return -EINVAL; - if (!callback) - return -EINVAL; - if (bus_pid_changed(bus)) - return -ECHILD; + assert_return(bus, -EINVAL); + assert_return(object_path_is_valid(path), -EINVAL); + assert_return(callback, -EINVAL); + assert_return(!bus_pid_changed(bus), -ECHILD); n = hashmap_get(bus->nodes, path); if (!n) @@ -1688,11 +1783,13 @@ int sd_bus_remove_node_enumerator( if (!c) return 0; - LIST_REMOVE(struct node_enumerator, enumerators, n->enumerators, c); + LIST_REMOVE(enumerators, n->enumerators, c); free(c); bus_node_gc(bus, n); + bus->nodes_modified = true; + return 1; } @@ -1714,6 +1811,7 @@ static int emit_properties_changed_on_interface( int r; assert(bus); + assert(prefix); assert(path); assert(interface); @@ -1735,6 +1833,8 @@ static int emit_properties_changed_on_interface( r = node_vtable_get_userdata(bus, path, c, &u); if (r <= 0) return r; + if (bus->nodes_modified) + return 0; r = sd_bus_message_new_signal(bus, path, "org.freedesktop.DBus.Properties", "PropertiesChanged", &m); if (r < 0) @@ -1755,15 +1855,16 @@ static int emit_properties_changed_on_interface( _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; struct vtable_member *v; + assert_return(member_name_is_valid(*property), -EINVAL); + key.member = *property; v = hashmap_get(bus->vtable_properties, &key); if (!v) return -ENOENT; assert(c == v->parent); + assert_return(v->vtable->flags & SD_BUS_VTABLE_PROPERTY_EMITS_CHANGE, -EDOM); - if (!(v->vtable->flags & SD_BUS_VTABLE_PROPERTY_EMITS_CHANGE)) - return -EDOM; if (v->vtable->flags & SD_BUS_VTABLE_PROPERTY_INVALIDATE_ONLY) { has_invalidating = true; continue; @@ -1784,9 +1885,8 @@ static int emit_properties_changed_on_interface( r = invoke_property_get(bus, v->vtable, m->path, interface, *property, m, &error, vtable_property_convert_userdata(v->vtable, u)); if (r < 0) return r; - - if (sd_bus_error_is_set(&error)) - return bus_error_to_errno(&error); + if (bus->nodes_modified) + return 0; r = sd_bus_message_close_container(m); if (r < 0) @@ -1833,97 +1933,303 @@ static int emit_properties_changed_on_interface( return 1; } -int sd_bus_emit_properties_changed_strv(sd_bus *bus, const char *path, const char *interface, char **names) { - size_t pl; +int sd_bus_emit_properties_changed_strv( + sd_bus *bus, + const char *path, + const char *interface, + char **names) { + + BUS_DONT_DESTROY(bus); + char *prefix; int r; - if (!bus) - return -EINVAL; - if (!object_path_is_valid(path)) - return -EINVAL; - if (!interface_name_is_valid(interface)) - return -EINVAL; + assert_return(bus, -EINVAL); + assert_return(object_path_is_valid(path), -EINVAL); + assert_return(interface_name_is_valid(interface), -EINVAL); + assert_return(BUS_IS_OPEN(bus->state), -ENOTCONN); + assert_return(!bus_pid_changed(bus), -ECHILD); + + if (strv_isempty(names)) + return 0; + + do { + bus->nodes_modified = false; + + r = emit_properties_changed_on_interface(bus, path, path, interface, false, names); + if (r != 0) + return r; + if (bus->nodes_modified) + continue; + + prefix = alloca(strlen(path) + 1); + OBJECT_PATH_FOREACH_PREFIX(prefix, path) { + r = emit_properties_changed_on_interface(bus, prefix, path, interface, true, names); + if (r != 0) + return r; + if (bus->nodes_modified) + break; + } + + } while (bus->nodes_modified); + + return -ENOENT; +} + +int sd_bus_emit_properties_changed( + sd_bus *bus, + const char *path, + const char *interface, + const char *name, ...) { + + char **names; + + assert_return(bus, -EINVAL); + assert_return(object_path_is_valid(path), -EINVAL); + assert_return(interface_name_is_valid(interface), -EINVAL); + assert_return(BUS_IS_OPEN(bus->state), -ENOTCONN); + assert_return(!bus_pid_changed(bus), -ECHILD); + + if (!name) + return 0; + + names = strv_from_stdarg_alloca(name); + + return sd_bus_emit_properties_changed_strv(bus, path, interface, names); +} + +static int interfaces_added_append_one_prefix( + sd_bus *bus, + sd_bus_message *m, + const char *prefix, + const char *path, + const char *interface, + bool require_fallback) { + + _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL; + struct node_vtable *c; + struct node *n; + void *u = NULL; + int r; + + assert(bus); + assert(m); + assert(prefix); + assert(path); + assert(interface); + + n = hashmap_get(bus->nodes, prefix); + if (!n) + return 0; + + LIST_FOREACH(vtables, c, n->vtables) { + if (require_fallback && !c->is_fallback) + continue; + + if (streq(c->interface, interface)) + break; + } + + if (!c) + return 0; - r = emit_properties_changed_on_interface(bus, path, path, interface, false, names); + r = node_vtable_get_userdata(bus, path, c, &u); + if (r <= 0) + return r; + if (bus->nodes_modified) + return 0; + + r = sd_bus_message_append_basic(m, 's', interface); + if (r < 0) + return r; + + r = sd_bus_message_open_container(m, 'a', "{sv}"); + if (r < 0) + return r; + + r = vtable_append_all_properties(bus, m,path, c, u, &error); + if (r < 0) + return r; + if (bus->nodes_modified) + return 0; + + r = sd_bus_message_close_container(m); + if (r < 0) + return r; + + return 1; +} + +static int interfaces_added_append_one( + sd_bus *bus, + sd_bus_message *m, + const char *path, + const char *interface) { + + char *prefix; + int r; + + assert(bus); + assert(m); + assert(path); + assert(interface); + + r = interfaces_added_append_one_prefix(bus, m, path, path, interface, false); if (r != 0) return r; + if (bus->nodes_modified) + return 0; + + prefix = alloca(strlen(path) + 1); + OBJECT_PATH_FOREACH_PREFIX(prefix, path) { + r = interfaces_added_append_one_prefix(bus, m, prefix, path, interface, true); + if (r != 0) + return r; + if (bus->nodes_modified) + return 0; + } - pl = strlen(path); - if (pl > 1 ) { - char p[pl+1]; + return -ENOENT; +} - strcpy(p, path); - for (;;) { - char *e; +int sd_bus_emit_interfaces_added_strv(sd_bus *bus, const char *path, char **interfaces) { + BUS_DONT_DESTROY(bus); - if (streq(p, "/")) - break; + _cleanup_bus_message_unref_ sd_bus_message *m = NULL; + char **i; + int r; - e = strrchr(p, '/'); - assert(e); - if (e == p) - *(e+1) = 0; - else - *e = 0; + assert_return(bus, -EINVAL); + assert_return(object_path_is_valid(path), -EINVAL); + assert_return(BUS_IS_OPEN(bus->state), -ENOTCONN); + assert_return(!bus_pid_changed(bus), -ECHILD); - r = emit_properties_changed_on_interface(bus, p, path, interface, true, names); - if (r != 0) + if (strv_isempty(interfaces)) + return 0; + + do { + bus->nodes_modified = false; + + if (m) + m = sd_bus_message_unref(m); + + r = sd_bus_message_new_signal(bus, path, "org.freedesktop.DBus.ObjectManager", "InterfacesAdded", &m); + if (r < 0) + return r; + + r = sd_bus_message_append_basic(m, 'o', path); + if (r < 0) + return r; + + r = sd_bus_message_open_container(m, 'a', "{sa{sv}}"); + if (r < 0) + return r; + + STRV_FOREACH(i, interfaces) { + assert_return(interface_name_is_valid(*i), -EINVAL); + + r = sd_bus_message_open_container(m, 'e', "sa{sv}"); + if (r < 0) + return r; + + r = interfaces_added_append_one(bus, m, path, *i); + if (r < 0) + return r; + + if (bus->nodes_modified) + break; + + r = sd_bus_message_close_container(m); + if (r < 0) return r; } - } - return -ENOENT; + if (bus->nodes_modified) + continue; + + r = sd_bus_message_close_container(m); + if (r < 0) + return r; + + } while (bus->nodes_modified); + + return sd_bus_send(bus, m, NULL); } -int sd_bus_emit_properties_changed(sd_bus *bus, const char *path, const char *interface, const char *name, ...) { - _cleanup_strv_free_ char **names = NULL; - va_list ap; +int sd_bus_emit_interfaces_added(sd_bus *bus, const char *path, const char *interface, ...) { + char **interfaces; - va_start(ap, name); - names = strv_new_ap(name, ap); - va_end(ap); + assert_return(bus, -EINVAL); + assert_return(object_path_is_valid(path), -EINVAL); + assert_return(BUS_IS_OPEN(bus->state), -ENOTCONN); + assert_return(!bus_pid_changed(bus), -ECHILD); - if (!names) - return -ENOMEM; + interfaces = strv_from_stdarg_alloca(interface); - return sd_bus_emit_properties_changed_strv(bus, path, interface, names); + return sd_bus_emit_interfaces_added_strv(bus, path, interfaces); } -int sd_bus_emit_interfaces_added(sd_bus *bus, const char *path, const char *interfaces, ...) { - return -ENOSYS; +int sd_bus_emit_interfaces_removed_strv(sd_bus *bus, const char *path, char **interfaces) { + _cleanup_bus_message_unref_ sd_bus_message *m = NULL; + int r; + + assert_return(bus, -EINVAL); + assert_return(object_path_is_valid(path), -EINVAL); + assert_return(BUS_IS_OPEN(bus->state), -ENOTCONN); + assert_return(!bus_pid_changed(bus), -ECHILD); + + if (strv_isempty(interfaces)) + return 0; + + r = sd_bus_message_new_signal(bus, path, "org.freedesktop.DBus.ObjectManager", "InterfacesRemoved", &m); + if (r < 0) + return r; + + r = sd_bus_message_append_basic(m, 'o', path); + if (r < 0) + return r; + + r = sd_bus_message_append_strv(m, interfaces); + if (r < 0) + return r; + + return sd_bus_send(bus, m, NULL); } -int sd_bus_emit_interfaces_removed(sd_bus *bus, const char *path, const char *interfaces, ...) { - return -ENOSYS; +int sd_bus_emit_interfaces_removed(sd_bus *bus, const char *path, const char *interface, ...) { + char **interfaces; + + assert_return(bus, -EINVAL); + assert_return(object_path_is_valid(path), -EINVAL); + assert_return(BUS_IS_OPEN(bus->state), -ENOTCONN); + assert_return(!bus_pid_changed(bus), -ECHILD); + + interfaces = strv_from_stdarg_alloca(interface); + + return sd_bus_emit_interfaces_removed_strv(bus, path, interfaces); } int sd_bus_add_object_manager(sd_bus *bus, const char *path) { struct node *n; - if (!bus) - return -EINVAL; - if (!object_path_is_valid(path)) - return -EINVAL; - if (bus_pid_changed(bus)) - return -ECHILD; + assert_return(bus, -EINVAL); + assert_return(object_path_is_valid(path), -EINVAL); + assert_return(!bus_pid_changed(bus), -ECHILD); n = bus_node_allocate(bus, path); if (!n) return -ENOMEM; n->object_manager = true; + bus->nodes_modified = true; return 0; } int sd_bus_remove_object_manager(sd_bus *bus, const char *path) { struct node *n; - if (!bus) - return -EINVAL; - if (!object_path_is_valid(path)) - return -EINVAL; - if (bus_pid_changed(bus)) - return -ECHILD; + assert_return(bus, -EINVAL); + assert_return(object_path_is_valid(path), -EINVAL); + assert_return(!bus_pid_changed(bus), -ECHILD); n = hashmap_get(bus->nodes, path); if (!n) @@ -1933,6 +2239,8 @@ int sd_bus_remove_object_manager(sd_bus *bus, const char *path) { return 0; n->object_manager = false; + bus->nodes_modified = true; bus_node_gc(bus, n); + return 1; }