chiark / gitweb /
udevd: read debug settings from kernel commandline
[elogind.git] / udev / udevd.c
index 802153b295c229fcd0153f2e37d4129f7f185fdd..612f04d1b95012a512db8a5a18891ce22dbadfe7 100644 (file)
@@ -69,7 +69,6 @@ static void log_fn(struct udev *udev, int priority,
        }
 }
 
-static bool debug_trace;
 static struct udev_rules *rules;
 static struct udev_queue_export *udev_queue_export;
 static struct udev_ctrl *udev_ctrl;
@@ -78,8 +77,9 @@ static int worker_watch[2];
 static pid_t settle_pid;
 static bool stop_exec_queue;
 static bool reload_config;
-static int max_childs;
-static int childs;
+static int children;
+static int children_max;
+static int exec_delay;
 static sigset_t orig_sigmask;
 static struct udev_list_node event_list;
 static struct udev_list_node worker_list;
@@ -205,7 +205,7 @@ static void worker_unref(struct worker *worker)
 
        udev_list_node_remove(&worker->node);
        udev_monitor_unref(worker->monitor);
-       childs--;
+       children--;
        info(worker->udev, "worker [%u] cleaned up\n", worker->pid);
        free(worker);
 }
@@ -286,6 +286,9 @@ static void worker_new(struct event *event)
                        /* set timeout to prevent hanging processes */
                        alarm(UDEV_EVENT_TIMEOUT);
 
+                       if (exec_delay > 0)
+                               udev_event->exec_delay = exec_delay;
+
                        /* apply rules, create node, symlinks */
                        err = udev_event_execute_rules(udev_event, rules);
 
@@ -355,7 +358,7 @@ static void worker_new(struct event *event)
                worker->event = event;
                event->state = EVENT_RUNNING;
                udev_list_node_append(&worker->node, &worker_list);
-               childs++;
+               children++;
                info(event->udev, "seq %llu forked new worker [%u]\n", udev_device_get_seqnum(event->dev), pid);
                break;
        }
@@ -386,8 +389,9 @@ static void event_run(struct event *event, bool force)
                return;
        }
 
-       if (!force && childs >= max_childs) {
-               info(event->udev, "maximum number (%i) of childs reached\n", childs);
+       if (!force && children >= children_max) {
+               if (children_max > 1)
+                       info(event->udev, "maximum number (%i) of children reached\n", children);
                return;
        }
 
@@ -431,10 +435,10 @@ static void worker_kill(struct udev *udev, int retain)
        struct udev_list_node *loop;
        int max;
 
-       if (childs <= retain)
+       if (children <= retain)
                return;
 
-       max = childs - retain;
+       max = children - retain;
 
        udev_list_node_foreach(loop, &worker_list) {
                struct worker *worker = node_to_worker(loop);
@@ -536,7 +540,7 @@ static void events_start(struct udev *udev)
 
 static void worker_returned(void)
 {
-       while (1) {
+       for (;;) {
                struct worker_message msg;
                ssize_t size;
                struct udev_list_node *loop;
@@ -625,10 +629,10 @@ static void handle_ctrl_msg(struct udev_ctrl *uctrl)
                worker_kill(udev, 0);
        }
 
-       i = udev_ctrl_get_set_max_childs(ctrl_msg);
+       i = udev_ctrl_get_set_children_max(ctrl_msg);
        if (i >= 0) {
-               info(udev, "udevd message (SET_MAX_CHILDS) received, max_childs=%i\n", i);
-               max_childs = i;
+               info(udev, "udevd message (SET_MAX_CHILDREN) received, children_max=%i\n", i);
+               children_max = i;
        }
 
        settle_pid = udev_ctrl_get_settle(ctrl_msg);
@@ -709,7 +713,7 @@ static void handle_signal(struct udev *udev, int signo)
                udev_exit = true;
                break;
        case SIGCHLD:
-               while (1) {
+               for (;;) {
                        pid_t pid;
                        int status;
                        struct udev_list_node *loop, *tmp;
@@ -952,16 +956,16 @@ int main(int argc, char *argv[])
        int fd;
        FILE *f;
        sigset_t mask;
-       const char *value;
        int daemonize = false;
        int resolve_names = 1;
        static const struct option options[] = {
                { "daemon", no_argument, NULL, 'd' },
-               { "debug-trace", no_argument, NULL, 't' },
                { "debug", no_argument, NULL, 'D' },
+               { "children-max", required_argument, NULL, 'c' },
+               { "exec-delay", required_argument, NULL, 'e' },
+               { "resolve-names", required_argument, NULL, 'N' },
                { "help", no_argument, NULL, 'h' },
                { "version", no_argument, NULL, 'V' },
-               { "resolve-names", required_argument, NULL, 'N' },
                {}
        };
        int rc = 1;
@@ -975,10 +979,10 @@ int main(int argc, char *argv[])
        info(udev, "version %s\n", VERSION);
        udev_selinux_init(udev);
 
-       while (1) {
+       for (;;) {
                int option;
 
-               option = getopt_long(argc, argv, "dDthV", options, NULL);
+               option = getopt_long(argc, argv, "cdeDthV", options, NULL);
                if (option == -1)
                        break;
 
@@ -986,8 +990,11 @@ int main(int argc, char *argv[])
                case 'd':
                        daemonize = true;
                        break;
-               case 't':
-                       debug_trace = true;
+               case 'c':
+                       children_max = strtoul(optarg, NULL, 0);
+                       break;
+               case 'e':
+                       exec_delay = strtoul(optarg, NULL, 0);
                        break;
                case 'D':
                        debug = true;
@@ -1008,8 +1015,15 @@ int main(int argc, char *argv[])
                        }
                        break;
                case 'h':
-                       printf("Usage: udevd [--help] [--daemon] [--debug-trace] [--debug] "
-                              "[--resolve-names=early|late|never] [--version]\n");
+                       printf("Usage: udevd OPTIONS\n"
+                              "  --daemon\n"
+                              "  --debug\n"
+                              "  --children-max=<maximum number of workers>\n"
+                              "  --exec-delay=<seconds to wait before executing RUN=>\n"
+                              "  --resolve-names=early|late|never\n" 
+                              "  --version\n"
+                              "  --help\n"
+                              "\n");
                        goto exit;
                case 'V':
                        printf("%s\n", VERSION);
@@ -1025,7 +1039,41 @@ int main(int argc, char *argv[])
                goto exit;
        }
 
-       /* make sure std{in,out,err} fd's are in a sane state */
+       /*
+        * read the kernel commandline, in case we need to get into debug mode
+        *   udev.log-priority=<level>              syslog priority
+        *   udev.children-max=<number of workers>  events are fully serialized if set to 1
+        *
+        */
+       f = fopen("/proc/cmdline", "r");
+       if (f != NULL) {
+               char cmdline[4096];
+
+               if (fgets(cmdline, sizeof(cmdline), f) != NULL) {
+                       char *pos;
+
+                       pos = strstr(cmdline, "udev.log-priority=");
+                       if (pos != NULL) {
+                               pos += strlen("udev.log-priority=");
+                               udev_set_log_priority(udev, util_log_priority(pos));
+                       }
+
+                       pos = strstr(cmdline, "udev.children-max=");
+                       if (pos != NULL) {
+                               pos += strlen("udev.children-max=");
+                               children_max = strtoul(pos, NULL, 0);
+                       }
+
+                       pos = strstr(cmdline, "udev.exec-delay=");
+                       if (pos != NULL) {
+                               pos += strlen("udev.exec-delay=");
+                               exec_delay = strtoul(pos, NULL, 0);
+                       }
+               }
+               fclose(f);
+       }
+
+       /* make sure std{in,out,err} fds are in a sane state */
        fd = open("/dev/null", O_RDWR);
        if (fd < 0) {
                fprintf(stderr, "cannot open /dev/null\n");
@@ -1036,7 +1084,6 @@ int main(int argc, char *argv[])
        if (write(STDERR_FILENO, 0, 0) < 0)
                dup2(fd, STDERR_FILENO);
 
-       /* init control socket, bind() ensures, that only one udevd instance is running */
        udev_ctrl = udev_ctrl_new_from_socket(udev, UDEV_CTRL_SOCK_PATH);
        if (udev_ctrl == NULL) {
                fprintf(stderr, "error initializing control socket");
@@ -1150,8 +1197,7 @@ int main(int argc, char *argv[])
                fclose(f);
        }
 
-       /* redirect std{out,err} */
-       if (!debug && !debug_trace) {
+       if (!debug) {
                dup2(fd, STDIN_FILENO);
                dup2(fd, STDOUT_FILENO);
                dup2(fd, STDERR_FILENO);
@@ -1159,7 +1205,7 @@ int main(int argc, char *argv[])
        if (fd > STDERR_FILENO)
                close(fd);
 
-       /* set scheduling priority for the daemon */
+       /* set scheduling priority for the main daemon process */
        setpriority(PRIO_PROCESS, 0, UDEVD_PRIORITY);
 
        chdir("/");
@@ -1175,23 +1221,16 @@ int main(int argc, char *argv[])
                close(fd);
        }
 
-       /* in trace mode run one event after the other */
-       if (debug_trace) {
-               max_childs = 1;
-       } else {
+       if (children_max <= 0) {
                int memsize = mem_size_mb();
 
+               /* set value depending on the amount of RAM */
                if (memsize > 0)
-                       max_childs = 128 + (memsize / 8);
+                       children_max = 128 + (memsize / 8);
                else
-                       max_childs = 128;
+                       children_max = 128;
        }
-
-       /* possibly overwrite maximum limit of executed events */
-       value = getenv("UDEVD_MAX_CHILDS");
-       if (value)
-               max_childs = strtoul(value, NULL, 10);
-       info(udev, "initialize max_childs to %u\n", max_childs);
+       info(udev, "set children_max to %u\n", children_max);
 
        static_dev_create(udev);
        static_dev_create_from_modules(udev);
@@ -1205,7 +1244,7 @@ int main(int argc, char *argv[])
                int timeout;
 
                /* set timeout to kill idle workers */
-               if (udev_list_is_empty(&event_list) && childs > 2)
+               if (udev_list_is_empty(&event_list) && children > 2)
                        timeout = 3 * 1000;
                else
                        timeout = -1;