if (major(st.st_dev) == 0)
return false;
- if (!(udev = udev_new()))
+ udev = udev_new();
+ if (!udev)
return -ENOMEM;
- if (!(udev_device = udev_device_new_from_devnum(udev, 'b', st.st_dev)))
+ udev_device = udev_device_new_from_devnum(udev, 'b', st.st_dev);
+ if (!udev_device)
goto finish;
- if ((devtype = udev_device_get_property_value(udev_device, "DEVTYPE")) &&
- streq(devtype, "partition"))
+ devtype = udev_device_get_property_value(udev_device, "DEVTYPE");
+ if (devtype && streq(devtype, "partition"))
look_at = udev_device_get_parent(udev_device);
else
look_at = udev_device;
goto finish;
/* First, try high-level property */
- if ((id = udev_device_get_property_value(look_at, "ID_SSD"))) {
+ id = udev_device_get_property_value(look_at, "ID_SSD");
+ if (id) {
b = streq(id, "1");
goto finish;
}
/* Second, try kernel attribute */
- if ((rotational = udev_device_get_sysattr_value(look_at, "queue/rotational")))
+ rotational = udev_device_get_sysattr_value(look_at, "queue/rotational");
+ if (rotational)
if ((b = streq(rotational, "0")))
goto finish;
/* Finally, fallback to heuristics */
- if (!(look_at = udev_device_get_parent(look_at)))
+ look_at = udev_device_get_parent(look_at);
+ if (!look_at)
goto finish;
- if ((model = udev_device_get_sysattr_value(look_at, "model")))
+ model = udev_device_get_sysattr_value(look_at, "model");
+ if (model)
b = !!strstr(model, "SSD");
finish:
return m;
}
-#define BUMP_REQUEST_NR (16*1024)
+/* We use 20K instead of the more human digestable 16K here. Why?
+ Simply so that it is more unlikely that users end up picking this
+ value too so that we can recognize better whether the user changed
+ the value while we had it temporarily bumped. */
+#define BUMP_REQUEST_NR (20*1024)
int block_bump_request_nr(const char *p) {
struct stat st;