*s = v;
}
+static bool startswith_comma(const char *s, const char *prefix) {
+ const char *t;
+
+ return s && (t = startswith(s, prefix)) && (*t == ',');
+}
+
static void context_free_x11(Context *c) {
free_and_replace(&c->x11_layout, NULL);
free_and_replace(&c->x11_model, NULL);
return write_env_file_label("/etc/vconsole.conf", l);
}
-static int write_data_x11(Context *c) {
+static int x11_write_data(Context *c) {
_cleanup_fclose_ FILE *f = NULL;
_cleanup_free_ char *temp_path = NULL;
int r;
if (modified) {
int r;
- r = write_data_x11(c);
- if (r < 0)
+ r = x11_write_data(c);
+ if (r < 0) {
log_error("Failed to set X11 keyboard layout: %s", strerror(-r));
+ return r;
+ }
log_info("Changed X11 keyboard layout to '%s' model '%s' variant '%s' options '%s'",
strempty(c->x11_layout),
return 0;
}
-static int find_converted_keymap(Context *c, char **new_keymap) {
+static int find_converted_keymap(const char *x11_layout, const char *x11_variant, char **new_keymap) {
const char *dir;
_cleanup_free_ char *n;
- if (c->x11_variant)
- n = strjoin(c->x11_layout, "-", c->x11_variant, NULL);
+ if (x11_variant)
+ n = strjoin(x11_layout, "-", x11_variant, NULL);
else
- n = strdup(c->x11_layout);
+ n = strdup(x11_layout);
if (!n)
return -ENOMEM;
_cleanup_fclose_ FILE *f;
unsigned n = 0;
unsigned best_matching = 0;
-
+ int r;
f = fopen(SYSTEMD_KBD_MODEL_MAP, "re");
if (!f)
for (;;) {
_cleanup_strv_free_ char **a = NULL;
unsigned matching = 0;
- int r;
r = read_next_mapping(f, &n, &a);
if (r < 0)
/* If we got an exact match, this is best */
matching = 10;
else {
- size_t x;
-
- x = strcspn(c->x11_layout, ",");
-
/* We have multiple X layouts, look for an
* entry that matches our key with everything
* but the first layout stripped off. */
- if (x > 0 &&
- strlen(a[1]) == x &&
- strneq(c->x11_layout, a[1], x))
+ if (startswith_comma(c->x11_layout, a[1]))
matching = 5;
else {
- size_t w;
+ char *x;
/* If that didn't work, strip off the
* other layouts from the entry, too */
- w = strcspn(a[1], ",");
-
- if (x > 0 && x == w &&
- memcmp(c->x11_layout, a[1], x) == 0)
+ x = strndupa(a[1], strcspn(a[1], ","));
+ if (startswith_comma(c->x11_layout, x))
matching = 1;
}
}
}
}
+ if (best_matching < 10 && c->x11_layout) {
+ /* The best match is only the first part of the X11
+ * keymap. Check if we have a converted map which
+ * matches just the first layout.
+ */
+ char *l, *v = NULL, *converted;
+
+ l = strndupa(c->x11_layout, strcspn(c->x11_layout, ","));
+ if (c->x11_variant)
+ v = strndupa(c->x11_variant, strcspn(c->x11_variant, ","));
+ r = find_converted_keymap(l, v, &converted);
+ if (r < 0)
+ return r;
+ if (r > 0)
+ free_and_replace(new_keymap, converted);
+ }
+
return 0;
}
} else {
char *new_keymap = NULL;
- r = find_converted_keymap(c, &new_keymap);
+ r = find_converted_keymap(c->x11_layout, c->x11_variant, &new_keymap);
if (r < 0)
return r;
else if (r == 0) {
free_and_strdup(&c->x11_options, options) < 0)
return -ENOMEM;
- r = write_data_x11(c);
+ r = x11_write_data(c);
if (r < 0) {
log_error("Failed to set X11 keyboard layout: %s", strerror(-r));
return sd_bus_error_set_errnof(error, r, "Failed to set X11 keyboard layout: %s", strerror(-r));