chiark / gitweb /
changelog: document further make-release changes
[otter.git] / Makefile
index aa62872028bca4f07c264442d7d2d17cbd02738d..b316edc6c24eb3d62576a00f0d2026f622a88bd7 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -15,10 +15,9 @@ full-check: all check cargo-syntaxcheck-release shapelib doc-sphinx
 full-check: for-deploy release
 everything: debug doc release check bundled-sources
 
-shapelib: templates/shapelib.html stamp/cargo.doc-otter-only
+shapelib: templates/shapelib.html docs/html/index.html
        @echo 'Shape library preview and docs can now be found here:'
-       @echo '  file://$(PWD)/$<'
-       @echo '  file://$(abspath $(TARGET_DIR)/doc/otter/shapelib_toml/index.html)'
+       @for f in $^; do echo '  file://$(PWD)/'$$f; done
 
 MAKEFILE_DEP ?= Makefile
 MAKEFILE_FIND_X ?=
@@ -38,19 +37,16 @@ BUNDLED_SOURCES += $(BUNDLED_SOURCES_FILES)
 
 #---------- programs and config variables ----------
 
-CARGO ?= cargo
 TARGET_DIR ?= target
 
-USVG_OPTIONS = "--sans-serif-family=DejaVu Sans"
-
 WASM_BINDGEN = $(TARGET_DIR)/debug/wasm-bindgen
 WASM_BINDGEN_OPTIONS =                                         \
        --remove-name-section --remove-producers-section        \
-       --typescript --no-modules                               \
+       --typescript
 
 BUNDLE_SOURCES ?= bundle-rust-sources
 
-SPHINXBUILD   = sphinx-build
+SPHINXBUILD   ?= sphinx-build
 
 ifndef INKSCAPE_EXTENSIONS
 INKSCAPE ?= inkscape
@@ -62,17 +58,21 @@ endif
 RECOLOUR_SVG ?= ./run-inkscape-extension $(INKSCAPE_EXTENSIONS)/color_replace.py
 
 DEPLOY_ARCH=x86_64-unknown-linux-musl
-DEPLOY_RELEASE=debug
+DEPLOY_RELEASE=release
 DEPLOY_TARGET_DIR=$(TARGET_DIR)/$(addsuffix /,$(DEPLOY_ARCH))$(DEPLOY_RELEASE)
 DEPLOYED_BRANCH=deployed
 PUBLISHED_BRANCH=published
 
+RUST_CLIPPY_OPTIONS ?= $(shell perl -pe 's/\#.*//; s/\n/ /' clippy-options)
+RUST_CLIPPY ?= clippy
+RUST_CLIPPY_CMD := clippy $(RUST_CLIPPY_OPTIONS)
+
 #---------- nailing-cargo ----------
 
 ifneq (,$(wildcard ../Cargo.nail))
 
-NAILING_CARGO = nailing-cargo
-CARGO = $(NAILING_CARGO)
+NAILING_CARGO ?= nailing-cargo
+CARGO_CMD ?= $(NAILING_CARGO)
 BUILD_SUBDIR ?= ../Build
 TARGET_DIR = $(BUILD_SUBDIR)/$(notdir $(PWD))/target
 
@@ -81,12 +81,16 @@ BUNDLE_SOURCES_CMD ?= $(NAILING_CARGO) --- $(BUNDLE_SOURCES)
 USVG_CMD ?= $(NAILING_CARGO_JUST_RUN) $(USVG)
 WASM_BINDGEN_CLI_CARGO_OPTS ?= --subcommand-props=!manifest-path
 
+CARGO_DOCUMENT_PRIVATE_ITEMS ?= --document-private-items
+CARGO_DOC_OPTS += $(CARGO_DOCUMENT_PRIVATE_ITEMS)
+
 clean-nailing:
        $(NAILING_CARGO_JUST_RUN) \
  sh -c 'cd "$1"; find -mindepth 1 -maxdepth 1 -print0 | xargs -0r rm -rf --' \
                $(abspath $(BUILD_SUBDIR)/$(notdir $(PWD)))
 
 else
+CARGO_CMD ?= cargo
 clean-nailing:
 endif # Cargo.nail
 
@@ -124,9 +128,11 @@ TS_SRC_FILES= \
 LITFILES= LICENCE AGPLv3
 TXTFILES= CC-BY-SA-3.0 CC-BY-SA-4.0
 
-FILEASSETS = $(addprefix templates/, libre shapelib.html script.js \
+NWTEMPLATEASSETS = nwtemplates/die-overlay.tera
+FILEASSETS =   $(addprefix templates/, libre shapelib.html script.js \
                        $(LITFILES) $(TXTFILES)) \
-               $(wildcard templates/*.tera)
+               $(wildcard templates/*.tera) \
+               $(NWTEMPLATEASSETS)
 
 WASM := wasm32-unknown-unknown
 # ^ todo: Is this still right after
@@ -135,9 +141,12 @@ WASM := wasm32-unknown-unknown
 # ?  But maybe it doesn't matter since we're very conservative and
 # only pass JsValue and a few strings across the WASM ABI.
 
+RUST_NIGHTLY_VERSION ?= +nightly
+CARGO = $(CARGO_CMD) $(RUST_VERSION)
+
 #---------- toplevel aggregate targets ----------
 
-check: stamp/cargo.debug-check at wdt
+check: stamp/cargo.debug-check at wdt jstest
        @echo 'Tests passed.'
 
 full-check: stamp/cargo.release-check
@@ -156,8 +165,10 @@ cargo-debug cargo-release cargo-check cargo-doc \
 cargo-wasm-debug cargo-wasm-release:: \
 cargo-%: stamp/cargo.%
 
-examples: examples/test-bundle.zip
-examples: examples/big-bundle.zip
+EXAMPLE_BUNDLES = test-bundle big-bundle
+EXAMPLE_BUNDLE_FILES = $(foreach f, $(EXAMPLE_BUNDLES), examples/$f.zip)
+
+examples: $(EXAMPLE_BUNDLE_FILES)
 .PHONY: examples
 
 cargo-wasm: cargo-wasm-release
@@ -179,6 +190,12 @@ cargo-syntaxcheck-wasm:
 cargo-syntaxcheck-release:
        $(CARGO) check --workspace --release
 
+cargo-clippy: cargo-clippy-host cargo-clippy-wasm
+cargo-clippy-host: clippy-options
+       $(CARGO) $(RUST_CLIPPY) --workspace $(RUST_CLIPPY_OPTIONS)
+cargo-clippy-wasm: clippy-options
+       $(CARGO) $(RUST_CLIPPY) --target $(WASM) -p otter-wasm $(RUST_CLIPPY_OPTIONS)
+
 #---------- cargo ----------
 
 DR=debug release
@@ -186,14 +203,18 @@ CARGOES=$(foreach t, wasm-,$(addprefix $t,check $(DR)))
 
 $(addprefix stamp/cargo.,$(DR)):: \
 stamp/cargo.%: $(call rsrcs,. ! -path './wasm/*')
-       $(CARGO) build --workspace $(call cr,$*) -p otter -p otter-daemon
+       $(CARGO) build --workspace $(call cr,$*) -p otter -p otter-daemon -p otter-cli
+       $(NAILING_CARGO_JUST_RUN) \
+       ln -sf otter $(abspath $(TARGET_DIR))/$*/otter-ssh-proxy
        $(stamp)
 
 $(TARGET_DIR)/debug/%: $(call rsrcs, ! -path './wasm/*')
-       $(CARGO) build --workspace -p otter --bin $*
+       $(CARGO) build --workspace -p otter-cli
+       $(NAILING_CARGO_JUST_RUN) touch $(abspath $@)
 
 stamp/cargo.wasm-bindgen: $(call rsrcs, ! -name \*.rs)
-       $(CARGO) $(WASM_BINDGEN_CLI_CARGO_OPTS) build --target-dir=target \
+       $(CARGO_CMD) $(WASM_BINDGEN_CLI_CARGO_OPTS) $(RUST_VERSION) \
+               build --target-dir=target \
                --manifest-path=$(abspath wasm/Cargo.toml) -p wasm-bindgen-cli
        $(stamp)
 
@@ -202,7 +223,8 @@ stamp/cargo.%-check: $(call rsrcs,.)
        $(stamp)
 
 stamp/cargo.%-miri: $(call rsrcs,.)
-       $(CARGO) miri test --workspace $(call cr,$*)
+       $(CARGO_CMD) $(RUST_NIGHTLY_VERSION) \
+               miri test --workspace $(call cr,$*)
        $(stamp)
 
 stamp/cargo-at.debug: $(call rsrcs,.)
@@ -213,12 +235,14 @@ stamp/cargo-wdt.debug: $(call rsrcs,.)
        $(CARGO) build --workspace $(call cr,$*) -p otter-webdriver-tests
        $(stamp)
 
-stamp/cargo.doc: $(call rsrcs,.)
-       $(CARGO) doc $(CARGO_DOC_OPTS) --workspace 2>&1 |egrep -vf .cargo-doc-suppress-errors
+stamp/cargo-jstest.debug: $(call rsrcs,.)
+       $(CARGO) build --workspace $(call cr,$*) -p otter-nodejs-tests
        $(stamp)
 
-stamp/cargo.doc-otter-only: $(call rsrcs,.)
-       $(CARGO) doc $(CARGO_DOC_OPTS) --workspace -p otter --no-deps
+stamp/cargo.doc: $(call rsrcs,.)
+       set -o pipefail -e; \
+       $(CARGO) doc $(CARGO_DOC_OPTS) --workspace 2>&1 \
+               |egrep -vf .cargo-doc-suppress-errors
        $(stamp)
 
 $(addprefix stamp/cargo.wasm-,$(DR)):: \
@@ -227,24 +251,56 @@ stamp/cargo.wasm-%: $(call rsrcs, base wasm Cargo.*)
        $(stamp)
 
 stamp/cargo.deploy-build: $(call rsrcs,.)
-       $(CARGO) build --target $(DEPLOY_ARCH) $(call cr,$(DEPLOY_RELEASE)) -p otter -p otter-daemon
+       $(CARGO) build --target $(DEPLOY_ARCH) $(call cr,$(DEPLOY_RELEASE)) -p otter -p otter-cli -p otter-daemon -p usvg
+       $(NAILING_CARGO_JUST_RUN) \
+       ln -sf otter $(abspath $(TARGET_DIR)/$(DEPLOY_ARCH))/$(DEPLOY_RELEASE)/otter-ssh-proxy
        $(stamp)
 
 #---------- sphnix ----------
 
-doc-sphinx: docs/html/index.html
+doc-sphinx:    docs/html/index.html \
+       $(foreach f, $(EXAMPLE_BUNDLES), docs/html/examples/$f.zip) \
+       $(addprefix docs/html/examples/, $(notdir $(wildcard specs/*.toml)))
        @echo 'Documentation can now be found here:'
        @echo '  file://$(PWD)/$<'
 
 docs/html/index.html: docs/conf.py $(wildcard docs/*.md docs/*.rst docs/*.png)
        $(SPHINXBUILD) -M html docs docs $(SPHINXOPTS)
 
+docs/html/examples/%.zip: examples/%.zip
+       mkdir -p docs/html/examples
+       rm -f $@ && ln $< $@
+
+docs/html/examples/%.toml: specs/%.toml
+       mkdir -p docs/html/examples
+       rm -f $@ && ln $< $@
+
+#---------- jstest ----------
+
+JSTESTS= basic lower
+
+.PHONY: jstest
+jstest jstests: $(foreach t,$(JSTESTS),stamp/$t.jstest)
+
+stamp/%.jstest: jstest/run1 jstest/%.nodejs templates/script.js \
+               stamp/wasm-bindgen-jstest stamp/cargo-jstest.debug
+       $(NAILING_CARGO_JUST_RUN) $(abspath $(filter-out stamp/%,$^))
+       $(stamp)
+
 #---------- wasm ----------
 
 $(addprefix $(WASM_PACKED)/,$(WASM_ASSETS) $(WASM_OUTPUTS)): stamp/wasm-bindgen
 stamp/wasm-bindgen: stamp/cargo.wasm-bindgen stamp/cargo.wasm-release
        $(NAILING_CARGO_JUST_RUN) $(abspath $(WASM_BINDGEN)) \
-               $(WASM_BINDGEN_OPTIONS) --out-dir target/packed-wasm \
+               $(WASM_BINDGEN_OPTIONS) --no-modules \
+               --out-dir target/packed-wasm \
+               target/$(WASM)/release/otter_wasm.wasm
+       $(stamp)
+
+stamp/wasm-bindgen-jstest: stamp/cargo.wasm-bindgen stamp/cargo.wasm-release
+       $(NAILING_CARGO_JUST_RUN) $(abspath $(WASM_BINDGEN)) \
+               $(WASM_BINDGEN_OPTIONS) --nodejs \
+               --out-dir target/jstest \
                target/$(WASM)/release/otter_wasm.wasm
        $(stamp)
 
@@ -285,7 +341,7 @@ bundled-sources::
 #---------- svg processing ----------
 
 LIBRARIES ?= $(basename $(wildcard library/*.toml))
-USVG_DEP = stamp/cargo.usvg
+USVG_DEP = stamp/cargo.usvg src/USVG_DEFAULT_ARGS.txt
 
 include $(addsuffix /files.make, $(LIBRARIES))
 
@@ -315,11 +371,19 @@ $(addprefix templates/,$(TXTFILES)): templates/%: %.txt
 
 libraries: $(LIBRARY_FILES)
 
-templates/shapelib.html: $(TARGET_DIR)/debug/otterlib $(LIBRARY_FILES)
+templates/shapelib.html: $(TARGET_DIR)/debug/otterlib $(LIBRARY_FILES) \
+                       $(NWTEMPLATEASSETS)
        $(NAILING_CARGO_JUST_RUN) $(abspath $<) \
+       --nwtemplates $(abspath nwtemplates) \
        --libs '$(addprefix $(PWD)/, $(addsuffix .toml, $(LIBRARIES)))' \
                preview >$@.tmp && mv -f $@.tmp $@
 
+nwtemplates/die-overlay.tera: dice/overlay-template-extractor dice/die.svg
+       ./$< <dice/die.svg >$@.tmp && mv -f $@.tmp $@
+
+library/edited/die-image-d6-_c.svg: dice/extract-image-only dice/die.svg
+       ./$< <dice/die.svg >$@.tmp && mv -f $@.tmp $@
+
 #---------- examples ----------
 
 EXAMPLE_BUNDLE_INPUT_DEPS := $(shell                                   \
@@ -328,10 +392,11 @@ EXAMPLE_BUNDLE_INPUT_DEPS := $(shell                                      \
 
 examples/%.zip: $(MAKEFILE_DEP)
        set -e; rm -f $@.tmp; cd examples/$*/; \
-       zip $(ZIPFLAGS) -DXy ../$(notdir $@).tmp $(ZIP_INPUTS)
+       zip $(ZIPFLAGS) -DX ../$(notdir $@).tmp $(ZIP_INPUTS)
        mv -f $@.tmp $@
 
-examples/test-bundle.zip: ZIP_INPUTS=$(EXAMPLE_BUNDLE_INPUT_DEPS) \
+examples/test-bundle.zip: ZIP_INPUTS=$(EXAMPLE_BUNDLE_INPUT_DEPS)
+examples/test-bundle.zip: \
  $(addprefix examples/test-bundle/, $(EXAMPLE_BUNDLE_INPUT_DEPS))
 
 examples/big-bundle.zip: examples/big-bundle/otter.toml
@@ -345,7 +410,8 @@ examples/big-bundle/otter.toml: $(LIBRARY_FILES) $(MAKEFILE_DEP)
                mkdir examples/big-bundle/$$l; \
                perl -p \
  -e 'BEGIN { print "# -- AUTOGENERATED FROM COPY IN OTTER SOURCE --\n" }' \
- -e 'next unless m/^\[scraper]/..0; next if m/^\[(?!scraper)/..0; s/^/\#/' \
+ -e 'if (m/^\[scraper]/..0) { unless (m/^\[(?!scraper)/..0) { s/^/\#/ } }' \
+ -e 's/(?<=\s)\w\S*(?=\s)/-/ if m/^files = """/..m/^"""|^:/;' \
                        <$$l.toml >examples/big-bundle/$$l.toml; done
        @set -e; echo 'LN for $@'; \
        for e in $(LIBRARY_FILE_INPUTS); do \
@@ -353,6 +419,10 @@ examples/big-bundle/otter.toml: $(LIBRARY_FILES) $(MAKEFILE_DEP)
        @set -e; echo 'MV for $@'; \
        cd examples/big-bundle/library/; for x in '' .toml; do \
                mv wikimedia$$x duped-example$$x; done
+       @set -e; mkdir examples/big-bundle/specs/; \
+       perl -pe <specs/demo.game.toml \
+               >examples/big-bundle/specs/Modded-spec.game.toml \
+               's/chess-b-/chess-purple-/; s/chess-w-/chess-yellow-/'
        @set -e; echo 'ECHO for $@'; \
        echo 'title = "Autogenerated test bundle - do not distribute"' \
                >$@.tmp
@@ -375,14 +445,15 @@ RUNTEST_DEPS =    apitest/run1 stamp/cargo.debug $(FILEASSETS) \
                $(wildcard libraries/*.toml) $(LIBRARY_FILES)
 
 AT_DEPS =      $(filter-out templates/script.js, $(RUNTEST_DEPS)) \
+               examples/big-bundle.zip \
                stamp/cargo-at.debug
 
-WDT_DEPS =     $(RUNTEST_DEPS) \
+WDT_DEPS =     $(RUNTEST_DEPS) wdriver/firefox-wrapper \
                stamp/cargo-wdt.debug
 
 AT_WDT_RUN = $(NAILING_CARGO_JUST_RUN) $(abspath $<)
 
-AT_RUN = $(AT_WDT_RUN) $(basename $(notdir $@))
+AT_RUN = $(AT_WDT_RUN) apitest --test=$(basename $(notdir $@))
 WDT_RUN = $(AT_WDT_RUN) wdriver --test=$(basename $(notdir $@))
 
 for-at:                        $(AT_DEPS)
@@ -401,13 +472,20 @@ stamp/wdt-%.lcheck:       $(WDT_DEPS)
 
 #---------- docs publication ----------
 
+PUBLISH_VERSION=unreleased
 PUBLISH_USER=ianmdlvl@login.chiark.greenend.org.uk
-PUBLISH_DOC_SPHINX=$(PUBLISH_USER):public-html/otter/docs
+PUBLISH_DOC_SPHINX_BASE=public-html/otter
+PUBLISH_DOC_SPHINX_TAIL=$(PUBLISH_VERSION)/docs
+PUBLISH_DOC_SPHINX=$(PUBLISH_USER):$(PUBLISH_DOC_SPHINX_BASE)/$(PUBLISH_DOC_SPHINX_TAIL)
 
 publish: doc-sphinx
+       ssh $(PUBLISH_USER) 'cd $(PUBLISH_DOC_SPHINX_BASE) && mkdir -p $(PUBLISH_DOC_SPHINX_TAIL)'
        rsync -r --delete-delay docs/html/. $(PUBLISH_DOC_SPHINX)/.
        git branch -f $(PUBLISHED_BRANCH)
 
+publish-make-current:
+       ssh $(PUBLISH_USER) 'set -e; cd $(PUBLISH_DOC_SPHINX_BASE); rm -f current.tmp; ln -s $(PUBLISH_VERSION) current.tmp; mv -T current.tmp current'
+
 #---------- deployment ----------
 
 DEPLOY_USER=ian@login.chiark.greenend.org.uk
@@ -416,8 +494,8 @@ DEPLOY_FINISH=/home/Otter/etc/deploy-finish
 
 for-deploy: stamp/cargo.deploy-build
 deploy: for-deploy bundled-sources assets libraries
-       rsync -zv --progress $(addprefix $(DEPLOY_TARGET_DIR)/,$(PROGRAMS)) $(DEPLOY_BASE)/bin/
-       rsync -zv --progress $(TARGET_DIR)/release/usvg $(DEPLOY_BASE)/libexec/
+       rsync -zvl --progress $(addprefix $(DEPLOY_TARGET_DIR)/,$(PROGRAMS) otter-ssh-proxy) $(DEPLOY_BASE)/bin/
+       rsync -zv --progress $(DEPLOY_TARGET_DIR)/usvg $(DEPLOY_BASE)/libexec/
        rsync -rv --progress $(TARGET_DIR)/bundled-sources/. $(DEPLOY_BASE)/bundled-sources
        rsync -r README.md $(DEPLOY_BASE)/.
        rsync -r --delete --exclude=\*~ library specs $(DEPLOY_BASE)/.