chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Simplify execute_directory()
[elogind.git]
/
src
/
sleep
/
sleep.c
diff --git
a/src/sleep/sleep.c
b/src/sleep/sleep.c
index 3b0e927c42966908cca6e429beba959a4d01df64..2fb5f0c8e049167801a1416453cf9adcf73fdd3f 100644
(file)
--- a/
src/sleep/sleep.c
+++ b/
src/sleep/sleep.c
@@
-48,15
+48,14
@@
static int write_mode(char **modes) {
if (k == 0)
return 0;
if (k == 0)
return 0;
- log_debug
("Failed to write '%s' to /sys/power/disk: %s
",
-
*mode, strerror(-k)
);
+ log_debug
_errno(k, "Failed to write '%s' to /sys/power/disk: %m
",
+
*mode
);
if (r == 0)
r = k;
}
if (r < 0)
if (r == 0)
r = k;
}
if (r < 0)
- log_error("Failed to write mode to /sys/power/disk: %s",
- strerror(-r));
+ log_error_errno(r, "Failed to write mode to /sys/power/disk: %m");
return r;
}
return r;
}
@@
-71,51
+70,49
@@
static int write_state(FILE **f, char **states) {
k = write_string_stream(*f, *state);
if (k == 0)
return 0;
k = write_string_stream(*f, *state);
if (k == 0)
return 0;
- log_debug
("Failed to write '%s' to /sys/power/state: %s
",
-
*state, strerror(-k)
);
+ log_debug
_errno(k, "Failed to write '%s' to /sys/power/state: %m
",
+
*state
);
if (r == 0)
r = k;
fclose(*f);
*f = fopen("/sys/power/state", "we");
if (r == 0)
r = k;
fclose(*f);
*f = fopen("/sys/power/state", "we");
- if (!*f) {
- log_error("Failed to open /sys/power/state: %m");
- return -errno;
- }
+ if (!*f)
+ return log_error_errno(errno, "Failed to open /sys/power/state: %m");
}
return r;
}
static int execute(char **modes, char **states) {
}
return r;
}
static int execute(char **modes, char **states) {
- char* arguments[4];
+
+ char *arguments[] = {
+ NULL,
+ (char*) "pre",
+ arg_verb,
+ NULL
+ };
+
int r;
_cleanup_fclose_ FILE *f = NULL;
int r;
_cleanup_fclose_ FILE *f = NULL;
- const char* note = strappenda("SLEEP=", arg_verb);
/* This file is opened first, so that if we hit an error,
* we can abort before modifying any state. */
f = fopen("/sys/power/state", "we");
/* This file is opened first, so that if we hit an error,
* we can abort before modifying any state. */
f = fopen("/sys/power/state", "we");
- if (!f) {
- log_error("Failed to open /sys/power/state: %m");
- return -errno;
- }
+ if (!f)
+ return log_error_errno(errno, "Failed to open /sys/power/state: %m");
/* Configure the hibernation mode */
r = write_mode(modes);
if (r < 0)
return r;
/* Configure the hibernation mode */
r = write_mode(modes);
if (r < 0)
return r;
- arguments[0] = NULL;
- arguments[1] = (char*) "pre";
- arguments[2] = arg_verb;
- arguments[3] = NULL;
- execute_directory(SYSTEM_SLEEP_PATH, NULL, DEFAULT_TIMEOUT_USEC, arguments, NULL);
+ execute_directory(SYSTEM_SLEEP_PATH, DEFAULT_TIMEOUT_USEC, arguments);
log_struct(LOG_INFO,
log_struct(LOG_INFO,
- MESSAGE_ID(SD_MESSAGE_SLEEP_START),
-
"MESSAGE=Suspending system..."
,
-
note
,
+
LOG_
MESSAGE_ID(SD_MESSAGE_SLEEP_START),
+
LOG_MESSAGE("Suspending system...")
,
+
"SLEEP=%s", arg_verb
,
NULL);
r = write_state(&f, states);
NULL);
r = write_state(&f, states);
@@
-123,19
+120,18
@@
static int execute(char **modes, char **states) {
return r;
log_struct(LOG_INFO,
return r;
log_struct(LOG_INFO,
- MESSAGE_ID(SD_MESSAGE_SLEEP_STOP),
-
"MESSAGE=System resumed."
,
-
note
,
+
LOG_
MESSAGE_ID(SD_MESSAGE_SLEEP_STOP),
+
LOG_MESSAGE("System resumed.")
,
+
"SLEEP=%s", arg_verb
,
NULL);
arguments[1] = (char*) "post";
NULL);
arguments[1] = (char*) "post";
- execute_directory(SYSTEM_SLEEP_PATH,
NULL, DEFAULT_TIMEOUT_USEC, arguments, NULL
);
+ execute_directory(SYSTEM_SLEEP_PATH,
DEFAULT_TIMEOUT_USEC, arguments
);
return r;
}
return r;
}
-static int help(void) {
-
+static void help(void) {
printf("%s COMMAND\n\n"
"Suspend the system, hibernate the system, or both.\n\n"
"Commands:\n"
printf("%s COMMAND\n\n"
"Suspend the system, hibernate the system, or both.\n\n"
"Commands:\n"
@@
-144,10
+140,7
@@
static int help(void) {
" suspend Suspend the system\n"
" hibernate Hibernate the system\n"
" hybrid-sleep Both hibernate and suspend the system\n"
" suspend Suspend the system\n"
" hibernate Hibernate the system\n"
" hybrid-sleep Both hibernate and suspend the system\n"
- , program_invocation_short_name
- );
-
- return 0;
+ , program_invocation_short_name);
}
static int parse_argv(int argc, char *argv[]) {
}
static int parse_argv(int argc, char *argv[]) {
@@
-166,10
+159,11
@@
static int parse_argv(int argc, char *argv[]) {
assert(argc >= 0);
assert(argv);
assert(argc >= 0);
assert(argv);
- while ((c = getopt_long(argc, argv, "
+
h", options, NULL)) >= 0)
+ while ((c = getopt_long(argc, argv, "h", options, NULL)) >= 0)
switch(c) {
case 'h':
switch(c) {
case 'h':
- return help();
+ help();
+ return 0; /* done */
case ARG_VERSION:
puts(PACKAGE_STRING);
case ARG_VERSION:
puts(PACKAGE_STRING);