chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Prep v227: Clean up various *-util.[hc] files
[elogind.git]
/
src
/
shared
/
pager.c
diff --git
a/src/shared/pager.c
b/src/shared/pager.c
index f1f3dc7e7edb41a3c5d9320ffa02b7557efe5217..bc2d0372c86983d70b622745af8ed79c174ec469 100644
(file)
--- a/
src/shared/pager.c
+++ b/
src/shared/pager.c
@@
-38,7
+38,7
@@
static pid_t pager_pid = 0;
noreturn static void pager_fallback(void) {
int r;
noreturn static void pager_fallback(void) {
int r;
- r = copy_bytes(STDIN_FILENO, STDOUT_FILENO, (
off
_t) -1, false);
+ r = copy_bytes(STDIN_FILENO, STDOUT_FILENO, (
uint64
_t) -1, false);
if (r < 0) {
log_error_errno(r, "Internal pager failed: %m");
_exit(EXIT_FAILURE);
if (r < 0) {
log_error_errno(r, "Internal pager failed: %m");
_exit(EXIT_FAILURE);
@@
-48,24
+48,27
@@
noreturn static void pager_fallback(void) {
}
int pager_open(bool jump_to_end) {
}
int pager_open(bool jump_to_end) {
-
int fd[2]
;
+
_cleanup_close_pair_ int fd[2] = { -1, -1 }
;
const char *pager;
pid_t parent_pid;
const char *pager;
pid_t parent_pid;
- int r;
if (pager_pid > 0)
return 1;
if (pager_pid > 0)
return 1;
- if ((pager = getenv("SYSTEMD_PAGER")) || (pager = getenv("PAGER")))
- if (!*pager || streq(pager, "cat"))
+ if (!on_tty())
return 0;
return 0;
- if (!on_tty())
+ pager = getenv("SYSTEMD_PAGER");
+ if (!pager)
+ pager = getenv("PAGER");
+
+ /* If the pager is explicitly turned off, honour it */
+ if (pager && (pager[0] == 0 || streq(pager, "cat")))
return 0;
/* Determine and cache number of columns before we spawn the
* pager so that we get the value from the actual tty */
return 0;
/* Determine and cache number of columns before we spawn the
* pager so that we get the value from the actual tty */
- columns();
+
(void)
columns();
if (pipe(fd) < 0)
return log_error_errno(errno, "Failed to create pager pipe: %m");
if (pipe(fd) < 0)
return log_error_errno(errno, "Failed to create pager pipe: %m");
@@
-73,12
+76,8
@@
int pager_open(bool jump_to_end) {
parent_pid = getpid();
pager_pid = fork();
parent_pid = getpid();
pager_pid = fork();
- if (pager_pid < 0) {
- r = -errno;
- log_error_errno(errno, "Failed to fork pager: %m");
- safe_close_pair(fd);
- return r;
- }
+ if (pager_pid < 0)
+ return log_error_errno(errno, "Failed to fork pager: %m");
/* In the child start the pager */
if (pager_pid == 0) {
/* In the child start the pager */
if (pager_pid == 0) {
@@
-87,7
+86,7
@@
int pager_open(bool jump_to_end) {
(void) reset_all_signal_handlers();
(void) reset_signal_mask();
(void) reset_all_signal_handlers();
(void) reset_signal_mask();
- dup2(fd[0], STDIN_FILENO);
+
(void)
dup2(fd[0], STDIN_FILENO);
safe_close_pair(fd);
/* Initialize a good set of less options */
safe_close_pair(fd);
/* Initialize a good set of less options */
@@
-142,7
+141,6
@@
int pager_open(bool jump_to_end) {
if (dup2(fd[1], STDERR_FILENO) < 0)
return log_error_errno(errno, "Failed to duplicate pager pipe: %m");
if (dup2(fd[1], STDERR_FILENO) < 0)
return log_error_errno(errno, "Failed to duplicate pager pipe: %m");
- safe_close_pair(fd);
return 1;
}
return 1;
}
@@
-152,17
+150,10
@@
void pager_close(void) {
return;
/* Inform pager that we are done */
return;
/* Inform pager that we are done */
- fclose(stdout);
-#if defined(__GLIBC__)
- stdout = NULL;
-#endif // in musl-libc this is a const
-
- fclose(stderr);
-#if defined(__GLIBC__)
- stderr = NULL;
-#endif // in musl-libc this is a const
+ stdout = safe_fclose(stdout);
+ stderr = safe_fclose(stderr);
- kill(pager_pid, SIGCONT);
+
(void)
kill(pager_pid, SIGCONT);
(void) wait_for_terminate(pager_pid, NULL);
pager_pid = 0;
}
(void) wait_for_terminate(pager_pid, NULL);
pager_pid = 0;
}