chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
coverity: fix a couple of bugs found by coverity
[elogind.git]
/
src
/
service.c
diff --git
a/src/service.c
b/src/service.c
index a40e01b88818b99978c11da68c8ba81a9fdfd422..2ae8785ac4e484f13fe21d8fa25beac85752a1b4 100644
(file)
--- a/
src/service.c
+++ b/
src/service.c
@@
-1281,7
+1281,7
@@
static void service_dump(Unit *u, FILE *f, const char *prefix) {
free(p2);
}
free(p2);
}
-static int service_load_pid_file(Service *s) {
+static int service_load_pid_file(Service *s
, bool warn_if_missing
) {
char *k;
int r;
pid_t pid;
char *k;
int r;
pid_t pid;
@@
-1291,8
+1291,12
@@
static int service_load_pid_file(Service *s) {
if (!s->pid_file)
return -ENOENT;
if (!s->pid_file)
return -ENOENT;
- if ((r = read_one_line_file(s->pid_file, &k)) < 0)
+ if ((r = read_one_line_file(s->pid_file, &k)) < 0) {
+ if (warn_if_missing)
+ log_warning("Failed to read PID file %s after %s. The service might be broken.",
+ s->pid_file, service_state_to_string(s->state));
return r;
return r;
+ }
r = parse_pid(k, &pid);
free(k);
r = parse_pid(k, &pid);
free(k);
@@
-2604,7
+2608,7
@@
static void service_sigchld_event(Unit *u, pid_t pid, int code, int status) {
/* Forking services may occasionally move to a new PID.
* As long as they update the PID file before exiting the old
* PID, they're fine. */
/* Forking services may occasionally move to a new PID.
* As long as they update the PID file before exiting the old
* PID, they're fine. */
- if (service_load_pid_file(s) == 0)
+ if (service_load_pid_file(s
, false
) == 0)
return;
s->main_pid = 0;
return;
s->main_pid = 0;
@@
-2736,7
+2740,7
@@
static void service_sigchld_event(Unit *u, pid_t pid, int code, int status) {
* START_POST script */
if (success) {
* START_POST script */
if (success) {
- service_load_pid_file(s);
+ service_load_pid_file(s
, !s->exec_command[SERVICE_EXEC_START_POST]
);
service_search_main_pid(s);
service_enter_start_post(s);
service_search_main_pid(s);
service_enter_start_post(s);
@@
-2747,7
+2751,7
@@
static void service_sigchld_event(Unit *u, pid_t pid, int code, int status) {
case SERVICE_START_POST:
if (success) {
case SERVICE_START_POST:
if (success) {
- service_load_pid_file(s);
+ service_load_pid_file(s
, true
);
service_search_main_pid(s);
}
service_search_main_pid(s);
}
@@
-2757,7
+2761,7
@@
static void service_sigchld_event(Unit *u, pid_t pid, int code, int status) {
case SERVICE_RELOAD:
if (success) {
case SERVICE_RELOAD:
if (success) {
- service_load_pid_file(s);
+ service_load_pid_file(s
, true
);
service_search_main_pid(s);
}
service_search_main_pid(s);
}
@@
-3111,7
+3115,7
@@
static int service_enumerate(Manager *m) {
free(fpath);
fpath = join(path, "/", de->d_name, NULL);
free(fpath);
fpath = join(path, "/", de->d_name, NULL);
- if (!path) {
+ if (!
f
path) {
r = -ENOMEM;
goto finish;
}
r = -ENOMEM;
goto finish;
}