chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
machinectl: fix success check when getting pty from within container
[elogind.git]
/
src
/
network
/
networkd-bridge.c
diff --git
a/src/network/networkd-bridge.c
b/src/network/networkd-bridge.c
index 1704f65ee679c89caa6528fec39b652bde13a1d6..f110b8aa12c770adb5937b23ef40223b5394a49d 100644
(file)
--- a/
src/network/networkd-bridge.c
+++ b/
src/network/networkd-bridge.c
@@
-84,14
+84,14
@@
static int bridge_join_ready(Bridge *bridge, Link* link, sd_rtnl_message_handler
assert(link);
assert(callback);
assert(link);
assert(callback);
- r = sd_rtnl_message_link_new(RTM_SETLINK, link->ifindex,
0, 0,
&req);
+ r = sd_rtnl_message_link_new(RTM_SETLINK, link->ifindex, &req);
if (r < 0) {
log_error("Could not allocate RTM_SETLINK message: %s",
strerror(-r));
return r;
}
if (r < 0) {
log_error("Could not allocate RTM_SETLINK message: %s",
strerror(-r));
return r;
}
- r = sd_rtnl_message_append
(req, IFLA_MASTER, &
bridge->link->ifindex);
+ r = sd_rtnl_message_append
_u32(req, IFLA_MASTER,
bridge->link->ifindex);
if (r < 0) {
log_error("Could not append IFLA_MASTER attribute: %s",
strerror(-r));
if (r < 0) {
log_error("Could not append IFLA_MASTER attribute: %s",
strerror(-r));
@@
-139,8
+139,8
@@
static int bridge_create_handler(sd_rtnl *rtnl, sd_rtnl_message *m, void *userda
if (bridge->link)
bridge_enter_ready(bridge);
if (bridge->link)
bridge_enter_ready(bridge);
-
- bridge->state = BRIDGE_STATE_CREATED;
+ else
+
bridge->state = BRIDGE_STATE_CREATED;
return 1;
}
return 1;
}
@@
-155,14
+155,14
@@
static int bridge_create(Bridge *bridge) {
assert(bridge->manager);
assert(bridge->manager->rtnl);
assert(bridge->manager);
assert(bridge->manager->rtnl);
- r = sd_rtnl_message_link_new(RTM_NEWLINK, 0,
0, 0,
&req);
+ r = sd_rtnl_message_link_new(RTM_NEWLINK, 0, &req);
if (r < 0) {
log_error("Could not allocate RTM_NEWLINK message: %s",
strerror(-r));
return r;
}
if (r < 0) {
log_error("Could not allocate RTM_NEWLINK message: %s",
strerror(-r));
return r;
}
- r = sd_rtnl_message_append(req, IFLA_IFNAME, bridge->name);
+ r = sd_rtnl_message_append
_string
(req, IFLA_IFNAME, bridge->name);
if (r < 0) {
log_error("Could not append IFLA_IFNAME attribute: %s",
strerror(-r));
if (r < 0) {
log_error("Could not append IFLA_IFNAME attribute: %s",
strerror(-r));
@@
-176,7
+176,7
@@
static int bridge_create(Bridge *bridge) {
return r;
}
return r;
}
- r = sd_rtnl_message_append(req, IFLA_INFO_KIND, "bridge");
+ r = sd_rtnl_message_append
_string
(req, IFLA_INFO_KIND, "bridge");
if (r < 0) {
log_error("Could not append IFLA_INFO_KIND attribute: %s",
strerror(-r));
if (r < 0) {
log_error("Could not append IFLA_INFO_KIND attribute: %s",
strerror(-r));
@@
-246,6
+246,9
@@
static int bridge_load_one(Manager *manager, const char *filename) {
_cleanup_fclose_ FILE *file = NULL;
int r;
_cleanup_fclose_ FILE *file = NULL;
int r;
+ assert(manager);
+ assert(filename);
+
file = fopen(filename, "re");
if (!file) {
if (errno == ENOENT)
file = fopen(filename, "re");
if (!file) {
if (errno == ENOENT)