chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
systemd-coredump: Log crashes without coredumps on failure
[elogind.git]
/
src
/
journal
/
coredumpctl.c
diff --git
a/src/journal/coredumpctl.c
b/src/journal/coredumpctl.c
index 0bbfff2ecdc30aec0afac4c0eb7590822b7ac048..75c96cc08112e41fff61c2181ba463dcfaf4bcaa 100644
(file)
--- a/
src/journal/coredumpctl.c
+++ b/
src/journal/coredumpctl.c
@@
-68,10
+68,9
@@
static Set *new_matches(void) {
return NULL;
}
return NULL;
}
- r = set_
put
(set, tmp);
+ r = set_
consume
(set, tmp);
if (r < 0) {
log_error("failed to add to set: %s", strerror(-r));
if (r < 0) {
log_error("failed to add to set: %s", strerror(-r));
- free(tmp);
set_free(set);
return NULL;
}
set_free(set);
return NULL;
}
@@
-85,6
+84,7
@@
static int help(void) {
"Flags:\n"
" -o --output=FILE Write output to FILE\n"
" --no-pager Do not pipe output into a pager\n"
"Flags:\n"
" -o --output=FILE Write output to FILE\n"
" --no-pager Do not pipe output into a pager\n"
+ " --no-legend Do not print the column headers.\n\n"
"Commands:\n"
" -h --help Show this help\n"
"Commands:\n"
" -h --help Show this help\n"
@@
-125,18
+125,17
@@
static int add_match(Set *set, const char *match) {
if (!pattern)
goto fail;
if (!pattern)
goto fail;
- r = set_put(set, pattern);
+ log_debug("Adding pattern: %s", pattern);
+ r = set_consume(set, pattern);
if (r < 0) {
if (r < 0) {
- log_error("
f
ailed to add pattern '%s': %s",
+ log_error("
F
ailed to add pattern '%s': %s",
pattern, strerror(-r));
goto fail;
}
pattern, strerror(-r));
goto fail;
}
- log_debug("Added pattern: %s", pattern);
return 0;
fail:
return 0;
fail:
- free(pattern);
- log_error("failed to add match: %s", strerror(-r));
+ log_error("Failed to add match: %s", strerror(-r));
return r;
}
return r;
}
@@
-343,7
+342,7
@@
static int dump_list(sd_journal *j) {
assert(j);
/* The coredumps are likely to compressed, and for just
assert(j);
/* The coredumps are likely to compressed, and for just
- * listing them we don
#
t need to decompress them, so let's
+ * listing them we don
'
t need to decompress them, so let's
* pick a fairly low data threshold here */
sd_journal_set_data_threshold(j, 4096);
* pick a fairly low data threshold here */
sd_journal_set_data_threshold(j, 4096);
@@
-558,6
+557,13
@@
int main(int argc, char *argv[]) {
}
}
}
}
+ if (_unlikely_(log_get_max_level() >= LOG_PRI(LOG_DEBUG))) {
+ _cleanup_free_ char *filter;
+
+ filter = journal_make_match_string(j);
+ log_debug("Journal filter: %s", filter);
+ }
+
switch(arg_action) {
case ACTION_LIST:
switch(arg_action) {
case ACTION_LIST: