chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
util: when using basename() for creating temporary files, verify the resulting name...
[elogind.git]
/
src
/
journal
/
coredump.c
diff --git
a/src/journal/coredump.c
b/src/journal/coredump.c
index be45a684e5aadc8f6592b50911ab38daca6c74dd..8678ec6a59e131db22ac43924728eafd0d7dee9f 100644
(file)
--- a/
src/journal/coredump.c
+++ b/
src/journal/coredump.c
@@
-306,9
+306,9
@@
static int save_external_coredump(
if (r < 0)
return log_error_errno(r, "Failed to determine coredump file name: %m");
if (r < 0)
return log_error_errno(r, "Failed to determine coredump file name: %m");
-
tmp = tempfn_random(fn
);
- if (
!tmp
)
- return log_
oom(
);
+
r = tempfn_random(fn, &tmp
);
+ if (
r < 0
)
+ return log_
error_errno(r, "Failed to determine temporary file name: %m"
);
mkdir_p_label("/var/lib/systemd/coredump", 0755);
mkdir_p_label("/var/lib/systemd/coredump", 0755);
@@
-352,9
+352,9
@@
static int save_external_coredump(
goto uncompressed;
}
goto uncompressed;
}
-
tmp_compressed = tempfn_random(fn
_compressed);
- if (
!tmp_compressed
) {
- log_
oom(
);
+
r = tempfn_random(fn_compressed, &tmp
_compressed);
+ if (
r < 0
) {
+ log_
error_errno(r, "Failed to determine temporary file name for %s: %m", fn_compressed
);
goto uncompressed;
}
goto uncompressed;
}