chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
udev: builtin-hwdb - port to sd-hwdb
[elogind.git]
/
src
/
bootchart
/
store.c
diff --git
a/src/bootchart/store.c
b/src/bootchart/store.c
index e0719838d5089a6e369ae546715335fc4b4c91c2..a66387c304bd18cabe749ee7b7d8324a71d90a63 100644
(file)
--- a/
src/bootchart/store.c
+++ b/
src/bootchart/store.c
@@
-34,6
+34,7
@@
#include <time.h>
#include "util.h"
#include <time.h>
#include "util.h"
+#include "time-util.h"
#include "strxcpyx.h"
#include "store.h"
#include "bootchart.h"
#include "strxcpyx.h"
#include "store.h"
#include "bootchart.h"
@@
-54,30
+55,25
@@
double gettime_ns(void) {
clock_gettime(CLOCK_MONOTONIC, &n);
clock_gettime(CLOCK_MONOTONIC, &n);
- return (n.tv_sec + (n.tv_nsec /
1000000000.0
));
+ return (n.tv_sec + (n.tv_nsec /
(double) NSEC_PER_SEC
));
}
}
-void log_uptime(void) {
- _cleanup_fclose_ FILE *f = NULL;
- char str[32];
- double uptime;
-
- f = fopen("/proc/uptime", "re");
-
- if (!f)
- return;
- if (!fscanf(f, "%s %*s", str))
- return;
-
- uptime = strtod(str, NULL);
+static double gettime_up(void) {
+ struct timespec n;
- log_start = gettime_ns();
+ clock_gettime(CLOCK_BOOTTIME, &n);
+ return (n.tv_sec + (n.tv_nsec / (double) NSEC_PER_SEC));
+}
- /* start graph at kernel boot time */
+void log_uptime(void) {
if (arg_relative)
if (arg_relative)
- graph_start = log_start;
- else
+ graph_start = log_start = gettime_ns();
+ else {
+ double uptime = gettime_up();
+
+ log_start = gettime_ns();
graph_start = log_start - uptime;
graph_start = log_start - uptime;
+ }
}
static char *bufgetline(char *buf) {
}
static char *bufgetline(char *buf) {
@@
-150,7
+146,7
@@
void log_sample(int sample, struct list_sample_data **ptr) {
/* block stuff */
vmstat = openat(procfd, "vmstat", O_RDONLY);
if (vmstat == -1) {
/* block stuff */
vmstat = openat(procfd, "vmstat", O_RDONLY);
if (vmstat == -1) {
- log_error
(
"Failed to open /proc/vmstat: %m");
+ log_error
_errno(errno,
"Failed to open /proc/vmstat: %m");
exit(EXIT_FAILURE);
}
}
exit(EXIT_FAILURE);
}
}
@@
-182,7
+178,7
@@
vmstat_next:
/* overall CPU utilization */
schedstat = openat(procfd, "schedstat", O_RDONLY);
if (schedstat == -1) {
/* overall CPU utilization */
schedstat = openat(procfd, "schedstat", O_RDONLY);
if (schedstat == -1) {
- log_error
(
"Failed to open /proc/schedstat: %m");
+ log_error
_errno(errno,
"Failed to open /proc/schedstat: %m");
exit(EXIT_FAILURE);
}
}
exit(EXIT_FAILURE);
}
}
@@
-196,12
+192,14
@@
vmstat_next:
m = buf;
while (m) {
m = buf;
while (m) {
+ int r;
+
if (sscanf(m, "%s %*s %*s %*s %*s %*s %*s %s %s", key, rt, wt) < 3)
goto schedstat_next;
if (strstr(key, "cpu")) {
if (sscanf(m, "%s %*s %*s %*s %*s %*s %*s %s %s", key, rt, wt) < 3)
goto schedstat_next;
if (strstr(key, "cpu")) {
-
c = atoi((const char*)(key+3)
);
- if (
c > MAXCPUS
)
+
r = safe_atoi((const char*)(key+3), &c
);
+ if (
r < 0 || c > MAXCPUS -1
)
/* Oops, we only have room for MAXCPUS data */
break;
sampledata->runtime[c] = atoll(rt);
/* Oops, we only have room for MAXCPUS data */
break;
sampledata->runtime[c] = atoll(rt);
@@
-255,6
+253,7
@@
schedstat_next:
_cleanup_fclose_ FILE *st = NULL;
char t[32];
struct ps_struct *parent;
_cleanup_fclose_ FILE *st = NULL;
char t[32];
struct ps_struct *parent;
+ int r;
ps->next_ps = new0(struct ps_struct, 1);
if (!ps->next_ps) {
ps->next_ps = new0(struct ps_struct, 1);
if (!ps->next_ps) {
@@
-314,7
+313,11
@@
schedstat_next:
if (!sscanf(m, "%*s %*s %s", t))
continue;
if (!sscanf(m, "%*s %*s %s", t))
continue;
- ps->starttime = strtod(t, NULL) / 1000.0;
+ r = safe_atod(t, &ps->starttime);
+ if (r < 0)
+ continue;
+
+ ps->starttime /= 1000.0;
if (arg_show_cgroup)
/* if this fails, that's OK */
if (arg_show_cgroup)
/* if this fails, that's OK */
@@
-398,7
+401,7
@@
schedstat_next:
continue;
ps->sample->next = new0(struct ps_sched_struct, 1);
continue;
ps->sample->next = new0(struct ps_sched_struct, 1);
- if (!ps->sample) {
+ if (!ps->sample
->next
) {
log_oom();
exit(EXIT_FAILURE);
}
log_oom();
exit(EXIT_FAILURE);
}