chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Remove src/boot
[elogind.git]
/
src
/
bootchart
/
bootchart.c
diff --git
a/src/bootchart/bootchart.c
b/src/bootchart/bootchart.c
index 1024f78fa649473e0cc66ad81ede68982b0d306e..65cb3226e515a63931386e5ae76c72cd89cbd2b3 100644
(file)
--- a/
src/bootchart/bootchart.c
+++ b/
src/bootchart/bootchart.c
@@
-58,16
+58,7
@@
#include "bootchart.h"
#include "list.h"
#include "bootchart.h"
#include "list.h"
-double graph_start;
-double log_start;
-struct ps_struct *ps_first;
-int pscount;
-int cpus;
-double interval;
-FILE *of = NULL;
-int overrun = 0;
static int exiting = 0;
static int exiting = 0;
-int sysfd=-1;
#define DEFAULT_SAMPLES_LEN 500
#define DEFAULT_HZ 25.0
#define DEFAULT_SAMPLES_LEN 500
#define DEFAULT_HZ 25.0
@@
-78,27
+69,22
@@
int sysfd=-1;
/* graph defaults */
bool arg_entropy = false;
/* graph defaults */
bool arg_entropy = false;
-bool initcall = true;
+bool
arg_
initcall = true;
bool arg_relative = false;
bool arg_filter = true;
bool arg_show_cmdline = false;
bool arg_show_cgroup = false;
bool arg_pss = false;
bool arg_percpu = false;
bool arg_relative = false;
bool arg_filter = true;
bool arg_show_cmdline = false;
bool arg_show_cgroup = false;
bool arg_pss = false;
bool arg_percpu = false;
-int samples;
int arg_samples_len = DEFAULT_SAMPLES_LEN; /* we record len+1 (1 start sample) */
double arg_hz = DEFAULT_HZ;
double arg_scale_x = DEFAULT_SCALE_X;
double arg_scale_y = DEFAULT_SCALE_Y;
int arg_samples_len = DEFAULT_SAMPLES_LEN; /* we record len+1 (1 start sample) */
double arg_hz = DEFAULT_HZ;
double arg_scale_x = DEFAULT_SCALE_X;
double arg_scale_y = DEFAULT_SCALE_Y;
-static struct list_sample_data *sampledata;
-struct list_sample_data *head;
char arg_init_path[PATH_MAX] = DEFAULT_INIT;
char arg_output_path[PATH_MAX] = DEFAULT_OUTPUT;
static void signal_handler(int sig) {
char arg_init_path[PATH_MAX] = DEFAULT_INIT;
char arg_output_path[PATH_MAX] = DEFAULT_OUTPUT;
static void signal_handler(int sig) {
- if (sig++)
- sig--;
exiting = 1;
}
exiting = 1;
}
@@
-265,43
+251,41
@@
static int parse_argv(int argc, char *argv[]) {
return 1;
}
return 1;
}
-static void do_journal_append(char *file) {
+static int do_journal_append(char *file) {
+ _cleanup_free_ char *bootchart_message = NULL;
+ _cleanup_free_ char *bootchart_file = NULL;
+ _cleanup_free_ char *p = NULL;
+ _cleanup_close_ int fd = -1;
struct iovec iovec[5];
int r, j = 0;
ssize_t n;
struct iovec iovec[5];
int r, j = 0;
ssize_t n;
- _cleanup_free_ char *bootchart_file = NULL, *bootchart_message = NULL,
- *p = NULL;
- _cleanup_close_ int fd = -1;
bootchart_file = strappend("BOOTCHART_FILE=", file);
bootchart_file = strappend("BOOTCHART_FILE=", file);
- if (bootchart_file)
-
IOVEC_SET_STRING(iovec[j++], bootchart_file
);
+ if (
!
bootchart_file)
+
return log_oom(
);
+ IOVEC_SET_STRING(iovec[j++], bootchart_file);
IOVEC_SET_STRING(iovec[j++], "MESSAGE_ID=9f26aa562cf440c2b16c773d0479b518");
IOVEC_SET_STRING(iovec[j++], "PRIORITY=7");
bootchart_message = strjoin("MESSAGE=Bootchart created: ", file, NULL);
IOVEC_SET_STRING(iovec[j++], "MESSAGE_ID=9f26aa562cf440c2b16c773d0479b518");
IOVEC_SET_STRING(iovec[j++], "PRIORITY=7");
bootchart_message = strjoin("MESSAGE=Bootchart created: ", file, NULL);
- if (bootchart_message)
-
IOVEC_SET_STRING(iovec[j++], bootchart_message
);
+ if (
!
bootchart_message)
+
return log_oom(
);
-
p = malloc(9 + BOOTCHART_MAX
);
- if (!p) {
-
log_oom(
);
- return;
- }
+
IOVEC_SET_STRING(iovec[j++], bootchart_message
);
+
+
p = malloc(10 + BOOTCHART_MAX
);
+ if (!p)
+ return log_oom();
memcpy(p, "BOOTCHART=", 10);
fd = open(file, O_RDONLY|O_CLOEXEC);
memcpy(p, "BOOTCHART=", 10);
fd = open(file, O_RDONLY|O_CLOEXEC);
- if (fd < 0) {
- log_error_errno(errno, "Failed to open bootchart data \"%s\": %m", file);
- return;
- }
+ if (fd < 0)
+ return log_error_errno(errno, "Failed to open bootchart data \"%s\": %m", file);
n = loop_read(fd, p + 10, BOOTCHART_MAX, false);
n = loop_read(fd, p + 10, BOOTCHART_MAX, false);
- if (n < 0) {
- log_error_errno(n, "Failed to read bootchart data: %m");
- return;
- }
+ if (n < 0)
+ return log_error_errno(n, "Failed to read bootchart data: %m");
iovec[j].iov_base = p;
iovec[j].iov_len = 10 + n;
iovec[j].iov_base = p;
iovec[j].iov_len = 10 + n;
@@
-310,20
+294,33
@@
static void do_journal_append(char *file) {
r = sd_journal_sendv(iovec, j);
if (r < 0)
log_error_errno(r, "Failed to send bootchart: %m");
r = sd_journal_sendv(iovec, j);
if (r < 0)
log_error_errno(r, "Failed to send bootchart: %m");
+
+ return 0;
}
int main(int argc, char *argv[]) {
}
int main(int argc, char *argv[]) {
+ static struct list_sample_data *sampledata;
+ _cleanup_closedir_ DIR *proc = NULL;
_cleanup_free_ char *build = NULL;
_cleanup_free_ char *build = NULL;
- struct sigaction sig = {
- .sa_handler = signal_handler,
- };
- struct ps_struct *ps;
+ _cleanup_fclose_ FILE *of = NULL;
+ _cleanup_close_ int sysfd = -1;
+ struct ps_struct *ps_first;
+ double graph_start;
+ double log_start;
+ double interval;
char output_file[PATH_MAX];
char datestr[200];
char output_file[PATH_MAX];
char datestr[200];
+ int pscount = 0;
+ int n_cpus = 0;
+ int overrun = 0;
time_t t = 0;
time_t t = 0;
- int r;
+ int r, samples;
+ struct ps_struct *ps;
struct rlimit rlim;
struct rlimit rlim;
- bool has_procfs = false;
+ struct list_sample_data *head;
+ struct sigaction sig = {
+ .sa_handler = signal_handler,
+ };
parse_conf();
parse_conf();
@@
-364,7
+361,18
@@
int main(int argc, char *argv[]) {
interval = (1.0 / arg_hz) * 1000000000.0;
interval = (1.0 / arg_hz) * 1000000000.0;
- log_uptime();
+ if (arg_relative)
+ graph_start = log_start = gettime_ns();
+ else {
+ struct timespec n;
+ double uptime;
+
+ clock_gettime(CLOCK_BOOTTIME, &n);
+ uptime = (n.tv_sec + (n.tv_nsec / (double) NSEC_PER_SEC));
+
+ log_start = gettime_ns();
+ graph_start = log_start - uptime;
+ }
if (graph_start < 0.0) {
log_error("Failed to setup graph start time.\n\n"
if (graph_start < 0.0) {
log_error("Failed to setup graph start time.\n\n"
@@
-373,8
+381,6
@@
int main(int argc, char *argv[]) {
return EXIT_FAILURE;
}
return EXIT_FAILURE;
}
- has_procfs = access("/proc/vmstat", F_OK) == 0;
-
LIST_HEAD_INIT(head);
/* main program loop */
LIST_HEAD_INIT(head);
/* main program loop */
@@
-404,13
+410,16
@@
int main(int argc, char *argv[]) {
parse_env_file("/usr/lib/os-release", NEWLINE, "PRETTY_NAME", &build, NULL);
}
parse_env_file("/usr/lib/os-release", NEWLINE, "PRETTY_NAME", &build, NULL);
}
- if (has_procfs) {
- r = log_sample(samples, &sampledata);
+ if (proc)
+ rewinddir(proc);
+ else
+ proc = opendir("/proc");
+
+ /* wait for /proc to become available, discarding samples */
+ if (proc) {
+ r = log_sample(proc, samples, ps_first, &sampledata, &pscount, &n_cpus);
if (r < 0)
return EXIT_FAILURE;
if (r < 0)
return EXIT_FAILURE;
- } else {
- /* wait for /proc to become available, discarding samples */
- has_procfs = access("/proc/vmstat", F_OK) == 0;
}
sample_stop = gettime_ns();
}
sample_stop = gettime_ns();
@@
-452,12
+461,12
@@
int main(int argc, char *argv[]) {
ps = ps_first;
while (ps->next_ps) {
ps = ps->next_ps;
ps = ps_first;
while (ps->next_ps) {
ps = ps->next_ps;
- if (ps->schedstat >= 0)
- close(ps->schedstat);
- if (ps->sched >= 0)
- close(ps->sched);
- if (ps->smaps)
+ ps->schedstat = safe_close(ps->schedstat);
+ ps->sched = safe_close(ps->sched);
+ if (ps->smaps) {
fclose(ps->smaps);
fclose(ps->smaps);
+ ps->smaps = NULL;
+ }
}
if (!of) {
}
if (!of) {
@@
-470,22
+479,24
@@
int main(int argc, char *argv[]) {
}
if (!of) {
}
if (!of) {
-
fprintf(stderr, "
opening output file '%s': %m\n", output_file);
-
exit (EXIT_FAILURE)
;
+
log_error("Error
opening output file '%s': %m\n", output_file);
+
return EXIT_FAILURE
;
}
}
- svg_do(strna(build));
-
-
fprintf(stderr, "systemd-bootchart wrote %s\n", output_file
);
+ r = svg_do(of, strna(build), head, ps_first,
+ samples, pscount, n_cpus, graph_start,
+
log_start, interval, overrun
);
- do_journal_append(output_file);
+ if (r < 0) {
+ log_error_errno(r, "Error generating svg file: %m\n");
+ return EXIT_FAILURE;
+ }
- if (of)
- fclose(of);
+ log_info("systemd-bootchart wrote %s\n", output_file);
-
closedir(proc
);
- if (
sysfd >=
0)
-
close(sysfd)
;
+
r = do_journal_append(output_file
);
+ if (
r <
0)
+
return EXIT_FAILURE
;
/* nitpic cleanups */
ps = ps_first->next_ps;
/* nitpic cleanups */
ps = ps_first->next_ps;
@@
-505,6
+516,7
@@
int main(int argc, char *argv[]) {
free(old->sample);
free(old);
}
free(old->sample);
free(old);
}
+
free(ps->cgroup);
free(ps->sample);
free(ps);
free(ps->cgroup);
free(ps->sample);
free(ps);
@@
-516,6
+528,7
@@
int main(int argc, char *argv[]) {
free(old_sampledata);
}
free(sampledata);
free(old_sampledata);
}
free(sampledata);
+
/* don't complain when overrun once, happens most commonly on 1st sample */
if (overrun > 1)
log_warning("systemd-boochart: sample time overrun %i times\n", overrun);
/* don't complain when overrun once, happens most commonly on 1st sample */
if (overrun > 1)
log_warning("systemd-boochart: sample time overrun %i times\n", overrun);