chiark
/
gitweb
/
~ianmdlvl
/
elogind.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
scsi_id: export ID_SERIAL_SHORT without vendor/product
[elogind.git]
/
extras
/
scsi_id
/
scsi_serial.c
diff --git
a/extras/scsi_id/scsi_serial.c
b/extras/scsi_id/scsi_serial.c
index 0ecfebe1b6bca827e835af48a3a17aacc2f1240f..513d922559a34046b3506404aff09c4f2a4d9e08 100644
(file)
--- a/
extras/scsi_id/scsi_serial.c
+++ b/
extras/scsi_id/scsi_serial.c
@@
-179,7
+179,7
@@
static int scsi_dump_sense(struct sysfs_device *dev_scsi, struct sg_io_hdr *io)
sb_len = io->sb_len_wr;
if (sb_len < 1) {
sb_len = io->sb_len_wr;
if (sb_len < 1) {
- info("%s: sense buffer empty", dev_scsi->kernel
_name
);
+ info("%s: sense buffer empty", dev_scsi->kernel);
return -1;
}
return -1;
}
@@
-194,7
+194,7
@@
static int scsi_dump_sense(struct sysfs_device *dev_scsi, struct sg_io_hdr *io)
s = sense_buffer[7] + 8;
if (sb_len < s) {
info("%s: sense buffer too small %d bytes, %d bytes too short",
s = sense_buffer[7] + 8;
if (sb_len < s) {
info("%s: sense buffer too small %d bytes, %d bytes too short",
- dev_scsi->kernel
_name
, sb_len, s - sb_len);
+ dev_scsi->kernel, sb_len, s - sb_len);
return -1;
}
if ((code == 0x0) || (code == 0x1)) {
return -1;
}
if ((code == 0x0) || (code == 0x1)) {
@@
-205,7
+205,7
@@
static int scsi_dump_sense(struct sysfs_device *dev_scsi, struct sg_io_hdr *io)
* Possible?
*/
info("%s: sense result too" " small %d bytes",
* Possible?
*/
info("%s: sense result too" " small %d bytes",
- dev_scsi->kernel
_name
, s);
+ dev_scsi->kernel, s);
return -1;
}
asc = sense_buffer[12];
return -1;
}
asc = sense_buffer[12];
@@
-217,25
+217,25
@@
static int scsi_dump_sense(struct sysfs_device *dev_scsi, struct sg_io_hdr *io)
ascq = sense_buffer[3];
} else {
info("%s: invalid sense code 0x%x",
ascq = sense_buffer[3];
} else {
info("%s: invalid sense code 0x%x",
- dev_scsi->kernel
_name
, code);
+ dev_scsi->kernel, code);
return -1;
}
info("%s: sense key 0x%x ASC 0x%x ASCQ 0x%x",
return -1;
}
info("%s: sense key 0x%x ASC 0x%x ASCQ 0x%x",
- dev_scsi->kernel
_name
, sense_key, asc, ascq);
+ dev_scsi->kernel, sense_key, asc, ascq);
} else {
if (sb_len < 4) {
info("%s: sense buffer too small %d bytes, %d bytes too short",
} else {
if (sb_len < 4) {
info("%s: sense buffer too small %d bytes, %d bytes too short",
- dev_scsi->kernel
_name
, sb_len, 4 - sb_len);
+ dev_scsi->kernel, sb_len, 4 - sb_len);
return -1;
}
if (sense_buffer[0] < 15)
return -1;
}
if (sense_buffer[0] < 15)
- info("%s: old sense key: 0x%x", dev_scsi->kernel
_name
, sense_buffer[0] & 0x0f);
+ info("%s: old sense key: 0x%x", dev_scsi->kernel, sense_buffer[0] & 0x0f);
else
info("%s: sense = %2x %2x",
else
info("%s: sense = %2x %2x",
- dev_scsi->kernel
_name
, sense_buffer[0], sense_buffer[2]);
+ dev_scsi->kernel, sense_buffer[0], sense_buffer[2]);
info("%s: non-extended sense class %d code 0x%0x",
info("%s: non-extended sense class %d code 0x%0x",
- dev_scsi->kernel
_name
, sense_class, code);
+ dev_scsi->kernel, sense_class, code);
}
}
@@
-247,8
+247,8
@@
static int scsi_dump_sense(struct sysfs_device *dev_scsi, struct sg_io_hdr *io)
out_buffer[j++] = ' ';
}
out_buffer[j] = '\0';
out_buffer[j++] = ' ';
}
out_buffer[j] = '\0';
- info("%s: sense dump:", dev_scsi->kernel
_name
);
- info("%s: %s", dev_scsi->kernel
_name
, out_buffer);
+ info("%s: sense dump:", dev_scsi->kernel);
+ info("%s: %s", dev_scsi->kernel, out_buffer);
#endif
return -1;
#endif
return -1;
@@
-266,7
+266,7
@@
static int scsi_dump(struct sysfs_device *dev_scsi, struct sg_io_hdr *io)
}
info("%s: sg_io failed status 0x%x 0x%x 0x%x 0x%x",
}
info("%s: sg_io failed status 0x%x 0x%x 0x%x 0x%x",
- dev_scsi->kernel
_name
, io->driver_status, io->host_status, io->msg_status, io->status);
+ dev_scsi->kernel, io->driver_status, io->host_status, io->msg_status, io->status);
if (io->status == SCSI_CHECK_CONDITION)
return scsi_dump_sense(dev_scsi, io);
else
if (io->status == SCSI_CHECK_CONDITION)
return scsi_dump_sense(dev_scsi, io);
else
@@
-290,7
+290,7
@@
static int scsi_inquiry(struct sysfs_device *dev_scsi, int fd,
}
resend:
}
resend:
- dbg("%s evpd %d, page 0x%x\n", dev_scsi->kernel
_name
, evpd, page);
+ dbg("%s evpd %d, page 0x%x\n", dev_scsi->kernel, evpd, page);
memset(&io_hdr, 0, sizeof(struct sg_io_hdr));
io_hdr.interface_id = 'S';
memset(&io_hdr, 0, sizeof(struct sg_io_hdr));
io_hdr.interface_id = 'S';
@@
-304,7
+304,7
@@
resend:
io_hdr.timeout = DEF_TIMEOUT;
if (ioctl(fd, SG_IO, &io_hdr) < 0) {
io_hdr.timeout = DEF_TIMEOUT;
if (ioctl(fd, SG_IO, &io_hdr) < 0) {
- info("%s: ioctl failed: %s", dev_scsi->kernel
_name
, strerror(errno));
+ info("%s: ioctl failed: %s", dev_scsi->kernel, strerror(errno));
retval = -1;
goto error;
}
retval = -1;
goto error;
}
@@
-328,7
+328,7
@@
resend:
retval = buflen;
} else if (retval > 0) {
if (--retry > 0) {
retval = buflen;
} else if (retval > 0) {
if (--retry > 0) {
- dbg("%s: Retrying ...\n", dev_scsi->kernel
_name
);
+ dbg("%s: Retrying ...\n", dev_scsi->kernel);
goto resend;
}
retval = -1;
goto resend;
}
retval = -1;
@@
-337,7
+337,7
@@
resend:
error:
if (retval < 0)
info("%s: Unable to get INQUIRY vpd %d page 0x%x.",
error:
if (retval < 0)
info("%s: Unable to get INQUIRY vpd %d page 0x%x.",
- dev_scsi->kernel
_name
, evpd, page);
+ dev_scsi->kernel, evpd, page);
return retval;
}
return retval;
}
@@
-355,11
+355,11
@@
static int do_scsi_page0_inquiry(struct sysfs_device *dev_scsi, int fd,
return 1;
if (buffer[1] != 0) {
return 1;
if (buffer[1] != 0) {
- info("%s: page 0 not available.", dev_scsi->kernel
_name
);
+ info("%s: page 0 not available.", dev_scsi->kernel);
return 1;
}
if (buffer[3] > len) {
return 1;
}
if (buffer[3] > len) {
- info("%s: page 0 buffer too long %d", dev_scsi->kernel
_name
, buffer[3]);
+ info("%s: page 0 buffer too long %d", dev_scsi->kernel, buffer[3]);
return 1;
}
return 1;
}
@@
-377,11
+377,11
@@
static int do_scsi_page0_inquiry(struct sysfs_device *dev_scsi, int fd,
*/
vendor = sysfs_attr_get_value(dev_scsi->devpath, "vendor");
if (!vendor) {
*/
vendor = sysfs_attr_get_value(dev_scsi->devpath, "vendor");
if (!vendor) {
- info("%s: cannot get model attribute", dev_scsi->kernel
_name
);
+ info("%s: cannot get model attribute", dev_scsi->kernel);
return 1;
}
if (!strncmp((char *)&buffer[VENDOR_LENGTH], vendor, VENDOR_LENGTH)) {
return 1;
}
if (!strncmp((char *)&buffer[VENDOR_LENGTH], vendor, VENDOR_LENGTH)) {
- info("%s: invalid page0 data", dev_scsi->kernel
_name
);
+ info("%s: invalid page0 data", dev_scsi->kernel);
return 1;
}
}
return 1;
}
}
@@
-399,7
+399,7
@@
static int prepend_vendor_model(struct sysfs_device *dev_scsi, char *serial)
attr = sysfs_attr_get_value(dev_scsi->devpath, "vendor");
if (!attr) {
attr = sysfs_attr_get_value(dev_scsi->devpath, "vendor");
if (!attr) {
- info("%s: cannot get vendor attribute", dev_scsi->kernel
_name
);
+ info("%s: cannot get vendor attribute", dev_scsi->kernel);
return 1;
}
strncpy(serial, attr, VENDOR_LENGTH);
return 1;
}
strncpy(serial, attr, VENDOR_LENGTH);
@@
-407,7
+407,7
@@
static int prepend_vendor_model(struct sysfs_device *dev_scsi, char *serial)
attr = sysfs_attr_get_value(dev_scsi->devpath, "model");
if (!attr) {
attr = sysfs_attr_get_value(dev_scsi->devpath, "model");
if (!attr) {
- info("%s: cannot get model attribute", dev_scsi->kernel
_name
);
+ info("%s: cannot get model attribute", dev_scsi->kernel);
return 1;
}
strncat(serial, attr, MODEL_LENGTH);
return 1;
}
strncat(serial, attr, MODEL_LENGTH);
@@
-420,7
+420,7
@@
static int prepend_vendor_model(struct sysfs_device *dev_scsi, char *serial)
*/
if (ind != (VENDOR_LENGTH + MODEL_LENGTH)) {
info("%s: expected length %d, got length %d",
*/
if (ind != (VENDOR_LENGTH + MODEL_LENGTH)) {
info("%s: expected length %d, got length %d",
- dev_scsi->kernel
_name
, (VENDOR_LENGTH + MODEL_LENGTH), ind);
+ dev_scsi->kernel, (VENDOR_LENGTH + MODEL_LENGTH), ind);
return 1;
}
return ind;
return 1;
}
return ind;
@@
-433,9
+433,9
@@
static int prepend_vendor_model(struct sysfs_device *dev_scsi, char *serial)
static int check_fill_0x83_id(struct sysfs_device *dev_scsi,
unsigned char *page_83,
const struct scsi_id_search_values
static int check_fill_0x83_id(struct sysfs_device *dev_scsi,
unsigned char *page_83,
const struct scsi_id_search_values
- *id_search, char *serial, int max_len)
+ *id_search, char *serial,
char *serial_short,
int max_len)
{
{
- int i, j, len;
+ int i, j,
s,
len;
/*
* ASSOCIATION must be with the device (value 0)
/*
* ASSOCIATION must be with the device (value 0)
@@
-469,7
+469,7
@@
static int check_fill_0x83_id(struct sysfs_device *dev_scsi,
*/
len *= 2;
*/
len *= 2;
-
/*
+ /*
* Add one byte for the NUL termination, and one for the id_type.
*/
len += 2;
* Add one byte for the NUL termination, and one for the id_type.
*/
len += 2;
@@
-478,7
+478,7
@@
static int check_fill_0x83_id(struct sysfs_device *dev_scsi,
if (max_len < len) {
info("%s: length %d too short - need %d",
if (max_len < len) {
info("%s: length %d too short - need %d",
- dev_scsi->kernel
_name
, max_len, len);
+ dev_scsi->kernel, max_len, len);
return 1;
}
return 1;
}
@@
-497,7
+497,7
@@
static int check_fill_0x83_id(struct sysfs_device *dev_scsi,
}
i = 4; /* offset to the start of the identifier */
}
i = 4; /* offset to the start of the identifier */
- j = strlen(serial);
+
s =
j = strlen(serial);
if ((page_83[0] & 0x0f) == SCSI_ID_ASCII) {
/*
* ASCII descriptor.
if ((page_83[0] & 0x0f) == SCSI_ID_ASCII) {
/*
* ASCII descriptor.
@@
-515,6
+515,8
@@
static int check_fill_0x83_id(struct sysfs_device *dev_scsi,
i++;
}
}
i++;
}
}
+
+ strcpy(serial_short, &serial[s]);
return 0;
}
return 0;
}
@@
-522,10
+524,11
@@
static int check_fill_0x83_id(struct sysfs_device *dev_scsi,
static int check_fill_0x83_prespc3(struct sysfs_device *dev_scsi,
unsigned char *page_83,
const struct scsi_id_search_values
static int check_fill_0x83_prespc3(struct sysfs_device *dev_scsi,
unsigned char *page_83,
const struct scsi_id_search_values
- *id_search, char *serial, int max_len)
+ *id_search, char *serial,
char *serial_short,
int max_len)
{
int i, j;
{
int i, j;
-
+
+ dbg("using pre-spc3-83 for %s.\n", dev_scsi->kernel);
serial[0] = hex_str[id_search->id_type];
/* serial has been memset to zero before */
j = strlen(serial); /* j = 1; */
serial[0] = hex_str[id_search->id_type];
/* serial has been memset to zero before */
j = strlen(serial); /* j = 1; */
@@
-534,14
+537,14
@@
static int check_fill_0x83_prespc3(struct sysfs_device *dev_scsi,
serial[j++] = hex_str[(page_83[4+i] & 0xf0) >> 4];
serial[j++] = hex_str[ page_83[4+i] & 0x0f];
}
serial[j++] = hex_str[(page_83[4+i] & 0xf0) >> 4];
serial[j++] = hex_str[ page_83[4+i] & 0x0f];
}
-
dbg("using pre-spc3-83 for %s.\n", dev_scsi->kernel_name
);
+
strcpy(serial_short, serial
);
return 0;
}
/* Get device identification VPD page */
static int do_scsi_page83_inquiry(struct sysfs_device *dev_scsi, int fd,
return 0;
}
/* Get device identification VPD page */
static int do_scsi_page83_inquiry(struct sysfs_device *dev_scsi, int fd,
- char *serial, int len)
+ char *serial,
char *serial_short,
int len)
{
int retval;
unsigned int id_ind, j;
{
int retval;
unsigned int id_ind, j;
@@
-554,7
+557,7
@@
static int do_scsi_page83_inquiry(struct sysfs_device *dev_scsi, int fd,
return 1;
if (page_83[1] != PAGE_83) {
return 1;
if (page_83[1] != PAGE_83) {
- info("%s: Invalid page 0x83", dev_scsi->kernel
_name
);
+ info("%s: Invalid page 0x83", dev_scsi->kernel);
return 1;
}
return 1;
}
@@
-588,8
+591,8
@@
static int do_scsi_page83_inquiry(struct sysfs_device *dev_scsi, int fd,
*/
if (page_83[6] != 0)
*/
if (page_83[6] != 0)
- return check_fill_0x83_prespc3(dev_scsi, page_83,
-
id_search_list, serial
, len);
+ return check_fill_0x83_prespc3(dev_scsi, page_83,
id_search_list,
+
serial, serial_short
, len);
/*
* Search for a match in the prioritized id_search_list.
/*
* Search for a match in the prioritized id_search_list.
@@
-604,8
+607,8
@@
static int do_scsi_page83_inquiry(struct sysfs_device *dev_scsi, int fd,
for (j = 4; j <= (unsigned int)page_83[3] + 3; j += page_83[j + 3] + 4) {
retval = check_fill_0x83_id(dev_scsi, &page_83[j],
&id_search_list[id_ind],
for (j = 4; j <= (unsigned int)page_83[3] + 3; j += page_83[j + 3] + 4) {
retval = check_fill_0x83_id(dev_scsi, &page_83[j],
&id_search_list[id_ind],
- serial, len);
- dbg("%s id desc %d/%d/%d\n", dev_scsi->kernel
_name
,
+ serial,
serial_short,
len);
+ dbg("%s id desc %d/%d/%d\n", dev_scsi->kernel,
id_search_list[id_ind].id_type,
id_search_list[id_ind].naa_type,
id_search_list[id_ind].code_set);
id_search_list[id_ind].id_type,
id_search_list[id_ind].naa_type,
id_search_list[id_ind].code_set);
@@
-631,7
+634,7
@@
static int do_scsi_page83_inquiry(struct sysfs_device *dev_scsi, int fd,
* conformant to the SCSI-2 format.
*/
static int do_scsi_page83_prespc3_inquiry(struct sysfs_device *dev_scsi, int fd,
* conformant to the SCSI-2 format.
*/
static int do_scsi_page83_prespc3_inquiry(struct sysfs_device *dev_scsi, int fd,
- char *serial, int len)
+ char *serial,
char *serial_short,
int len)
{
int retval;
int i, j;
{
int retval;
int i, j;
@@
-643,7
+646,7
@@
static int do_scsi_page83_prespc3_inquiry(struct sysfs_device *dev_scsi, int fd,
return 1;
if (page_83[1] != PAGE_83) {
return 1;
if (page_83[1] != PAGE_83) {
- info("%s: Invalid page 0x83", dev_scsi->kernel
_name
);
+ info("%s: Invalid page 0x83", dev_scsi->kernel);
return 1;
}
/*
return 1;
}
/*
@@
-687,13
+690,13
@@
static int do_scsi_page83_prespc3_inquiry(struct sysfs_device *dev_scsi, int fd,
serial[j++] = hex_str[page_83[i] & 0x0f];
i++;
}
serial[j++] = hex_str[page_83[i] & 0x0f];
i++;
}
- dbg("using pre-spc3-83 for %s.\n", dev_scsi->kernel
_name
);
+ dbg("using pre-spc3-83 for %s.\n", dev_scsi->kernel);
return 0;
}
/* Get unit serial number VPD page */
static int do_scsi_page80_inquiry(struct sysfs_device *dev_scsi, int fd,
return 0;
}
/* Get unit serial number VPD page */
static int do_scsi_page80_inquiry(struct sysfs_device *dev_scsi, int fd,
- char *serial, int max_len)
+ char *serial,
char *serial_short,
int max_len)
{
int retval;
int ser_ind;
{
int retval;
int ser_ind;
@@
-707,14
+710,14
@@
static int do_scsi_page80_inquiry(struct sysfs_device *dev_scsi, int fd,
return retval;
if (buf[1] != PAGE_80) {
return retval;
if (buf[1] != PAGE_80) {
- info("%s: Invalid page 0x80", dev_scsi->kernel
_name
);
+ info("%s: Invalid page 0x80", dev_scsi->kernel);
return 1;
}
len = 1 + VENDOR_LENGTH + MODEL_LENGTH + buf[3];
if (max_len < len) {
info("%s: length %d too short - need %d",
return 1;
}
len = 1 + VENDOR_LENGTH + MODEL_LENGTH + buf[3];
if (max_len < len) {
info("%s: length %d too short - need %d",
- dev_scsi->kernel
_name
, max_len, len);
+ dev_scsi->kernel, max_len, len);
return 1;
}
/*
return 1;
}
/*
@@
-728,11
+731,12
@@
static int do_scsi_page80_inquiry(struct sysfs_device *dev_scsi, int fd,
len = buf[3];
for (i = 4; i < len + 4; i++, ser_ind++)
serial[ser_ind] = buf[i];
len = buf[3];
for (i = 4; i < len + 4; i++, ser_ind++)
serial[ser_ind] = buf[i];
+ memcpy(serial_short, &buf[4], len);
return 0;
}
int scsi_get_serial (struct sysfs_device *dev_scsi, const char *devname,
return 0;
}
int scsi_get_serial (struct sysfs_device *dev_scsi, const char *devname,
- int page_code, char *serial, int len)
+ int page_code, char *serial,
char *serial_short,
int len)
{
unsigned char page0[SCSI_INQ_BUFF_LEN];
int fd;
{
unsigned char page0[SCSI_INQ_BUFF_LEN];
int fd;
@@
-744,12
+748,12
@@
int scsi_get_serial (struct sysfs_device *dev_scsi, const char *devname,
fd = open(devname, O_RDONLY | O_NONBLOCK);
if (fd < 0) {
info("%s: cannot open %s: %s",
fd = open(devname, O_RDONLY | O_NONBLOCK);
if (fd < 0) {
info("%s: cannot open %s: %s",
- dev_scsi->kernel
_name
, devname, strerror(errno));
+ dev_scsi->kernel, devname, strerror(errno));
return 1;
}
if (page_code == PAGE_80) {
return 1;
}
if (page_code == PAGE_80) {
- if (do_scsi_page80_inquiry(dev_scsi, fd, serial, len)) {
+ if (do_scsi_page80_inquiry(dev_scsi, fd, serial,
serial_short,
len)) {
retval = 1;
goto completed;
} else {
retval = 1;
goto completed;
} else {
@@
-757,7
+761,7
@@
int scsi_get_serial (struct sysfs_device *dev_scsi, const char *devname,
goto completed;
}
} else if (page_code == PAGE_83) {
goto completed;
}
} else if (page_code == PAGE_83) {
- if (do_scsi_page83_inquiry(dev_scsi, fd, serial, len)) {
+ if (do_scsi_page83_inquiry(dev_scsi, fd, serial,
serial_short,
len)) {
retval = 1;
goto completed;
} else {
retval = 1;
goto completed;
} else {
@@
-765,7
+769,7
@@
int scsi_get_serial (struct sysfs_device *dev_scsi, const char *devname,
goto completed;
}
} else if (page_code == PAGE_83_PRE_SPC3) {
goto completed;
}
} else if (page_code == PAGE_83_PRE_SPC3) {
- retval = do_scsi_page83_prespc3_inquiry(dev_scsi, fd, serial, len);
+ retval = do_scsi_page83_prespc3_inquiry(dev_scsi, fd, serial,
serial_short,
len);
if (retval) {
/*
* Fallback to servicing a SPC-2/3 compliant page 83
if (retval) {
/*
* Fallback to servicing a SPC-2/3 compliant page 83
@@
-773,7
+777,7
@@
int scsi_get_serial (struct sysfs_device *dev_scsi, const char *devname,
* conform to pre-SPC3 expectations.
*/
if (retval == 2) {
* conform to pre-SPC3 expectations.
*/
if (retval == 2) {
- if (do_scsi_page83_inquiry(dev_scsi, fd, serial, len)) {
+ if (do_scsi_page83_inquiry(dev_scsi, fd, serial,
serial_short,
len)) {
retval = 1;
goto completed;
} else {
retval = 1;
goto completed;
} else {
@@
-790,7
+794,7
@@
int scsi_get_serial (struct sysfs_device *dev_scsi, const char *devname,
goto completed;
}
} else if (page_code != 0x00) {
goto completed;
}
} else if (page_code != 0x00) {
- info("%s: unsupported page code 0x%d", dev_scsi->kernel
_name
, page_code);
+ info("%s: unsupported page code 0x%d", dev_scsi->kernel, page_code);
return 1;
}
return 1;
}
@@
-808,12
+812,12
@@
int scsi_get_serial (struct sysfs_device *dev_scsi, const char *devname,
goto completed;
}
goto completed;
}
- dbg("%s: Checking page0\n", dev_scsi->kernel
_name
);
+ dbg("%s: Checking page0\n", dev_scsi->kernel);
for (ind = 4; ind <= page0[3] + 3; ind++)
if (page0[ind] == PAGE_83)
for (ind = 4; ind <= page0[3] + 3; ind++)
if (page0[ind] == PAGE_83)
- if (!do_scsi_page83_inquiry(dev_scsi, fd,
serial,
- len)) {
+ if (!do_scsi_page83_inquiry(dev_scsi, fd,
+
serial, serial_short,
len)) {
/*
* Success
*/
/*
* Success
*/
@@
-823,8
+827,8
@@
int scsi_get_serial (struct sysfs_device *dev_scsi, const char *devname,
for (ind = 4; ind <= page0[3] + 3; ind++)
if (page0[ind] == PAGE_80)
for (ind = 4; ind <= page0[3] + 3; ind++)
if (page0[ind] == PAGE_80)
- if (!do_scsi_page80_inquiry(dev_scsi, fd,
serial,
- len)) {
+ if (!do_scsi_page80_inquiry(dev_scsi, fd,
+
serial, serial_short,
len)) {
/*
* Success
*/
/*
* Success
*/
@@
-834,6
+838,6
@@
int scsi_get_serial (struct sysfs_device *dev_scsi, const char *devname,
retval = 1;
completed:
if (close(fd) < 0)
retval = 1;
completed:
if (close(fd) < 0)
- info("%s: close failed: %s", dev_scsi->kernel
_name
, strerror(errno));
+ info("%s: close failed: %s", dev_scsi->kernel, strerror(errno));
return retval;
}
return retval;
}