3 # Simple pre-commit hook to check that there are no errors in the fdroidserver
6 # Redirect output to stderr.
9 files=`git diff-index --cached HEAD 2>&1 | sed 's/^:.* //' | uniq | cut -b100-500`
10 if [ -z "$files" ]; then
11 PY_FILES="fdroid makebuildserver setup.py examples/*.py buildserver/*.py fdroidserver/*.py"
12 PY_TEST_FILES="tests/*.TestCase"
13 SH_FILES="hooks/pre-commit"
14 BASH_FILES="jenkins-build-all jenkins-setup-build-environment jenkins-test completion/bash-completion buildserver/provision-*"
15 RB_FILES="buildserver/Vagrantfile"
17 # if actually committing right now, then only run on the files
18 # that are going to be committed at this moment
26 test -e $f || continue
38 if head -1 $f | grep '^#!/bin/sh' > /dev/null 2>&1; then
40 elif head -1 $f | grep '^#!/bin/bash' > /dev/null 2>&1; then
42 elif head -1 $f | grep '^#!.*python' > /dev/null 2>&1; then
50 # We ignore the following PEP8 warnings
51 # * E123: closing bracket does not match indentation of opening bracket's line
52 # - Broken if multiple indentation levels start on a single line
53 # * E501: line too long (82 > 79 characters)
54 # - Recommended for readability but not enforced
55 # - Some lines are awkward to wrap around a char limit
56 # * W503: line break before binary operator
59 PEP8_IGNORE="E123,E501,W503"
67 echo >&2 WARNING: "$@"
71 command -v $1 1>/dev/null
76 for suff in "3" "-3" "-python3" ""; do
78 if cmd_exists $cmd; then
84 warn "$1 is not installed, using dummy placeholder!"
88 DASH=$(find_command dash)
89 PYFLAKES=$(find_command pyflakes)
90 PEP8=$(find_command pycodestyle pep8)
91 RUBY=$(find_command ruby)
93 if [ "$PY_FILES $PY_TEST_FILES" != " " ]; then
94 if ! $PYFLAKES $PY_FILES $PY_TEST_FILES; then
95 err "pyflakes tests failed!"
99 if [ "$PY_FILES" != "" ]; then
100 if ! $PEP8 --ignore=$PEP8_IGNORE $PY_FILES; then
101 err "pep8 tests failed!"
105 # The tests use a little hack in order to cleanly import the fdroidserver
106 # package locally like a regular package. pep8 doesn't see that, so this
107 # makes pep8 skip E402 on the test files that need that hack.
108 if [ "$PY_TEST_FILES" != "" ]; then
109 if ! $PEP8 --ignore=$PEP8_IGNORE,E402 $PY_TEST_FILES; then
110 err "pep8 tests failed!"
114 for f in $SH_FILES; do
115 if ! $DASH -n $f; then
116 err "dash tests failed!"
120 for f in $BASH_FILES; do
121 if ! bash -n $f; then
122 err "bash tests failed!"
126 for f in $RB_FILES; do
127 if ! $RUBY -c $f 1>/dev/null; then
128 err "ruby tests failed!"
132 if grep --line-number 'shell=True' fdroidserver/[a-ce-z]*.py; then
133 err "shell=True is too dangerous, there are unfiltered user inputs!"