3 # Simple pre-commit hook to check that there are no errors in the fdroidserver
6 # Redirect output to stderr.
9 files=`git diff-index --cached HEAD 2>&1 | sed 's/^:.* //' | uniq | cut -b100-500`
10 if [ -z "$files" ]; then
11 PY_FILES="fdroid makebuildserver setup.py examples/*.py buildserver/*.py fdroidserver/*.py"
12 PY_TEST_FILES="tests/*.TestCase"
13 SH_FILES="hooks/pre-commit"
14 BASH_FILES="fd-commit jenkins-build docs/update.sh completion/bash-completion"
15 RB_FILES="buildserver/cookbooks/*/recipes/*.rb"
17 # if actually committing right now, then only run on the files
18 # that are going to be committed at this moment
37 if head -1 $f | grep '^#!/bin/sh' > /dev/null 2>&1; then
39 elif head -1 $f | grep '^#!/bin/bash' > /dev/null 2>&1; then
41 elif head -1 $f | grep '^#!.*python' > /dev/null 2>&1; then
49 # In the default configuration, the checks E123, E133, E226, E241 and E242 are
50 # ignored because they are not rules unanimously accepted
51 # On top of those, we ignore:
52 # * E501: line too long (82 > 79 characters)
53 # - Recommended for readability but not enforced
54 # - Some lines are awkward to wrap around a char limit
55 # * W503: line break before binary operator
59 PEP8_IGNORE="E123,E133,E226,E241,E242,E501,W503"
71 command -v $1 1>/dev/null
74 if cmd_exists pyflakes-python2; then
75 PYFLAKES=pyflakes-python2
76 elif cmd_exists pyflakes; then
80 warn "pyflakes is not installed, using dummy placeholder!"
83 if cmd_exists pep8-python2; then
85 elif cmd_exists pep8; then
88 err "pep8 is not installed!"
91 if [ "$PY_FILES $PY_TEST_FILES" != " " ]; then
92 if ! $PYFLAKES $PY_FILES $PY_TEST_FILES; then
93 err "pyflakes tests failed!"
97 if [ "$PY_FILES" != "" ]; then
98 if ! $PEP8 --ignore=$PEP8_IGNORE $PY_FILES; then
99 err "pep8 tests failed!"
103 # The tests use a little hack in order to cleanly import the fdroidserver
104 # package locally like a regular package. pep8 doesn't see that, so this
105 # makes pep8 skip E402 on the test files that need that hack.
106 if [ "$PY_TEST_FILES" != "" ]; then
107 if ! $PEP8 --ignore=$PEP8_IGNORE,E402 $PY_TEST_FILES; then
108 err "pep8 tests failed!"
112 for f in $SH_FILES; do
113 if ! dash -n $f; then
114 err "dash tests failed!"
118 for f in $BASH_FILES; do
119 if ! bash -n $f; then
120 err "bash tests failed!"
124 for f in $RB_FILES; do
125 if ! ruby -c $f 1>/dev/null; then
126 err "ruby tests failed!"